On Thu, Jun 15, 2023 at 11:02 AM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > On Wed, Jun 14, 2023 at 4:47 PM Michael Paquier <mich...@paquier.xyz> wrote: > > > > On Wed, Jun 14, 2023 at 03:38:10PM +0800, Richard Guo wrote: > > > +1. BTW, it seems that GUC_UNIT_TIME is not used anywhere except in > > > GUC_UNIT. I was wondering if we can retire it, but maybe we'd better > > > not. It still indicates that we need to use time units table. > > > > Some out-of-core code declaring custom GUCs could rely on that, so > > it is better not to remove it. > > +1 not to remove it. > > I've attached the patch to fix (GUC_UNIT_MEMORY | GUC_UNIT_TIME) > thing, and am going to push it later today to only master branch.
Pushed. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com