On Wed, Jun 14, 2023 at 1:07 PM Masahiko Sawada <sawada.m...@gmail.com> wrote:
> On Wed, Jun 14, 2023 at 12:33 PM Japin Li <japi...@hotmail.com> wrote: > > Hi, hackers > > > > We use (GUC_UNIT_MEMORY | GUC_UNIT_TIME) instead of GUC_UNIT even though > we > > already define it in guc.h. > > > > Maybe using GUC_UNIT is better? Here is a patch to fix it. > > Yeah, it seems more consistent with other places in guc.c. I'll push > it, barring any objections. +1. BTW, it seems that GUC_UNIT_TIME is not used anywhere except in GUC_UNIT. I was wondering if we can retire it, but maybe we'd better not. It still indicates that we need to use time units table. Thanks Richard
