Hi, hackers
We use (GUC_UNIT_MEMORY | GUC_UNIT_TIME) instead of GUC_UNIT even though we already define it in guc.h. Maybe using GUC_UNIT is better? Here is a patch to fix it. diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index a9033b7a54..5308896c87 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -2766,7 +2766,7 @@ convert_real_from_base_unit(double base_value, int base_unit, const char * get_config_unit_name(int flags) { - switch (flags & (GUC_UNIT_MEMORY | GUC_UNIT_TIME)) + switch (flags & GUC_UNIT) { case 0: return NULL; /* GUC has no units */ @@ -2802,7 +2802,7 @@ get_config_unit_name(int flags) return "min"; default: elog(ERROR, "unrecognized GUC units value: %d", - flags & (GUC_UNIT_MEMORY | GUC_UNIT_TIME)); + flags & GUC_UNIT); return NULL; } } -- Regrads, Japin Li.