Thank for working on this, Peter! On Fri, Feb 3, 2023 at 6:50 PM Peter Geoghegan <p...@bowt.ie> wrote: > > I think that we should focus on getting the GiST patch into shape for > commit first, since that seems easier. >
Here's the next version. I've focused on GiST part in this revision. Changes: 1. Refactored index_chackable so that is shared between all AMs. 2. Renamed gist_index_parent_check -> gist_index_check 3. Gathered reviewers (in no particular order). I hope I didn't forget anyone. GIN patch is based on work by Grigory Kryachko, but essentially rewritten by Heikki. Somewhat cosmetically whacked by me. 4. Extended comments for GistScanItem, gist_check_parent_keys_consistency() and gist_refind_parent(). I tried adding support of GiST in pg_amcheck, but it is largely assuming the relation is either heap or B-tree. I hope to do that part tomorrow or in nearest future. Here's the current version. Thank you! Best regards, Andrey Borodin.
v23-0001-Refactor-amcheck-to-extract-common-locking-routi.patch
Description: Binary data
v23-0002-Add-gist_index_check-function-to-verify-GiST-ind.patch
Description: Binary data
v23-0003-Add-gin_index_parent_check-to-verify-GIN-index.patch
Description: Binary data
