On Tue, Jan 17, 2023 at 12:31 PM Michael Paquier <mich...@paquier.xyz> wrote: > > On Mon, Dec 26, 2022 at 06:12:34PM +0530, Bharath Rupireddy wrote: > > It looks like assign_checkpoint_completion_target() is defined [1], > > but never used, because of which CheckPointSegments may miss to > > account for changed checkpoint_completion_target. I'm attaching a tiny > > patch to fix this. > > > > Thoughts? > > Oops. It looks like you are right here. This would impact the > calculation of CheckPointSegments on reload when > checkpoint_completion_target is updated. This is wrong since we've > switched to max_wal_size as of 88e9823, so this had better be > backpatched all the way down. > > Thoughts?
+1 to backpatch as setting checkpoint_completion_target will not take effect immediately. -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
