Hi,
It looks like assign_checkpoint_completion_target() is defined [1],
but never used, because of which CheckPointSegments may miss to
account for changed checkpoint_completion_target. I'm attaching a tiny
patch to fix this.
Thoughts?
[1]
commit 88e982302684246e8af785e78a467ac37c76dee9
Author: Heikki Linnakangas <heikki.linnakan...@iki.fi>
Date: Mon Feb 23 18:53:02 2015 +0200
Replace checkpoint_segments with min_wal_size and max_wal_size.
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
From ea9803c77b32b5d42ba7f5e1c8130f618b6322be Mon Sep 17 00:00:00 2001
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: Mon, 26 Dec 2022 12:21:56 +0000
Subject: [PATCH v1] Make use of assign_checkpoint_completion_target() to
calculate CheckPointSegments correctly
---
src/backend/utils/misc/guc_tables.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/utils/misc/guc_tables.c b/src/backend/utils/misc/guc_tables.c
index a37c9f9844..948e1ae5aa 100644
--- a/src/backend/utils/misc/guc_tables.c
+++ b/src/backend/utils/misc/guc_tables.c
@@ -3701,7 +3701,7 @@ struct config_real ConfigureNamesReal[] =
},
&CheckPointCompletionTarget,
0.9, 0.0, 1.0,
- NULL, NULL, NULL
+ NULL, assign_checkpoint_completion_target, NULL
},
{
--
2.34.1
