On Wed, Oct 19, 2022 at 2:30 PM Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > > Another point before we move on with your 0002 is that forcePageWrites > is no longer useful and we can remove it, as per the attached.
+1. The following comment enables us to rely on runningBackups and get
rid of forcePageWrites completely.
* in progress. forcePageWrites is set to true when runningBackups is
* non-zero. lastBackupStart is the latest checkpoint redo location used
When the standby is in recovery, calls to XLogInsertRecord() or
AdvanceXLInsertBuffer()) where forcePageWrites is being used, won't
happen, no?
* Note that forcePageWrites has no effect during an online backup from
- * the standby.
+ * the standby. XXX what does this mean??
I removed the 2 more instances of forcePageWrites left-out and tweaked
the comments a little and attached 0002.
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
v2-0001-get-rid-of-forcePageWrites.patch
Description: Binary data
