On Tue, Jul 26, 2022 at 2:59 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > I had not actually read the patch, but now that I have, it's got > a basic typing error: > > + bool should_be_super = BoolGetDatum(boolVal(dissuper->arg)); > + > + if (!should_be_super && roleid == BOOTSTRAP_SUPERUSERID) > + ereport(ERROR, > > The result of BoolGetDatum is not bool, it's Datum. This is > probably harmless, but it's still a typing violation. > You want something like > > bool should_be_super = boolVal(dissuper->arg); > ... > new_record[Anum_pg_authid_rolsuper - 1] = > BoolGetDatum(should_be_super);
Oops. Will fix. -- Robert Haas EDB: http://www.enterprisedb.com
