On Tue, May 24, 2022 1:34 AM vignesh C <vignes...@gmail.com> wrote:
>
> Thanks for the comments, the attached v15 patch has the fixes for the same.
>
Thanks for updating the patch. I have a comment on the document in 0002 patch.
@@ -300,6 +310,11 @@ CREATE SUBSCRIPTION <replaceable
class="parameter">subscription_name</replaceabl
replication from the publisher. The default is
<literal>false</literal>.
</para>
+ <para>
+ There is some interaction between the <literal>only_local</literal>
+ option and <literal>copy_data</literal> option. Refer to the
+ <xref linkend="sql-createsubscription-notes" /> for details.
+ </para>
</listitem>
</varlistentry>
This change is related to "only_local" option and "copy_data" option, so I think
it should be put together with "only_local", instead of "disable_on_error".
Besides, I tested some cross version cases, pg_dump and describe command, the
results are all as expected.
Regards,
Shi yu
