Mark Dilger <mark.dil...@enterprisedb.com> writes: >> On Apr 4, 2022, at 12:05 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> So scratch that. Maybe we'd better add "could not send data to server" >> to the regex?
> If it fails in pqsecure_raw_write(), you get either "server closed the > connection unexpectedly" or "could not send data to server". Do we need to > support pgtls_write() or pg_GSS_write(), which have different error messages? Don't see why, since this test sets up a new cluster in which neither is enabled. > Is it possible that pgFlush will call pqSendSome which calls pqReadData > before trying to write anything, and get back a "could not receive data from > server" from pqsecure_raw_read()? Yeah, it's plausible to get a failure on either the write or read side depending on timing. Perhaps libpq should be trying harder to make those cases look alike, but this test is about server behavior not libpq behavior, so I'm inclined to just make it lax. regards, tom lane