On Wed, Oct 27, 2021 at 2:28 PM houzj.f...@fujitsu.com
<houzj.f...@fujitsu.com> wrote:
>
> When reviewing the v18-0002 patch.
> I noticed that "RESET SYNCHRONOUS_COMMIT" does not take effect
> (RESET doesn't change the value to 'off').
>
>
> + if (!is_reset)
> + {
> + opts->synchronous_commit =
> defGetString(defel);
>
> - ...
> + }
>
> I think we need to add else branch here to set the synchronous_commit to
> 'off'.
>
I agree that it doesn't seem to handle the RESET of synchronous_commit.
I think that for consistency, the default value "off" for
synchronous_commit should be set (in the SubOpts) near where the
default values of the boolean supported options are currently set -
near the top of parse_subscription_options().
Regards,
Greg Nancarrow
Fujitsu Australia
