On Thu, Oct 14, 2021 at 5:45 PM Greg Nancarrow <gregn4...@gmail.com> wrote: > > On Tue, Oct 12, 2021 at 4:00 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > > > I've attached updated patches. > > > > A couple more comments for some issues that I noticed in the v16 patches: > > v16-0002 > > doc/src/sgml/ref/alter_subscription.sgml > > (1) Order of parameters that can be reset doesn't match those that can be set. > Also, it doesn't match the order specified in the documentation > updates in the v16-0003 patch. > > Suggested change: > > BEFORE: > + The parameters that can be reset are: <literal>streaming</literal>, > + <literal>binary</literal>, <literal>synchronous_commit</literal>. > AFTER: > + The parameters that can be reset are: > <literal>synchronous_commit</literal>, > + <literal>binary</literal>, <literal>streaming</literal>. >
Fixed. > > v16-0003 > > doc/src/sgml/ref/alter_subscription.sgml > > (1) Documentation update says "slot_name" is a parameter that can be > reset, but this is not correct, it can't be reset. > Also, the doc update is missing "the" before "parameter". > > Suggested change: > > BEFORE: > + The parameters that can be reset are: <literal>slot_name</literal>, > + <literal>synchronous_commit</literal>, <literal>binary</literal>, > + <literal>streaming</literal>, and following parameter: > AFTER: > + The parameters that can be reset are: > <literal>synchronous_commit</literal>, > + <literal>binary</literal>, <literal>streaming</literal>, and > the following > + parameter: Fixed. I've attached updated patches that incorporate all comments I got so far. Regards, -- Masahiko Sawada EDB: https://www.enterprisedb.com/
v17-0003-Add-skip_xid-option-to-ALTER-SUBSCRIPTION.patch
Description: Binary data
v17-0002-Add-RESET-command-to-ALTER-SUBSCRIPTION-command.patch
Description: Binary data
v17-0001-Add-a-subscription-errors-statistics-view-pg_sta.patch
Description: Binary data
