On Wed, Oct 20, 2021 at 12:33 PM Greg Nancarrow <gregn4...@gmail.com> wrote: > > On Mon, Oct 18, 2021 at 12:34 PM Masahiko Sawada <sawada.m...@gmail.com> > wrote: > > > > I've attached updated patches that incorporate all comments I got so far. > > > > Minor comment on patch 17-0003
Thank you for the comment! > > src/backend/replication/logical/worker.c > > (1) Typo in apply_handle_stream_abort() comment: > > /* Stop skipping transaction transaction, if enabled */ > should be: > /* Stop skipping transaction changes, if enabled */ Fixed. I've attached updated patches. In this version, in addition to the review comments I go so far, I've changed the view name from pg_stat_subscription_errors to pg_stat_subscription_workers as per the discussion on including xact info to the view on another thread[1]. I’ve also changed related codes accordingly. Regards, [1] https://www.postgresql.org/message-id/CAD21AoDF7LmSALzMfmPshRw_xFcRz3WvB-me8T2gO6Ht%3D3zL2w%40mail.gmail.com -- Masahiko Sawada EDB: https://www.enterprisedb.com/
v18-0003-Add-skip_xid-option-to-ALTER-SUBSCRIPTION.patch
Description: Binary data
v18-0002-Add-RESET-command-to-ALTER-SUBSCRIPTION-command.patch
Description: Binary data
v18-0001-Add-a-subscription-worker-statistics-view-pg_sta.patch
Description: Binary data
