On Mon, Oct 25, 2021 at 1:11 PM vignesh C <vignes...@gmail.com> wrote: > > On Mon, Oct 25, 2021 at 10:52 AM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > On Fri, Oct 22, 2021 at 8:56 PM vignesh C <vignes...@gmail.com> wrote: > > > > > > > I am getting a compilation error in the latest patch on HEAD. I think > > was relying on some variable removed by a recent commit > > 92316a4582a5714d4e494aaf90360860e7fec37a. While looking at that > > compilation error, I observed that we don't need the second and third > > parameters in pg_dump.c/getPublicationNamespaces() as those are not > > getting used. > > I have fixed this in the v47 version attached. >
Thanks, the first patch in the series "Allow publishing the tables of schema." looks good to me. Unless there are more comments/bugs/objections, I am planning to commit it in a day or so. -- With Regards, Amit Kapila.
