Fujita-san, On 2018/01/26 21:31, Etsuro Fujita wrote: > (2018/01/26 10:15), Amit Langote wrote: >> On 2018/01/25 21:17, Etsuro Fujita wrote: >>> Some minor comments: >>> >>> + /* >>> + * Construct an ArrayExpr for the non-null partition >>> + * values >>> + */ >>> + arrexpr = makeNode(ArrayExpr); >>> + arrexpr->array_typeid = >>> + !type_is_array(key->parttypid[0]) >>> + ? >>> get_array_type(key->parttypid[0]) >>> + : key->parttypid[0]; >>> >>> We test the type_is_array() above in this bit, so I don't think we need to >>> test that again here. >> >> Ah, you're right. Fixed. > > Thanks. I think the updated version is fine, but I think we can simplify > the change in this part a bit further, so I modified your patch. I also > adjusted some comments in that change a little bit. Attached is a modified > version of the patch. What do you think about that? Please let me know. > If that is okay, I'll mark this as Ready for Committer.
That looks good, thanks. Regards, Amit
