Peter Eisentraut wrote: > On 12/15/17 17:34, Michael Paquier wrote: > > On Sat, Dec 16, 2017 at 2:39 AM, Peter Eisentraut > > <peter.eisentr...@2ndquadrant.com> wrote:
> > That's the whole point of not having "default" in the switches, no? > > Any object additions would be caught at compilation time. > > I think the purpose of EventTriggerSupportsGrantObjectType() is to tell > which object types are supported for event triggers. The purpose is not > to tell which object types are supported by GRANT. > > The way I have written it, if GRANT gets support for a new object type, > then event trigger support automatically happens, without having to > update another list. That's correct, and using a single implementation as in the posted patch is desirable. I was not happy about having to add EventTriggerSupportsGrantObjectType (c.f. commit 296f3a605384). -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
