On Thu, Dec 21, 2017 at 1:19 AM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 12/20/17 10:37, Alvaro Herrera wrote: >> I think Michael's point is that instead of a "default:" clause, this >> switch should list all the known values of the enum and throw an >> "unsupported object type" error for them. So whenever somebody adds a >> new object type, the compiler will complain that this switch doesn't >> handle it and the developer will have to think about this function.
Thanks Álvaro, that's exactly the point I am coming at. The previous version of the patch was breaking an existing flow. > Right. I was actually looking at a later patch that I had not sent in > yet that had already addressed that. So here it is. Thanks for the new version. I have looked at 0001, and this looks acceptable for me in this shape. In the set of things that could be improved, but I am of course not asking about those being addressed in this patch... Things could be made more consistent for ExecGrantStmt_oids, objectNamesToOids, objectsInSchemaToOids, SetDefaultACL and ExecAlterDefaultPrivilegesStmt for the switch/case handlings. I have not looked at 0002 in details. -- Michael
