On 12/13/17 02:35, Michael Paquier wrote: > Patch 0001 is simply removing EventTriggerSupportsGrantObjectType(), > but shouldn't we keep it and return an error for objects that have no > GRANT support? Returning conditionally true looks like a trap waiting > to take someone in.
I don't understand the motivation for this. It would just be two lists for the same thing. I think the potential for omission would be much greater that way. > Similarly, not using default in the switches of > stringify_adefprivs_objtype() and stringify_grantobjtype() would be > nice to grab warnings during compilation. And patch 0002 is doing it > the correct way in aclcheck_error(). I'll fix that. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
