On Fri, Dec 15, 2017 at 12:40 PM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 12/14/17 22:59, Rushabh Lathia wrote: >> I noted that no_priv_msg and not_owner_msg array been removed >> and code fitted the code into aclcheck_error(). Actually that >> makes the code more complex then what it used to be. I would >> prefer the array rather then code been fitted into the function. > > There is an argument for having a big array versus the switch/case > approach. But most existing code around object addresses uses the > switch/case approach, so it's better to align it that way, I think. > It's weird to have to maintain two different styles.
Eh, really? What about the two big arrays at the top of objectaddress.c? (This is just a drive-by comment; I haven't looked at the details of this patch.) -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
