On 12/14/17 22:59, Rushabh Lathia wrote: > I noted that no_priv_msg and not_owner_msg array been removed > and code fitted the code into aclcheck_error(). Actually that > makes the code more complex then what it used to be. I would > prefer the array rather then code been fitted into the function.
There is an argument for having a big array versus the switch/case approach. But most existing code around object addresses uses the switch/case approach, so it's better to align it that way, I think. It's weird to have to maintain two different styles. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
