Excerpts from Robert Haas's message of vie jun 03 12:44:45 -0400 2011:
> On Wed, Jun 1, 2011 at 2:28 PM, Robert Haas <robertmh...@gmail.com> wrote:

> > (4) It strikes me that it might be possible to address this problem a
> > bit more cleanly by allowing mdnblocks() and smgrnblocks() and
> > RelationGetNumberOfBlocksInFork() to take a boolean argument
> > indicating whether or not an error should be thrown if the underlying
> > physical file happens not to exist.  When no error is to be signaled,
> > we simply return 0 when the main fork doesn't exist, rather than
> > throwing an error.
> 
> If we don't want to gum this with the above-mentioned cruft, the other
> obvious alternative here is to do nothing, and live with the
> non-beauty of the resulting error message.

Option 4 seems reasonable to me ... can you get rid of the dupe
smgrnblocks call simultaneously?

-- 
Álvaro Herrera <alvhe...@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs

Reply via email to