On 22 jun 2009, at 18.05, Tom Lane <t...@sss.pgh.pa.us> wrote:
Magnus Hagander <mag...@hagander.net> writes:
How about the attached patch? Does it work for you?
The existing references to typedef ENGINE and associated functions are
wrapped in
#if (SSLEAY_VERSION_NUMBER >= 0x00907000L) && !defined
(OPENSSL_NO_ENGINE)
I rather imagine that this patch will cause complete failure in builds
where that's not true.
Yeah, that will have to be fixed.
I'm also a bit concerned about wrapping a struct
field inside such an #if, as that's likely to cause hard-to-debug
problems if two compilations read libpq-int.h with different #define
environments.
Since it's a pointer we could just declare it as void, no? Or even #if
between void and "real" pointer. Wouldn't that be safe?
(we already have a similar issue with the whole #ifdef use_ssl, don't
we? But having one isn't an excuse to create another of course…)
/Magnus
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
