Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 502eb3d2338e66780d61471cd54f5ab8f9c845f4
https://github.com/Perl/perl5/commit/502eb3d2338e66780d61471cd54f5ab8f9c845f4
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 2642b8dfc5d0658e4a4874e69e88a2ea4079f730
https://github.com/Perl/perl5/commit/2642b8dfc5d0658e4a4874e69e88a2ea4079f730
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: de1ce2c65b8977849f59e6fdc5429d698af8b922
https://github.com/Perl/perl5/commit/de1ce2c65b8977849f59e6fdc5429d698af8b922
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: a25e69cff50b2416132064008bbd5ff44dc48e57
https://github.com/Perl/perl5/commit/a25e69cff50b2416132064008bbd5ff44dc48e57
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: bdf44fc499128f04368b709aebb0fe558be917ef
https://github.com/Perl/perl5/commit/bdf44fc499128f04368b709aebb0fe558be917ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 7f3e8c386bbc33dfc72cb7eb415ed8a29b7de904
https://github.com/Perl/perl5/commit/7f3e8c386bbc33dfc72cb7eb415ed8a29b7de904
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 5df5777d89fe7b16cc5fddab5d036520f625e9a4
https://github.com/Perl/perl5/commit/5df5777d89fe7b16cc5fddab5d036520f625e9a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 0bc7fb5ad70b8995baa6b6ddf3147fd854ce1667
https://github.com/Perl/perl5/commit/0bc7fb5ad70b8995baa6b6ddf3147fd854ce1667
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 5589e1a7b66f0b9880fae8bcfec6f4b757c0745a
https://github.com/Perl/perl5/commit/5589e1a7b66f0b9880fae8bcfec6f4b757c0745a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 4d88ac0152bec989c8f9c0366c6b5dc2f085b176
https://github.com/Perl/perl5/commit/4d88ac0152bec989c8f9c0366c6b5dc2f085b176
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: a7007bca9f8a0c6770a7fcd4023db2159db7678d
https://github.com/Perl/perl5/commit/a7007bca9f8a0c6770a7fcd4023db2159db7678d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 2fa31e14108ba4489186414c37045e1cf74a1fbf
https://github.com/Perl/perl5/commit/2fa31e14108ba4489186414c37045e1cf74a1fbf
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: b0a75a59d697850f53b16a67566d67fc4650f5ce
https://github.com/Perl/perl5/commit/b0a75a59d697850f53b16a67566d67fc4650f5ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: e2fb51eb6b1cc235c1b3354ac3238ca6b698e549
https://github.com/Perl/perl5/commit/e2fb51eb6b1cc235c1b3354ac3238ca6b698e549
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: ed508d5dd0d5a35ba0339c5a2b204f6f0982b998
https://github.com/Perl/perl5/commit/ed508d5dd0d5a35ba0339c5a2b204f6f0982b998
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 20e4564bf6e7464b710c21c754e6984c1a50662a
https://github.com/Perl/perl5/commit/20e4564bf6e7464b710c21c754e6984c1a50662a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 0065963882b5442090d2292cb66b038d49f262a0
https://github.com/Perl/perl5/commit/0065963882b5442090d2292cb66b038d49f262a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 5b4f456633da99a79c73fa7745b399bec2007000
https://github.com/Perl/perl5/commit/5b4f456633da99a79c73fa7745b399bec2007000
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 9294fe9b676dc8cf39dedacf46d6989d1cc27ba1
https://github.com/Perl/perl5/commit/9294fe9b676dc8cf39dedacf46d6989d1cc27ba1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: f52080b47a8379f0a90b24abac4d4d7ad63d0145
https://github.com/Perl/perl5/commit/f52080b47a8379f0a90b24abac4d4d7ad63d0145
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 8ba755197322b6d8df00c0b3f949720c3b9cdf2f
https://github.com/Perl/perl5/commit/8ba755197322b6d8df00c0b3f949720c3b9cdf2f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: d09af75b15e1c6926834b5afc874ba83e7667cb4
https://github.com/Perl/perl5/commit/d09af75b15e1c6926834b5afc874ba83e7667cb4
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 432ae545273a6337648ecb62f45cb9ede6f1863d
https://github.com/Perl/perl5/commit/432ae545273a6337648ecb62f45cb9ede6f1863d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 98da5962f62bcb0ac58b1752ec4d052e571a402e
https://github.com/Perl/perl5/commit/98da5962f62bcb0ac58b1752ec4d052e571a402e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 86e5d7062a63ca05d01a505e1b12db58e20eb644
https://github.com/Perl/perl5/commit/86e5d7062a63ca05d01a505e1b12db58e20eb644
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 9fc9c74e27977715c0ee9e2c7e924d7a3a8265d8
https://github.com/Perl/perl5/commit/9fc9c74e27977715c0ee9e2c7e924d7a3a8265d8
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 418d04363677413f6f4d8d08a0c023cb236907e7
https://github.com/Perl/perl5/commit/418d04363677413f6f4d8d08a0c023cb236907e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 7cfc73f2113504e972f8c886742404f7fd7f5150
https://github.com/Perl/perl5/commit/7cfc73f2113504e972f8c886742404f7fd7f5150
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: c7a957e18feef83436d69d4ac49a64b61f2a15f2
https://github.com/Perl/perl5/commit/c7a957e18feef83436d69d4ac49a64b61f2a15f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: fc251ccb8beaf1440ac125e929ab8e8363021633
https://github.com/Perl/perl5/commit/fc251ccb8beaf1440ac125e929ab8e8363021633
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 7b1e3652eba535a88c889e5e5e17ccb3c747c3c5
https://github.com/Perl/perl5/commit/7b1e3652eba535a88c889e5e5e17ccb3c747c3c5
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: b402827ac3d592aae07692d1b8547e72a1eae64b
https://github.com/Perl/perl5/commit/b402827ac3d592aae07692d1b8547e72a1eae64b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: cdbf5093ba97c862923bf1af2cd3ee3fe601d536
https://github.com/Perl/perl5/commit/cdbf5093ba97c862923bf1af2cd3ee3fe601d536
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 3c069729db1144757db00d7b60f93e05ba31727b
https://github.com/Perl/perl5/commit/3c069729db1144757db00d7b60f93e05ba31727b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 641097af9554867d548d9d00d61fbb5c8060f6c7
https://github.com/Perl/perl5/commit/641097af9554867d548d9d00d61fbb5c8060f6c7
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: f61d00a683adb473b031424fd98080f7e6a4de62
https://github.com/Perl/perl5/commit/f61d00a683adb473b031424fd98080f7e6a4de62
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 65952dcf0751e7e7bac0ad2fb724c2081005f270
https://github.com/Perl/perl5/commit/65952dcf0751e7e7bac0ad2fb724c2081005f270
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 017fa7efe7bca17162291bb7b12ebed602b9e9de
https://github.com/Perl/perl5/commit/017fa7efe7bca17162291bb7b12ebed602b9e9de
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 6f04a0284bddf4cc4b349c2213ea27a96f0e241b
https://github.com/Perl/perl5/commit/6f04a0284bddf4cc4b349c2213ea27a96f0e241b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: cde6f7e76031da6d4919181bb579abc212456b4d
https://github.com/Perl/perl5/commit/cde6f7e76031da6d4919181bb579abc212456b4d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: e5cda75c6d15923c1db4a30c5b5d2a1a5256378d
https://github.com/Perl/perl5/commit/e5cda75c6d15923c1db4a30c5b5d2a1a5256378d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: f08319d4959aebaa509c20cec3050176512ba44b
https://github.com/Perl/perl5/commit/f08319d4959aebaa509c20cec3050176512ba44b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: b1a8094cd80e6ff967f98b214594fc2cb551c51f
https://github.com/Perl/perl5/commit/b1a8094cd80e6ff967f98b214594fc2cb551c51f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: a86cf31837e252c77304282dc3189ea5d7c76750
https://github.com/Perl/perl5/commit/a86cf31837e252c77304282dc3189ea5d7c76750
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 6213af300c7e91da384b70289f836090c7771c6a
https://github.com/Perl/perl5/commit/6213af300c7e91da384b70289f836090c7771c6a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 9a0990ed60564063200587b39ecf18d9e685f0eb
https://github.com/Perl/perl5/commit/9a0990ed60564063200587b39ecf18d9e685f0eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: b432d4f62b3f302901da26a6e628a44c82a65eb8
https://github.com/Perl/perl5/commit/b432d4f62b3f302901da26a6e628a44c82a65eb8
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 6eca8d8481e6b3f21d7fb8f1a71467d877d8a7b4
https://github.com/Perl/perl5/commit/6eca8d8481e6b3f21d7fb8f1a71467d877d8a7b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: ac6112846c6ce96509e36215b50007114be622d0
https://github.com/Perl/perl5/commit/ac6112846c6ce96509e36215b50007114be622d0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 6da0ad117082ff547bb9a284ddbae3c8699a058b
https://github.com/Perl/perl5/commit/6da0ad117082ff547bb9a284ddbae3c8699a058b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: e5832041d58f403b62b29c40f765486696c7fb0d
https://github.com/Perl/perl5/commit/e5832041d58f403b62b29c40f765486696c7fb0d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 6b25cee59c8240f07f8dfb3febd44aa00d09508e
https://github.com/Perl/perl5/commit/6b25cee59c8240f07f8dfb3febd44aa00d09508e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 355945c71060d151a5bf3112c6036c4c48213d1e
https://github.com/Perl/perl5/commit/355945c71060d151a5bf3112c6036c4c48213d1e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: a8bd18c2e879c7729d0f38c83fc76db515036991
https://github.com/Perl/perl5/commit/a8bd18c2e879c7729d0f38c83fc76db515036991
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 4997ddb3155d7c276f28df7df3622c5b17c5d4d3
https://github.com/Perl/perl5/commit/4997ddb3155d7c276f28df7df3622c5b17c5d4d3
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: ad01607e8676c6ec3f94d56f73ee9b049e7bc2f3
https://github.com/Perl/perl5/commit/ad01607e8676c6ec3f94d56f73ee9b049e7bc2f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: b76e93989cf214030856d0bc198e68ccc2dfcaaf
https://github.com/Perl/perl5/commit/b76e93989cf214030856d0bc198e68ccc2dfcaaf
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: aa603cd7cd597365dbde513f3562817b6bf546c4
https://github.com/Perl/perl5/commit/aa603cd7cd597365dbde513f3562817b6bf546c4
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: 9bacc46fb588e31d59f069f1a208569791b226eb
https://github.com/Perl/perl5/commit/9bacc46fb588e31d59f069f1a208569791b226eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: f7a127b9bf91a860ee6168c80f8d2bbc9875368b
https://github.com/Perl/perl5/commit/f7a127b9bf91a860ee6168c80f8d2bbc9875368b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: 1fd7dcf68f6b80380ceba53529859a8cdeab55f4
https://github.com/Perl/perl5/commit/1fd7dcf68f6b80380ceba53529859a8cdeab55f4
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 5694bdf88b7adef7e58ddddec59c372b42d15be4
https://github.com/Perl/perl5/commit/5694bdf88b7adef7e58ddddec59c372b42d15be4
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: d366c628238bfdd67dcbf22ce6429900a24f0b09
https://github.com/Perl/perl5/commit/d366c628238bfdd67dcbf22ce6429900a24f0b09
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 1129dee8ac4c6faddd542105603c3b3d9b7312d5
https://github.com/Perl/perl5/commit/1129dee8ac4c6faddd542105603c3b3d9b7312d5
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: d75baaea241ec997425f23d3c1f2cb9170886c1e
https://github.com/Perl/perl5/commit/d75baaea241ec997425f23d3c1f2cb9170886c1e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 9ac0361fede9f649223f1561b5d672067013f3d6
https://github.com/Perl/perl5/commit/9ac0361fede9f649223f1561b5d672067013f3d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 355e42af329b9f86d304ea72e4de3e3d31f19c7d
https://github.com/Perl/perl5/commit/355e42af329b9f86d304ea72e4de3e3d31f19c7d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 53cbf874a6406d96811a713375bfe6128abf04ba
https://github.com/Perl/perl5/commit/53cbf874a6406d96811a713375bfe6128abf04ba
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 828ca7161cbe585932d9f807336ca5021927349d
https://github.com/Perl/perl5/commit/828ca7161cbe585932d9f807336ca5021927349d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 02331938d89bd8e1bdeeab5f066f9860a4f23f28
https://github.com/Perl/perl5/commit/02331938d89bd8e1bdeeab5f066f9860a4f23f28
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 37a7eb1509257fca2f40d72871c42de2243be103
https://github.com/Perl/perl5/commit/37a7eb1509257fca2f40d72871c42de2243be103
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 795fa53acde2e85faa52bdc58766686997e4a95f
https://github.com/Perl/perl5/commit/795fa53acde2e85faa52bdc58766686997e4a95f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: e62ac3491a8f19ddba8451f1be6a75f131d82afb
https://github.com/Perl/perl5/commit/e62ac3491a8f19ddba8451f1be6a75f131d82afb
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 7e4e3e99fd2243a7105706a4d8cc4f958d09e94e
https://github.com/Perl/perl5/commit/7e4e3e99fd2243a7105706a4d8cc4f958d09e94e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 91a65974099ed63010f640ccefcd3801271ec3dc
https://github.com/Perl/perl5/commit/91a65974099ed63010f640ccefcd3801271ec3dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 0ada83eaae22f42a24484e4def2b948d8aeaac7f
https://github.com/Perl/perl5/commit/0ada83eaae22f42a24484e4def2b948d8aeaac7f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: ec91ed409e52f5ee1c7b55f53bb14c1cf806a45b
https://github.com/Perl/perl5/commit/ec91ed409e52f5ee1c7b55f53bb14c1cf806a45b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 02919a35024da1245382a83a7a2cb3a093a08d92
https://github.com/Perl/perl5/commit/02919a35024da1245382a83a7a2cb3a093a08d92
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: c5a972267f677cbf194cfc8040a4553e0344d649
https://github.com/Perl/perl5/commit/c5a972267f677cbf194cfc8040a4553e0344d649
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: e4467742a8939233dfb361791539ef70dcb53137
https://github.com/Perl/perl5/commit/e4467742a8939233dfb361791539ef70dcb53137
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 5b7ee7bc5547c588f4144607a5eebc1fb419e06c
https://github.com/Perl/perl5/commit/5b7ee7bc5547c588f4144607a5eebc1fb419e06c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 992866eebc085395d658305d7ec7d34c2eef8991
https://github.com/Perl/perl5/commit/992866eebc085395d658305d7ec7d34c2eef8991
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: d7db81e6b1b5acf589c3b4c6f3c44324beb4bf7c
https://github.com/Perl/perl5/commit/d7db81e6b1b5acf589c3b4c6f3c44324beb4bf7c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: c0cd559ce427d19676157d356fb54ab3668ddc1c
https://github.com/Perl/perl5/commit/c0cd559ce427d19676157d356fb54ab3668ddc1c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 54aebddbd08d2c92a8c2d3f9b50f0c79fc9da8cc
https://github.com/Perl/perl5/commit/54aebddbd08d2c92a8c2d3f9b50f0c79fc9da8cc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 78d67b2ba66e15b5a418507c891bec49806eb6b8
https://github.com/Perl/perl5/commit/78d67b2ba66e15b5a418507c891bec49806eb6b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 29a2bfeb3545619ec726a1278c44f064c9a9e393
https://github.com/Perl/perl5/commit/29a2bfeb3545619ec726a1278c44f064c9a9e393
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: fe09acb7bca5e1dc52568fafb7640135f14a94df
https://github.com/Perl/perl5/commit/fe09acb7bca5e1dc52568fafb7640135f14a94df
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: dd4cfb53e7ec7edb2654cace08789b65380b6426
https://github.com/Perl/perl5/commit/dd4cfb53e7ec7edb2654cace08789b65380b6426
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 3d8396eacce63e26284db6b62069dbff69d6c328
https://github.com/Perl/perl5/commit/3d8396eacce63e26284db6b62069dbff69d6c328
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: e5c52aa6389fd10196b1cc3aeb363ada11613674
https://github.com/Perl/perl5/commit/e5c52aa6389fd10196b1cc3aeb363ada11613674
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 8fa171b6e90882be74d43517070feac511a337f0
https://github.com/Perl/perl5/commit/8fa171b6e90882be74d43517070feac511a337f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 1e4ff88f1bdcb3cef9a778ff82b41d32204f9386
https://github.com/Perl/perl5/commit/1e4ff88f1bdcb3cef9a778ff82b41d32204f9386
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 87c12d81f47cb6f2502e66e676e07fbca9705cf7
https://github.com/Perl/perl5/commit/87c12d81f47cb6f2502e66e676e07fbca9705cf7
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 9fecdc3c0a8af448456bfe4ed8c82fd356525f4e
https://github.com/Perl/perl5/commit/9fecdc3c0a8af448456bfe4ed8c82fd356525f4e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: dc39cbeb572a4608b59e8b3e41eedc5c9facc89b
https://github.com/Perl/perl5/commit/dc39cbeb572a4608b59e8b3e41eedc5c9facc89b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: b3d443ba98da9823ed54099711865d1f1397141f
https://github.com/Perl/perl5/commit/b3d443ba98da9823ed54099711865d1f1397141f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 6e263c928d49a74e54a659eefaa9b5853a020fdb
https://github.com/Perl/perl5/commit/6e263c928d49a74e54a659eefaa9b5853a020fdb
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: d49bba7d93b1e0a01c08628dc572b211a7d17a10
https://github.com/Perl/perl5/commit/d49bba7d93b1e0a01c08628dc572b211a7d17a10
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 693b0a628ecfd1d9412104691784b36cd0c4464c
https://github.com/Perl/perl5/commit/693b0a628ecfd1d9412104691784b36cd0c4464c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 3f053046f5e043d75024c3aca3f66323b5970c09
https://github.com/Perl/perl5/commit/3f053046f5e043d75024c3aca3f66323b5970c09
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: e73d6620bb2fa5836f1563fc3b86c5c2311e550c
https://github.com/Perl/perl5/commit/e73d6620bb2fa5836f1563fc3b86c5c2311e550c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 25dfe75db243c0de2edb267dc4092f230d69e04f
https://github.com/Perl/perl5/commit/25dfe75db243c0de2edb267dc4092f230d69e04f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: 6530dca7f8bb955e32b0aaa357f95a6870f23bea
https://github.com/Perl/perl5/commit/6530dca7f8bb955e32b0aaa357f95a6870f23bea
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 0fa76ceb6aeeb5d71a253311ada86bd983197d86
https://github.com/Perl/perl5/commit/0fa76ceb6aeeb5d71a253311ada86bd983197d86
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 1fc97d3f4bf12dcc79175e0852a024b7ce65111f
https://github.com/Perl/perl5/commit/1fc97d3f4bf12dcc79175e0852a024b7ce65111f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 15eb1d91372c5f70089286c043afb533ecefce79
https://github.com/Perl/perl5/commit/15eb1d91372c5f70089286c043afb533ecefce79
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: b8a3d3bb8828f6872d3ef1d6ffb3ddb499af10aa
https://github.com/Perl/perl5/commit/b8a3d3bb8828f6872d3ef1d6ffb3ddb499af10aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 2512aeb4fc742e732850d4c9b5ba2430bb785ca5
https://github.com/Perl/perl5/commit/2512aeb4fc742e732850d4c9b5ba2430bb785ca5
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: d0e13ab5c899a2d720b1070819495262456f92f0
https://github.com/Perl/perl5/commit/d0e13ab5c899a2d720b1070819495262456f92f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: be2120f3c0610de973d140facb17cac41319137a
https://github.com/Perl/perl5/commit/be2120f3c0610de973d140facb17cac41319137a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: b240444ebcfe9f2a922bc78544bf353f03c9a167
https://github.com/Perl/perl5/commit/b240444ebcfe9f2a922bc78544bf353f03c9a167
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 8489291cae74d4d1e955b8d40a46373fbbc2c325
https://github.com/Perl/perl5/commit/8489291cae74d4d1e955b8d40a46373fbbc2c325
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: d4d1961bd1eaed9fb48d6959cd902785d70cc4ea
https://github.com/Perl/perl5/commit/d4d1961bd1eaed9fb48d6959cd902785d70cc4ea
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: a121d229720b3b211f07744b7768789919c5e400
https://github.com/Perl/perl5/commit/a121d229720b3b211f07744b7768789919c5e400
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: 69ead906f394996d50cd8c82e286fd8fc26a102d
https://github.com/Perl/perl5/commit/69ead906f394996d50cd8c82e286fd8fc26a102d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 08d93ccd5dad28f2c4ec34e464aaed53600ad8fc
https://github.com/Perl/perl5/commit/08d93ccd5dad28f2c4ec34e464aaed53600ad8fc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: 0a11a0c4707d559a6efb982245329fb907b9d958
https://github.com/Perl/perl5/commit/0a11a0c4707d559a6efb982245329fb907b9d958
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 8e434c24bc1ad6e7b1f574e07babd87893cedda7
https://github.com/Perl/perl5/commit/8e434c24bc1ad6e7b1f574e07babd87893cedda7
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 4d97afd335a69201e6b153488ccd4b25242da607
https://github.com/Perl/perl5/commit/4d97afd335a69201e6b153488ccd4b25242da607
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 5bc8bbcb46513097068b97ae4f0e561092628457
https://github.com/Perl/perl5/commit/5bc8bbcb46513097068b97ae4f0e561092628457
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: d503dc5c2316a6515b15be191cbe8be8b5689b4b
https://github.com/Perl/perl5/commit/d503dc5c2316a6515b15be191cbe8be8b5689b4b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: fbd7ebc2e8af7ea869fa8157c51c2271ce7817cd
https://github.com/Perl/perl5/commit/fbd7ebc2e8af7ea869fa8157c51c2271ce7817cd
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 01a063b9725e94f214d8320d069bacd904def075
https://github.com/Perl/perl5/commit/01a063b9725e94f214d8320d069bacd904def075
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: d8992595da5121ad5a62b8f61f287d9a7b8da817
https://github.com/Perl/perl5/commit/d8992595da5121ad5a62b8f61f287d9a7b8da817
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 8b9a100e268326424579dbf083067f8b7de30927
https://github.com/Perl/perl5/commit/8b9a100e268326424579dbf083067f8b7de30927
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: d7e4c9a66d5c2dffa3bf7bf21eab261ee6f23074
https://github.com/Perl/perl5/commit/d7e4c9a66d5c2dffa3bf7bf21eab261ee6f23074
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 2a3fd5a500b35f5fc5902bea58dbdf04f5203b89
https://github.com/Perl/perl5/commit/2a3fd5a500b35f5fc5902bea58dbdf04f5203b89
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 674e1a4118aa1c3ac7d0e5a0f89539837d87d1b6
https://github.com/Perl/perl5/commit/674e1a4118aa1c3ac7d0e5a0f89539837d87d1b6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 527762bc2bae4f6303c1eb792c470e4bbe9b6682
https://github.com/Perl/perl5/commit/527762bc2bae4f6303c1eb792c470e4bbe9b6682
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 5967d00e9e13030afdaa832136e1e2b2b544e41b
https://github.com/Perl/perl5/commit/5967d00e9e13030afdaa832136e1e2b2b544e41b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 64ce4f507cbb29976a81db6d0275c4e14808dcc9
https://github.com/Perl/perl5/commit/64ce4f507cbb29976a81db6d0275c4e14808dcc9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 2809d14536b64a04f81469ee034f1e86f6d4a725
https://github.com/Perl/perl5/commit/2809d14536b64a04f81469ee034f1e86f6d4a725
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: c68fab4e5cdba34f84e9d3e7d8250738bcc657ec
https://github.com/Perl/perl5/commit/c68fab4e5cdba34f84e9d3e7d8250738bcc657ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 4b64b07e19427ae5a4c171b302d09c539b67f731
https://github.com/Perl/perl5/commit/4b64b07e19427ae5a4c171b302d09c539b67f731
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 223ce753e31b1acc57af005e1251477a59824bbc
https://github.com/Perl/perl5/commit/223ce753e31b1acc57af005e1251477a59824bbc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 45a7f9fc6133e2557778223c5c810cb1a3dd6a48
https://github.com/Perl/perl5/commit/45a7f9fc6133e2557778223c5c810cb1a3dd6a48
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 06e39b05d25e7ec2f3b319381c27c7b377c3a856
https://github.com/Perl/perl5/commit/06e39b05d25e7ec2f3b319381c27c7b377c3a856
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: ed1cd70d119a96af79de68712adb602b78f4ef75
https://github.com/Perl/perl5/commit/ed1cd70d119a96af79de68712adb602b78f4ef75
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: dc647f2da5b3c3d7fac6fde3a8bb694753d1f859
https://github.com/Perl/perl5/commit/dc647f2da5b3c3d7fac6fde3a8bb694753d1f859
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: adc20ac224241fe41986f887516961e928ff3f4a
https://github.com/Perl/perl5/commit/adc20ac224241fe41986f887516961e928ff3f4a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 9a602ffd8f666b4b61697d59e0589f62a5c742fa
https://github.com/Perl/perl5/commit/9a602ffd8f666b4b61697d59e0589f62a5c742fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 419d6b913665b8aa98959d0959cdf54737256c65
https://github.com/Perl/perl5/commit/419d6b913665b8aa98959d0959cdf54737256c65
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 7e1f365a85b995b9f000982d623c45319b490e23
https://github.com/Perl/perl5/commit/7e1f365a85b995b9f000982d623c45319b490e23
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: d9fe470c05519464d2d543572fb4d378bd3d238b
https://github.com/Perl/perl5/commit/d9fe470c05519464d2d543572fb4d378bd3d238b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 477e7f4aeb7235a0977cdda23fd12bce43f80fc5
https://github.com/Perl/perl5/commit/477e7f4aeb7235a0977cdda23fd12bce43f80fc5
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: aabd23a485736ecd486b457af3f7226defc900df
https://github.com/Perl/perl5/commit/aabd23a485736ecd486b457af3f7226defc900df
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: a3ecbe87c89a3b145e10cd46c8ef8656626eb46d
https://github.com/Perl/perl5/commit/a3ecbe87c89a3b145e10cd46c8ef8656626eb46d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: ad00a988a2c5444eb22b50e52ad4076b3ca53644
https://github.com/Perl/perl5/commit/ad00a988a2c5444eb22b50e52ad4076b3ca53644
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 1d73790edc1d7ebbf85a0d7572e8cd601a473c00
https://github.com/Perl/perl5/commit/1d73790edc1d7ebbf85a0d7572e8cd601a473c00
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 112e1d80eb58c086abd2ca1892e14668c3efd8aa
https://github.com/Perl/perl5/commit/112e1d80eb58c086abd2ca1892e14668c3efd8aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: e5c86ae2b572a3a323d945c18a47177f8f4b16ef
https://github.com/Perl/perl5/commit/e5c86ae2b572a3a323d945c18a47177f8f4b16ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 94eec3d158b7b11534750a2e7932c6c582c46ba9
https://github.com/Perl/perl5/commit/94eec3d158b7b11534750a2e7932c6c582c46ba9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 19a823955e382e6b19f458ff4d572e78fd9731bd
https://github.com/Perl/perl5/commit/19a823955e382e6b19f458ff4d572e78fd9731bd
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 631edbe5eae59d8cb8a06cb1a0af055c7dea4d9b
https://github.com/Perl/perl5/commit/631edbe5eae59d8cb8a06cb1a0af055c7dea4d9b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 68c97dea60f197315a48d77b0039715e9fe8755d
https://github.com/Perl/perl5/commit/68c97dea60f197315a48d77b0039715e9fe8755d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: a8a9cf0d5bc9b2e077db1ac9f3b7b6baa75262b5
https://github.com/Perl/perl5/commit/a8a9cf0d5bc9b2e077db1ac9f3b7b6baa75262b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 9965626e5cf6e22dfaa726a5612c50f5b1f61c63
https://github.com/Perl/perl5/commit/9965626e5cf6e22dfaa726a5612c50f5b1f61c63
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 6218eb3c5b0de1f4b71ed4775b5aed996d335b97
https://github.com/Perl/perl5/commit/6218eb3c5b0de1f4b71ed4775b5aed996d335b97
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 2f9857eee1e38afc92ffbbaa454d3586c9a83d99
https://github.com/Perl/perl5/commit/2f9857eee1e38afc92ffbbaa454d3586c9a83d99
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: c7bf7ae2dbef005e9f91ebabfe61bd10aa3d89fe
https://github.com/Perl/perl5/commit/c7bf7ae2dbef005e9f91ebabfe61bd10aa3d89fe
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: a54ecb094e19ca9782ae4dd11f89a572729f1d87
https://github.com/Perl/perl5/commit/a54ecb094e19ca9782ae4dd11f89a572729f1d87
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 613080542554bb8d90ac6347db3483c76d8e30c2
https://github.com/Perl/perl5/commit/613080542554bb8d90ac6347db3483c76d8e30c2
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 71d2f7cba9b780e1cbe8a59f4bdef9ec662c41c2
https://github.com/Perl/perl5/commit/71d2f7cba9b780e1cbe8a59f4bdef9ec662c41c2
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 783866bb878798fc9372f2afdc69b120bf0dc108
https://github.com/Perl/perl5/commit/783866bb878798fc9372f2afdc69b120bf0dc108
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: da6ab6f581530b74d21264ef08a9a58ac7ee8ff0
https://github.com/Perl/perl5/commit/da6ab6f581530b74d21264ef08a9a58ac7ee8ff0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 25580807cdf05ca2315c8bc6ba2ffb3605e2163a
https://github.com/Perl/perl5/commit/25580807cdf05ca2315c8bc6ba2ffb3605e2163a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 784e60da823e33051d6d2481b8ceae9c2af06581
https://github.com/Perl/perl5/commit/784e60da823e33051d6d2481b8ceae9c2af06581
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: cb0df31385bf4d400122a58818930b86b714033a
https://github.com/Perl/perl5/commit/cb0df31385bf4d400122a58818930b86b714033a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 700e2ae580f19dceceff5c6a3810f2cf1c061f63
https://github.com/Perl/perl5/commit/700e2ae580f19dceceff5c6a3810f2cf1c061f63
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 5a3d2f2b3ca638dd948f32bb95827f90e5b70b37
https://github.com/Perl/perl5/commit/5a3d2f2b3ca638dd948f32bb95827f90e5b70b37
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: dd520b19f0c2105e6bb24b31790172292d5e5097
https://github.com/Perl/perl5/commit/dd520b19f0c2105e6bb24b31790172292d5e5097
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: b5b0d145fd1a0b103188c10b65e445054e9d2ee4
https://github.com/Perl/perl5/commit/b5b0d145fd1a0b103188c10b65e445054e9d2ee4
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: c7b530b170664d3cf868ef6a0443cb2ab1cbe2c8
https://github.com/Perl/perl5/commit/c7b530b170664d3cf868ef6a0443cb2ab1cbe2c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 9b99f75b56b21ce38c2931b3cfc51b38518be1e8
https://github.com/Perl/perl5/commit/9b99f75b56b21ce38c2931b3cfc51b38518be1e8
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 8035823456b0c1a39d99eccf1075af002ad17e0f
https://github.com/Perl/perl5/commit/8035823456b0c1a39d99eccf1075af002ad17e0f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: aaa44ffd5d9bf54aa42032e9fdae7711f10d0303
https://github.com/Perl/perl5/commit/aaa44ffd5d9bf54aa42032e9fdae7711f10d0303
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 51aec3258ffc0b76c52893ee72a87f1cb44311d4
https://github.com/Perl/perl5/commit/51aec3258ffc0b76c52893ee72a87f1cb44311d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 035ae2775f599620ab741de0e62984780eaf4d2b
https://github.com/Perl/perl5/commit/035ae2775f599620ab741de0e62984780eaf4d2b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: c1296d7900b702fce1a9dc5fdbe1690902c3d102
https://github.com/Perl/perl5/commit/c1296d7900b702fce1a9dc5fdbe1690902c3d102
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: af7e8689abf2fade8f64223f76457c29635a85d1
https://github.com/Perl/perl5/commit/af7e8689abf2fade8f64223f76457c29635a85d1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 42c3a2b02314233d3fc86b14395af0f7348ee628
https://github.com/Perl/perl5/commit/42c3a2b02314233d3fc86b14395af0f7348ee628
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: e94a6a04f5c3f8db596f97b44c94ea499cf71d49
https://github.com/Perl/perl5/commit/e94a6a04f5c3f8db596f97b44c94ea499cf71d49
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: 1ec087b80c050c52e2891064c746b74948fd1609
https://github.com/Perl/perl5/commit/1ec087b80c050c52e2891064c746b74948fd1609
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 76b0d96beccaa24e5737b3f353b24181fb0bd0ae
https://github.com/Perl/perl5/commit/76b0d96beccaa24e5737b3f353b24181fb0bd0ae
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 3a0096ffb02e6103124a47e755314b37462b8519
https://github.com/Perl/perl5/commit/3a0096ffb02e6103124a47e755314b37462b8519
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: cc79b16e2d79dff4aea2fb7c34ba1f7144f5e7c6
https://github.com/Perl/perl5/commit/cc79b16e2d79dff4aea2fb7c34ba1f7144f5e7c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: 07a7780182b0f7e8a97bc7f5399837777f26f85f
https://github.com/Perl/perl5/commit/07a7780182b0f7e8a97bc7f5399837777f26f85f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: c9802665d5344d09dced0c051ddf8df727a63811
https://github.com/Perl/perl5/commit/c9802665d5344d09dced0c051ddf8df727a63811
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 7da21c5c6313ef52ef9062318a0c8e8a290808cb
https://github.com/Perl/perl5/commit/7da21c5c6313ef52ef9062318a0c8e8a290808cb
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: c32eda2b5cb3a606d3a653695d1172fedc2e883e
https://github.com/Perl/perl5/commit/c32eda2b5cb3a606d3a653695d1172fedc2e883e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: c70f1f83fea1b9ffa752acc290b051ff1a56ba28
https://github.com/Perl/perl5/commit/c70f1f83fea1b9ffa752acc290b051ff1a56ba28
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: b03b053a831261fab84e57dd3e1fa66e02fd6cf7
https://github.com/Perl/perl5/commit/b03b053a831261fab84e57dd3e1fa66e02fd6cf7
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: d3ca59c2ad8eead93c55f9e898712e6f949ce61d
https://github.com/Perl/perl5/commit/d3ca59c2ad8eead93c55f9e898712e6f949ce61d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: b0db81ed192ca28ef8e70c4df1c17867ee97c1ef
https://github.com/Perl/perl5/commit/b0db81ed192ca28ef8e70c4df1c17867ee97c1ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: f5fb2e86a491780dab2e61b4d9e920dba770159c
https://github.com/Perl/perl5/commit/f5fb2e86a491780dab2e61b4d9e920dba770159c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: fdc661510d5ea92d8eb790a0f9eea73eb022b594
https://github.com/Perl/perl5/commit/fdc661510d5ea92d8eb790a0f9eea73eb022b594
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 1a08d3103a867f31d78398b5e2982e0566175d35
https://github.com/Perl/perl5/commit/1a08d3103a867f31d78398b5e2982e0566175d35
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: f3e33f29eac7076e41188b536501ba91da314076
https://github.com/Perl/perl5/commit/f3e33f29eac7076e41188b536501ba91da314076
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 967a454bd54522d168a723ec3bf2694f5f148954
https://github.com/Perl/perl5/commit/967a454bd54522d168a723ec3bf2694f5f148954
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 33729b4ccc7490696dc8c3092ec0200558dca423
https://github.com/Perl/perl5/commit/33729b4ccc7490696dc8c3092ec0200558dca423
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 4800c9525caa941e97696f54d70b66a003675039
https://github.com/Perl/perl5/commit/4800c9525caa941e97696f54d70b66a003675039
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: c342fcf8207630456570dd279733ab21c8d2aa67
https://github.com/Perl/perl5/commit/c342fcf8207630456570dd279733ab21c8d2aa67
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: d12cbd38d850456a50def41c2798f2def20aed1a
https://github.com/Perl/perl5/commit/d12cbd38d850456a50def41c2798f2def20aed1a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 8b9e0ea6f2bb6acd8af45c670e13ebd17f885aa6
https://github.com/Perl/perl5/commit/8b9e0ea6f2bb6acd8af45c670e13ebd17f885aa6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 03287d0e04fd9436b694717ba00d85b76a3f6f82
https://github.com/Perl/perl5/commit/03287d0e04fd9436b694717ba00d85b76a3f6f82
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 5b04d01b1585d9acfc597adb2f7c19979adf2427
https://github.com/Perl/perl5/commit/5b04d01b1585d9acfc597adb2f7c19979adf2427
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 89f250938d0c0e5e3bac8a390f11d64b9fff7500
https://github.com/Perl/perl5/commit/89f250938d0c0e5e3bac8a390f11d64b9fff7500
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: a5d6bbb9e62517abe3f95c63f99a7a547b836783
https://github.com/Perl/perl5/commit/a5d6bbb9e62517abe3f95c63f99a7a547b836783
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: cd4c74a0f16fd231eb7d011bbc26f95c26a2004c
https://github.com/Perl/perl5/commit/cd4c74a0f16fd231eb7d011bbc26f95c26a2004c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: dedcdd70ec7034896f4b4fc7ba45641629f8f089
https://github.com/Perl/perl5/commit/dedcdd70ec7034896f4b4fc7ba45641629f8f089
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: c5694834d66f25d2c53d7ac3300242174cf8b3b7
https://github.com/Perl/perl5/commit/c5694834d66f25d2c53d7ac3300242174cf8b3b7
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: a988858626a1402f2ecaaec96adbef8785ef70a9
https://github.com/Perl/perl5/commit/a988858626a1402f2ecaaec96adbef8785ef70a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Fix up a comment
Commit: d72d3e1e0a52c4f503df677f0b1e410a4e1218b4
https://github.com/Perl/perl5/commit/d72d3e1e0a52c4f503df677f0b1e410a4e1218b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M embed.fnc
M embed.h
M embedvar.h
M ext/XS-APItest/t/locale.t
M handy.h
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M makedef.pl
M perl.c
M perl.h
M pod/perldiag.pod
M proto.h
M sv.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
26
Compare: https://github.com/Perl/perl5/compare/f201d83b9267...d72d3e1e0a52
