Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: fcd11417cfa5cd842d73595dd0695bbffa8df08a
https://github.com/Perl/perl5/commit/fcd11417cfa5cd842d73595dd0695bbffa8df08a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 89dca447af1d1e9cb412f07bf232508c6573eada
https://github.com/Perl/perl5/commit/89dca447af1d1e9cb412f07bf232508c6573eada
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 2de434a110335eb9d420ad87e0ab2f4e0967db37
https://github.com/Perl/perl5/commit/2de434a110335eb9d420ad87e0ab2f4e0967db37
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 64dba89a2b8984b146505b94a39f4f2da09b4b66
https://github.com/Perl/perl5/commit/64dba89a2b8984b146505b94a39f4f2da09b4b66
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 5c397328e3bd4a28058ad6b814d16cf7298046b6
https://github.com/Perl/perl5/commit/5c397328e3bd4a28058ad6b814d16cf7298046b6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 63c1ecb73ec22b0827c0cb9ba3c3f532a84b4a9c
https://github.com/Perl/perl5/commit/63c1ecb73ec22b0827c0cb9ba3c3f532a84b4a9c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 474e5216f55205ace7586fb4363f974d4e520907
https://github.com/Perl/perl5/commit/474e5216f55205ace7586fb4363f974d4e520907
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 6a7dfa479746628e1c300d6d08f97103159f456e
https://github.com/Perl/perl5/commit/6a7dfa479746628e1c300d6d08f97103159f456e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 58a9dc82c123dad8d0b052891fda02e6e8cdef39
https://github.com/Perl/perl5/commit/58a9dc82c123dad8d0b052891fda02e6e8cdef39
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: cc4857bdc3bc95d2ddf8a4e3778aab96a006f9b1
https://github.com/Perl/perl5/commit/cc4857bdc3bc95d2ddf8a4e3778aab96a006f9b1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 2a8fe80fa51994a25b375290f5bf1cda9ca104be
https://github.com/Perl/perl5/commit/2a8fe80fa51994a25b375290f5bf1cda9ca104be
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: c8c95926798ca2020a6af381a92bb18d03ba9350
https://github.com/Perl/perl5/commit/c8c95926798ca2020a6af381a92bb18d03ba9350
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: c2d6cc50a15cd33c67ce0baf3d2b5c2ba44d6eec
https://github.com/Perl/perl5/commit/c2d6cc50a15cd33c67ce0baf3d2b5c2ba44d6eec
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: c1b45cf49c0318beb9ca71bc40edbdd83198a047
https://github.com/Perl/perl5/commit/c1b45cf49c0318beb9ca71bc40edbdd83198a047
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 018f1acf08d871e52f3b26180c585b19a9f15dee
https://github.com/Perl/perl5/commit/018f1acf08d871e52f3b26180c585b19a9f15dee
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: b5cbd56bd3d30f6c787b4872dbcaa50a8b14a414
https://github.com/Perl/perl5/commit/b5cbd56bd3d30f6c787b4872dbcaa50a8b14a414
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: bdf77e6fc4f25079b2d1e506fe7d9778268308a1
https://github.com/Perl/perl5/commit/bdf77e6fc4f25079b2d1e506fe7d9778268308a1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 532d799b08517a3cbbb0cf79db94d1663e7abb8d
https://github.com/Perl/perl5/commit/532d799b08517a3cbbb0cf79db94d1663e7abb8d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 41dc6644e302365cd9564ca9ea880ee03664b0e6
https://github.com/Perl/perl5/commit/41dc6644e302365cd9564ca9ea880ee03664b0e6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: cb86f083e3aeda6905bd1b0895efca1af17e5fce
https://github.com/Perl/perl5/commit/cb86f083e3aeda6905bd1b0895efca1af17e5fce
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 7852b1b6550386f58c10e22f2e3aff7d2fbcf9c1
https://github.com/Perl/perl5/commit/7852b1b6550386f58c10e22f2e3aff7d2fbcf9c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 5587c6ea0389c9325c967bb873fa46d4afecec97
https://github.com/Perl/perl5/commit/5587c6ea0389c9325c967bb873fa46d4afecec97
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 347428db3ee67c5687cd2f62e7eca91c7bf726d6
https://github.com/Perl/perl5/commit/347428db3ee67c5687cd2f62e7eca91c7bf726d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 12d9ded49ff6671995060339366c3acea3ffe03c
https://github.com/Perl/perl5/commit/12d9ded49ff6671995060339366c3acea3ffe03c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 521476b3178bf7fd0c841029bd39a2783c4e13d9
https://github.com/Perl/perl5/commit/521476b3178bf7fd0c841029bd39a2783c4e13d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 916d7a3ab98b18c3ee2606aa0c8287ce4ce7bd7a
https://github.com/Perl/perl5/commit/916d7a3ab98b18c3ee2606aa0c8287ce4ce7bd7a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 71d93b2465f130d379c7d0a4ee9f2522f44da1d4
https://github.com/Perl/perl5/commit/71d93b2465f130d379c7d0a4ee9f2522f44da1d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 82ddfb04d5aa417227a86c645c4d4e8c4a0fd398
https://github.com/Perl/perl5/commit/82ddfb04d5aa417227a86c645c4d4e8c4a0fd398
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 5c90a7e174cdfd5f6a9b36552a5bc57fb62e4add
https://github.com/Perl/perl5/commit/5c90a7e174cdfd5f6a9b36552a5bc57fb62e4add
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 8c7ae2cf36018601dd53a20a9927bf8686bdc3c8
https://github.com/Perl/perl5/commit/8c7ae2cf36018601dd53a20a9927bf8686bdc3c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 46794438cf6c21832e92f6a5c2474cbe2c8cd9ff
https://github.com/Perl/perl5/commit/46794438cf6c21832e92f6a5c2474cbe2c8cd9ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 5b2895564b78dfe857ae9b51a787064c5c832600
https://github.com/Perl/perl5/commit/5b2895564b78dfe857ae9b51a787064c5c832600
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: becbcb0e208c965c5c24fab3fc33373d156a701f
https://github.com/Perl/perl5/commit/becbcb0e208c965c5c24fab3fc33373d156a701f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 6bf59ad12d35be6fba3cb0c4cbfa83a9516a8db0
https://github.com/Perl/perl5/commit/6bf59ad12d35be6fba3cb0c4cbfa83a9516a8db0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: c0f25da769377e0700e53af97c6a8d99dc4dbecf
https://github.com/Perl/perl5/commit/c0f25da769377e0700e53af97c6a8d99dc4dbecf
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 9438e7c6b2eed14c3e307e8a18864409a02d6c52
https://github.com/Perl/perl5/commit/9438e7c6b2eed14c3e307e8a18864409a02d6c52
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 41f45d7384536be8f7cd132550adb3003ec38d10
https://github.com/Perl/perl5/commit/41f45d7384536be8f7cd132550adb3003ec38d10
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: d74241d0efd50ecf30a4f921c32fb296ea1fc4ef
https://github.com/Perl/perl5/commit/d74241d0efd50ecf30a4f921c32fb296ea1fc4ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: db7e1f16d9fa4ade61ec35aac6cfed94ef89094a
https://github.com/Perl/perl5/commit/db7e1f16d9fa4ade61ec35aac6cfed94ef89094a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: fdce26def412a78224287bde0cdc1b9e99fd6943
https://github.com/Perl/perl5/commit/fdce26def412a78224287bde0cdc1b9e99fd6943
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: f72e0889a5b208afd74139fb6bc3213cce9c7cb6
https://github.com/Perl/perl5/commit/f72e0889a5b208afd74139fb6bc3213cce9c7cb6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 7b46f84f7150ad7495571b5a429df134220487f3
https://github.com/Perl/perl5/commit/7b46f84f7150ad7495571b5a429df134220487f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 42015f2860dc8e0ade8cf0a865e90c78228550c6
https://github.com/Perl/perl5/commit/42015f2860dc8e0ade8cf0a865e90c78228550c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: b450da4b6838fea51ba19570a5c604f009847cb9
https://github.com/Perl/perl5/commit/b450da4b6838fea51ba19570a5c604f009847cb9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: c6b2681a7ac5ee03fbac0fc7bdc2126c4bcc5052
https://github.com/Perl/perl5/commit/c6b2681a7ac5ee03fbac0fc7bdc2126c4bcc5052
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: ec5a3e9182f881551480ccde558dca857f678bbc
https://github.com/Perl/perl5/commit/ec5a3e9182f881551480ccde558dca857f678bbc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: ed656d43282026d246717ce51bc8b18be955547a
https://github.com/Perl/perl5/commit/ed656d43282026d246717ce51bc8b18be955547a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: cbc7f8b7de190ca69e29ea928ed16ee4308f59fa
https://github.com/Perl/perl5/commit/cbc7f8b7de190ca69e29ea928ed16ee4308f59fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 04061a03b7576f3fd19c4f9a52f99ea7d7fbc272
https://github.com/Perl/perl5/commit/04061a03b7576f3fd19c4f9a52f99ea7d7fbc272
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 622cec1e8955611805df7f80311606670a4f2529
https://github.com/Perl/perl5/commit/622cec1e8955611805df7f80311606670a4f2529
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 98eae43c7fbb54372708910e29375597f37a897e
https://github.com/Perl/perl5/commit/98eae43c7fbb54372708910e29375597f37a897e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 8b8454959985ae7ee9962997e4c888936220f4d4
https://github.com/Perl/perl5/commit/8b8454959985ae7ee9962997e4c888936220f4d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 8cb3e4d29835d3f225864b98d076ec2c8c42e8e9
https://github.com/Perl/perl5/commit/8cb3e4d29835d3f225864b98d076ec2c8c42e8e9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 52a559cb84b0c7386d11c36a45f57d83e7085137
https://github.com/Perl/perl5/commit/52a559cb84b0c7386d11c36a45f57d83e7085137
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: e090e44cf7e437f768744c2a8670432df3707f34
https://github.com/Perl/perl5/commit/e090e44cf7e437f768744c2a8670432df3707f34
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: eb53fd864f322bb501679c60fe0ef5eca77c1c00
https://github.com/Perl/perl5/commit/eb53fd864f322bb501679c60fe0ef5eca77c1c00
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 5808b3eec7809e06157b5ea313d4d6b6968015d6
https://github.com/Perl/perl5/commit/5808b3eec7809e06157b5ea313d4d6b6968015d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 731701144e6c9ff67fecfecfe9cd0afb200cd7e1
https://github.com/Perl/perl5/commit/731701144e6c9ff67fecfecfe9cd0afb200cd7e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
f
Commit: 43328133d8322680ce464e5a066990f88e28dce0
https://github.com/Perl/perl5/commit/43328133d8322680ce464e5a066990f88e28dce0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: a41dd037e72acb152c4eedb6ccf36e919e5e9279
https://github.com/Perl/perl5/commit/a41dd037e72acb152c4eedb6ccf36e919e5e9279
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 0fe46f92e78f970ad29a49b329ca1a9426e978ec
https://github.com/Perl/perl5/commit/0fe46f92e78f970ad29a49b329ca1a9426e978ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 8339f38e96865ccc2f1ab30a149691d9f8b38c42
https://github.com/Perl/perl5/commit/8339f38e96865ccc2f1ab30a149691d9f8b38c42
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: ca770788e4b604aaedeab459fbe3b344f10bede8
https://github.com/Perl/perl5/commit/ca770788e4b604aaedeab459fbe3b344f10bede8
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 26bc50d39ff05b35ace186d73ff4ed0c4ba699bf
https://github.com/Perl/perl5/commit/26bc50d39ff05b35ace186d73ff4ed0c4ba699bf
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: cac993d577f38fd756ca8711b1259cd802a7712e
https://github.com/Perl/perl5/commit/cac993d577f38fd756ca8711b1259cd802a7712e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 37c63f86fe48e64c6ce392447b0658449d79472a
https://github.com/Perl/perl5/commit/37c63f86fe48e64c6ce392447b0658449d79472a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 2d6091746c13661e17c2feba7c0062c24248a743
https://github.com/Perl/perl5/commit/2d6091746c13661e17c2feba7c0062c24248a743
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: dcb018e41735cba65bd4fb4bf4e69ce0d51772b9
https://github.com/Perl/perl5/commit/dcb018e41735cba65bd4fb4bf4e69ce0d51772b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: d077e613edfcb0e1f62d523f8a5b6dc3634ab52e
https://github.com/Perl/perl5/commit/d077e613edfcb0e1f62d523f8a5b6dc3634ab52e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: b519f161fd63bdba6c2248066c086e02321440ac
https://github.com/Perl/perl5/commit/b519f161fd63bdba6c2248066c086e02321440ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: a913545732aed9b750d991247af8a2b9aec42a6d
https://github.com/Perl/perl5/commit/a913545732aed9b750d991247af8a2b9aec42a6d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: ac89108dcf4c49567ca04a67567a3a9f738512f3
https://github.com/Perl/perl5/commit/ac89108dcf4c49567ca04a67567a3a9f738512f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 9f45066f7d48a80b8855b92f61a8ae4dfb27c161
https://github.com/Perl/perl5/commit/9f45066f7d48a80b8855b92f61a8ae4dfb27c161
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: b72a96664116d724c2152c5cc54763dd9e03a21c
https://github.com/Perl/perl5/commit/b72a96664116d724c2152c5cc54763dd9e03a21c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 97bb5966f1da0641dbcfa0fe251b5c1708b01d09
https://github.com/Perl/perl5/commit/97bb5966f1da0641dbcfa0fe251b5c1708b01d09
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: b4fb92408b75a21ecf0188ee34444a4eb6704905
https://github.com/Perl/perl5/commit/b4fb92408b75a21ecf0188ee34444a4eb6704905
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 1b5ac058a037d431319a4bba9ed33e5d86782204
https://github.com/Perl/perl5/commit/1b5ac058a037d431319a4bba9ed33e5d86782204
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 216be4c9d5f7c3f2e808e784b77381d6ccde4957
https://github.com/Perl/perl5/commit/216be4c9d5f7c3f2e808e784b77381d6ccde4957
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: a55d25fff437d83ab6411c22871d388514631cbc
https://github.com/Perl/perl5/commit/a55d25fff437d83ab6411c22871d388514631cbc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 28e7ab08d9af3a90fe27f49c607e953c978599f5
https://github.com/Perl/perl5/commit/28e7ab08d9af3a90fe27f49c607e953c978599f5
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 41054c8742daf007b515ce8fef6b08d2053068c1
https://github.com/Perl/perl5/commit/41054c8742daf007b515ce8fef6b08d2053068c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 2d80f4020c18043f0df020fe73c796eca298fc51
https://github.com/Perl/perl5/commit/2d80f4020c18043f0df020fe73c796eca298fc51
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: b6d8ad5eda28d81735792f421439aedb791089fa
https://github.com/Perl/perl5/commit/b6d8ad5eda28d81735792f421439aedb791089fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 0914c2725ec95ee4f96f529ba9f3f625c6cfd394
https://github.com/Perl/perl5/commit/0914c2725ec95ee4f96f529ba9f3f625c6cfd394
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 5fd9837ab0984548be9c42763126e2e79ba1cfa6
https://github.com/Perl/perl5/commit/5fd9837ab0984548be9c42763126e2e79ba1cfa6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 69d81b8a7954ce81a619bb19f5a71c70e49064cb
https://github.com/Perl/perl5/commit/69d81b8a7954ce81a619bb19f5a71c70e49064cb
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: dc9e3e8e681b94ae4354babc7ac10dcee55f0afb
https://github.com/Perl/perl5/commit/dc9e3e8e681b94ae4354babc7ac10dcee55f0afb
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: f373ee29574008049c48eae0835b830321b7ad5d
https://github.com/Perl/perl5/commit/f373ee29574008049c48eae0835b830321b7ad5d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: e1027f5a21b83bce8f070b2ec26cbfa9dd9c405f
https://github.com/Perl/perl5/commit/e1027f5a21b83bce8f070b2ec26cbfa9dd9c405f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: cf071e9143f3dd13469901812874b71160d52ecd
https://github.com/Perl/perl5/commit/cf071e9143f3dd13469901812874b71160d52ecd
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 39991c8170ca45f107ca97b0501cc86fb95671a0
https://github.com/Perl/perl5/commit/39991c8170ca45f107ca97b0501cc86fb95671a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 9faabbeb395441d17cc81eee807f93fdf26a4c7e
https://github.com/Perl/perl5/commit/9faabbeb395441d17cc81eee807f93fdf26a4c7e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 7148f9237feb254ace8f80c30e96685a942e9b2b
https://github.com/Perl/perl5/commit/7148f9237feb254ace8f80c30e96685a942e9b2b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: ea8ab0e0ae186e4558e8c748e81217d6d53014c8
https://github.com/Perl/perl5/commit/ea8ab0e0ae186e4558e8c748e81217d6d53014c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: f5c9f6f695fdc20cdf4ca91a32149a9c22a0ae5d
https://github.com/Perl/perl5/commit/f5c9f6f695fdc20cdf4ca91a32149a9c22a0ae5d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: c08958a540e7c3851fa290f7f4e818bead65cca3
https://github.com/Perl/perl5/commit/c08958a540e7c3851fa290f7f4e818bead65cca3
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: f301c8ead46343e178c01cd6483fc8206346676c
https://github.com/Perl/perl5/commit/f301c8ead46343e178c01cd6483fc8206346676c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: da80b4f6abe4ac5dd8f87248cf6f90ae28ba16a9
https://github.com/Perl/perl5/commit/da80b4f6abe4ac5dd8f87248cf6f90ae28ba16a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 9ef3f57402a479de78bca357ca5d150cc66bdaf2
https://github.com/Perl/perl5/commit/9ef3f57402a479de78bca357ca5d150cc66bdaf2
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 284f96ce21c77d6929dd1a04495be40b4af6e8c3
https://github.com/Perl/perl5/commit/284f96ce21c77d6929dd1a04495be40b4af6e8c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 4fa0000fdd19a4e9c97109cef2aaf8c33401e442
https://github.com/Perl/perl5/commit/4fa0000fdd19a4e9c97109cef2aaf8c33401e442
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 23dc9fd218166bcd7b3f2f20b564005bb7ee45bd
https://github.com/Perl/perl5/commit/23dc9fd218166bcd7b3f2f20b564005bb7ee45bd
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: 708a32b7677cb0bc141cb0ccc91169aa3ce4d005
https://github.com/Perl/perl5/commit/708a32b7677cb0bc141cb0ccc91169aa3ce4d005
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 516d20a2b53968e94584be07983d5f899f09dc48
https://github.com/Perl/perl5/commit/516d20a2b53968e94584be07983d5f899f09dc48
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 83b43859e01260cd2b8d1eea0184306c76006dde
https://github.com/Perl/perl5/commit/83b43859e01260cd2b8d1eea0184306c76006dde
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 63613970fa7e6ba68fbb74615d785b05b031d1fa
https://github.com/Perl/perl5/commit/63613970fa7e6ba68fbb74615d785b05b031d1fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: a826f81079ece2737e72c7620f5481597a84f139
https://github.com/Perl/perl5/commit/a826f81079ece2737e72c7620f5481597a84f139
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: e8ada597fc59e79505a4876c81762fdb9186a778
https://github.com/Perl/perl5/commit/e8ada597fc59e79505a4876c81762fdb9186a778
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: a8f3b75b73b851022543ec3b713c4833603d4910
https://github.com/Perl/perl5/commit/a8f3b75b73b851022543ec3b713c4833603d4910
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 8c97ea61b5ed20760d81769ae82f240b4e4e3c53
https://github.com/Perl/perl5/commit/8c97ea61b5ed20760d81769ae82f240b4e4e3c53
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 4be31fb8fa45d19360419745a694f88205279e6b
https://github.com/Perl/perl5/commit/4be31fb8fa45d19360419745a694f88205279e6b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: a4d4a5e93704af5ccac9e7bab5dfa3637cd728d9
https://github.com/Perl/perl5/commit/a4d4a5e93704af5ccac9e7bab5dfa3637cd728d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: c8e12a1a55c32efa3e9d66f85667800f83b53aeb
https://github.com/Perl/perl5/commit/c8e12a1a55c32efa3e9d66f85667800f83b53aeb
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: f7798e76b483e738b58a19efdab38653d62ef5be
https://github.com/Perl/perl5/commit/f7798e76b483e738b58a19efdab38653d62ef5be
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: c498b5740aa2a6cae66fe87c5bb5cae67f520a4d
https://github.com/Perl/perl5/commit/c498b5740aa2a6cae66fe87c5bb5cae67f520a4d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: da1ce703e92c82a125aaef5f0c4ea185dc6e1e0d
https://github.com/Perl/perl5/commit/da1ce703e92c82a125aaef5f0c4ea185dc6e1e0d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: 4523cf4a386a4c05ab312f4fbbcb553b47b7c480
https://github.com/Perl/perl5/commit/4523cf4a386a4c05ab312f4fbbcb553b47b7c480
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 015473ae599d205b7dc686e2727c50e769c76453
https://github.com/Perl/perl5/commit/015473ae599d205b7dc686e2727c50e769c76453
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: b37f67ce18de8bb03ce68158d0592222d3309a78
https://github.com/Perl/perl5/commit/b37f67ce18de8bb03ce68158d0592222d3309a78
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 2050332ab4ee7ccd963e23d8dd9560be4c5f3da3
https://github.com/Perl/perl5/commit/2050332ab4ee7ccd963e23d8dd9560be4c5f3da3
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 243592af833d83edf985f73f4cfd2f98f4fb45a0
https://github.com/Perl/perl5/commit/243592af833d83edf985f73f4cfd2f98f4fb45a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: a1dff3aa1277cb5c4a376eb6f2932a901ade53a6
https://github.com/Perl/perl5/commit/a1dff3aa1277cb5c4a376eb6f2932a901ade53a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: bcbf77a5e18634e5d5463df1c53c495aacc3d70e
https://github.com/Perl/perl5/commit/bcbf77a5e18634e5d5463df1c53c495aacc3d70e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: a249603eba6d419174d29b4df22603edfa0e8c40
https://github.com/Perl/perl5/commit/a249603eba6d419174d29b4df22603edfa0e8c40
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 1ca0e4b0c89b0eba604585de1c1f2264127594b5
https://github.com/Perl/perl5/commit/1ca0e4b0c89b0eba604585de1c1f2264127594b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: dd9d481d7ee96e18755dea1ffa13fea42ef46c8f
https://github.com/Perl/perl5/commit/dd9d481d7ee96e18755dea1ffa13fea42ef46c8f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 27e800138a99b5aa2e7445c2e9b5d4615647144c
https://github.com/Perl/perl5/commit/27e800138a99b5aa2e7445c2e9b5d4615647144c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: de8245bc3a6406348e7e6ba0af9467914e2b691a
https://github.com/Perl/perl5/commit/de8245bc3a6406348e7e6ba0af9467914e2b691a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 8104a2c97144975a14038fb0476e3c945f41992d
https://github.com/Perl/perl5/commit/8104a2c97144975a14038fb0476e3c945f41992d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: c775cc4b14d189a588b465d3600a8f428e577fbe
https://github.com/Perl/perl5/commit/c775cc4b14d189a588b465d3600a8f428e577fbe
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 6217fe9dfa7f8f015c4b4dc2b11a3afb27ec841a
https://github.com/Perl/perl5/commit/6217fe9dfa7f8f015c4b4dc2b11a3afb27ec841a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 031f5a1516e86e7d27226e8e45f712df69a16781
https://github.com/Perl/perl5/commit/031f5a1516e86e7d27226e8e45f712df69a16781
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 7314273410727d53cb29772e801b67cd30883c48
https://github.com/Perl/perl5/commit/7314273410727d53cb29772e801b67cd30883c48
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 343aa22384adfa6113d8531cdea05d137d3ed329
https://github.com/Perl/perl5/commit/343aa22384adfa6113d8531cdea05d137d3ed329
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 4ae807e39fe2c0c22bced82eab1b3791b59e0f7b
https://github.com/Perl/perl5/commit/4ae807e39fe2c0c22bced82eab1b3791b59e0f7b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 17a36ffbf0ac5719484af31ac55387be2ad077c0
https://github.com/Perl/perl5/commit/17a36ffbf0ac5719484af31ac55387be2ad077c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: ad61e705cf88634e6823d92a9c820e0c2b4de20f
https://github.com/Perl/perl5/commit/ad61e705cf88634e6823d92a9c820e0c2b4de20f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: cb17eac009264a33bebdc7ddad454ce5af170765
https://github.com/Perl/perl5/commit/cb17eac009264a33bebdc7ddad454ce5af170765
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 617bc41a22a24191aa158e2964e1b1409294c319
https://github.com/Perl/perl5/commit/617bc41a22a24191aa158e2964e1b1409294c319
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 7a4e184927dcbfb9316fd26f5842853fbdb586f6
https://github.com/Perl/perl5/commit/7a4e184927dcbfb9316fd26f5842853fbdb586f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 22afd6a89ad23dcc7bd4f14f414bf96a253305f0
https://github.com/Perl/perl5/commit/22afd6a89ad23dcc7bd4f14f414bf96a253305f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 759d8a0494b68de1d840902af13681cfd3caa163
https://github.com/Perl/perl5/commit/759d8a0494b68de1d840902af13681cfd3caa163
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 75595df5fba94923d2afc2df81f4dc0606259f7e
https://github.com/Perl/perl5/commit/75595df5fba94923d2afc2df81f4dc0606259f7e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 46dcdb3895cd2118f8d6b81615cc23fbdc6c5dc2
https://github.com/Perl/perl5/commit/46dcdb3895cd2118f8d6b81615cc23fbdc6c5dc2
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 4238fc0085a62c9561ddf32b8dfb93b8d220ae5c
https://github.com/Perl/perl5/commit/4238fc0085a62c9561ddf32b8dfb93b8d220ae5c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 8f1036c9cfa4a41c4d7f3e2756dee0a054dff747
https://github.com/Perl/perl5/commit/8f1036c9cfa4a41c4d7f3e2756dee0a054dff747
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: b98b2c353a0d24a15a0617d8afe306a21cc2fa0c
https://github.com/Perl/perl5/commit/b98b2c353a0d24a15a0617d8afe306a21cc2fa0c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 663d70dfeac17763edbb1d3b80de975c27b5dc5f
https://github.com/Perl/perl5/commit/663d70dfeac17763edbb1d3b80de975c27b5dc5f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: e286f0f6702c50a4e48f749cb45b3741035ea691
https://github.com/Perl/perl5/commit/e286f0f6702c50a4e48f749cb45b3741035ea691
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 1a552ef276506635ee097bd572b3d0089796e132
https://github.com/Perl/perl5/commit/1a552ef276506635ee097bd572b3d0089796e132
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: fe19f9496f017b458abcc4ec20d0bb1c0d239af6
https://github.com/Perl/perl5/commit/fe19f9496f017b458abcc4ec20d0bb1c0d239af6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: c969e5d637ffe2eb7d802a9d3a88b94a735a8c32
https://github.com/Perl/perl5/commit/c969e5d637ffe2eb7d802a9d3a88b94a735a8c32
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: a0f5d2ff1aa8410039bd33db44f28901f1196d53
https://github.com/Perl/perl5/commit/a0f5d2ff1aa8410039bd33db44f28901f1196d53
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 49578708a1078e8cb2804cb232f4ace32707392d
https://github.com/Perl/perl5/commit/49578708a1078e8cb2804cb232f4ace32707392d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 7ff1155d75bd6724ebbb7d5fadb67f0390012d99
https://github.com/Perl/perl5/commit/7ff1155d75bd6724ebbb7d5fadb67f0390012d99
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: a7d87aa339d9a04f5578b5145268bee401a88743
https://github.com/Perl/perl5/commit/a7d87aa339d9a04f5578b5145268bee401a88743
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: e979451544283b81e878e81ab6f74743140266c6
https://github.com/Perl/perl5/commit/e979451544283b81e878e81ab6f74743140266c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 8f76c50e91b076da2e8643d0068f9fe73acf46c8
https://github.com/Perl/perl5/commit/8f76c50e91b076da2e8643d0068f9fe73acf46c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 67c95488c4fc789182d726bf701584540b026d95
https://github.com/Perl/perl5/commit/67c95488c4fc789182d726bf701584540b026d95
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: b1d36e0b5857e1b6b9fbbb4e9ef951adf0fbc134
https://github.com/Perl/perl5/commit/b1d36e0b5857e1b6b9fbbb4e9ef951adf0fbc134
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 80bd7c9d9a14f707559befe55ea79aad401636e0
https://github.com/Perl/perl5/commit/80bd7c9d9a14f707559befe55ea79aad401636e0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: a50a35b00399bbfb1969e133f20a620a9951a696
https://github.com/Perl/perl5/commit/a50a35b00399bbfb1969e133f20a620a9951a696
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: d2d069a1b182af781412d28ed7f15961084d7c57
https://github.com/Perl/perl5/commit/d2d069a1b182af781412d28ed7f15961084d7c57
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: c3eb7f51c805aedfb1b9a325766e38bb030f627b
https://github.com/Perl/perl5/commit/c3eb7f51c805aedfb1b9a325766e38bb030f627b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 0261bc2bdce8758c22cc2e03346840ae8deaaa03
https://github.com/Perl/perl5/commit/0261bc2bdce8758c22cc2e03346840ae8deaaa03
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 3254756dacef9409d45fd9fa67a666cbc00a6ddc
https://github.com/Perl/perl5/commit/3254756dacef9409d45fd9fa67a666cbc00a6ddc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 3afdce047a213d82df33dbfe8d667ce5f60b16af
https://github.com/Perl/perl5/commit/3afdce047a213d82df33dbfe8d667ce5f60b16af
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: eac330c37f4b80eab967337921ffe04326eab84e
https://github.com/Perl/perl5/commit/eac330c37f4b80eab967337921ffe04326eab84e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 30c2ab25d71e17cd96dd215dacff24d039d3c030
https://github.com/Perl/perl5/commit/30c2ab25d71e17cd96dd215dacff24d039d3c030
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: f9f93a90a98e482fbe96f3d958ef39dff384d475
https://github.com/Perl/perl5/commit/f9f93a90a98e482fbe96f3d958ef39dff384d475
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: 63cf69a24fc68d37437a8f36078d29fedc6d3b4b
https://github.com/Perl/perl5/commit/63cf69a24fc68d37437a8f36078d29fedc6d3b4b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 76a187d06a8660c75d3efebd9ca17acdf4ef3f1f
https://github.com/Perl/perl5/commit/76a187d06a8660c75d3efebd9ca17acdf4ef3f1f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 710de70f4b34c1b86f229bb4af7db5048d6d4036
https://github.com/Perl/perl5/commit/710de70f4b34c1b86f229bb4af7db5048d6d4036
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 725ef40094e285d0ea046d8a610d6d8a2f776159
https://github.com/Perl/perl5/commit/725ef40094e285d0ea046d8a610d6d8a2f776159
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 3e5444fb26511c016bd48d4f09c6ab330f059fe2
https://github.com/Perl/perl5/commit/3e5444fb26511c016bd48d4f09c6ab330f059fe2
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 07f86d330caacac05873bf5cc2b1ae36255ee348
https://github.com/Perl/perl5/commit/07f86d330caacac05873bf5cc2b1ae36255ee348
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: c803ff65565686a927104465814e1aa223caaacd
https://github.com/Perl/perl5/commit/c803ff65565686a927104465814e1aa223caaacd
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: d5e60a62fa14d1b188019b857fecf6de131a1160
https://github.com/Perl/perl5/commit/d5e60a62fa14d1b188019b857fecf6de131a1160
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 09d009c132e780484ae1d7770e082f655402504b
https://github.com/Perl/perl5/commit/09d009c132e780484ae1d7770e082f655402504b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 5b8877a2529261351d0da67e26584071e21f6eee
https://github.com/Perl/perl5/commit/5b8877a2529261351d0da67e26584071e21f6eee
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 1bdda3866508140177c9b340f96227f8eb414804
https://github.com/Perl/perl5/commit/1bdda3866508140177c9b340f96227f8eb414804
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 7c3cd3f4ed2dadcd1384c99a60fde51f9fba33a0
https://github.com/Perl/perl5/commit/7c3cd3f4ed2dadcd1384c99a60fde51f9fba33a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: c85d4ec3c921ed37049ec34d2e6edc396eab68be
https://github.com/Perl/perl5/commit/c85d4ec3c921ed37049ec34d2e6edc396eab68be
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: a8cc8422567cd216b6bfa7a623c27579108dbae5
https://github.com/Perl/perl5/commit/a8cc8422567cd216b6bfa7a623c27579108dbae5
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: f6e3e6f8ed002bc87d80b79e431b71fe6228b499
https://github.com/Perl/perl5/commit/f6e3e6f8ed002bc87d80b79e431b71fe6228b499
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: ecf43a52b2cb5c4d746f6a60e0fc5331e7a63150
https://github.com/Perl/perl5/commit/ecf43a52b2cb5c4d746f6a60e0fc5331e7a63150
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: e7be48585fa637a9897af6494d3cd19b544bba94
https://github.com/Perl/perl5/commit/e7be48585fa637a9897af6494d3cd19b544bba94
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: dd1b31f12cba45936d1fe6f6d7800e19a9db9a89
https://github.com/Perl/perl5/commit/dd1b31f12cba45936d1fe6f6d7800e19a9db9a89
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: f0fc4eb68156ca51d90e4225a14fb99db171817b
https://github.com/Perl/perl5/commit/f0fc4eb68156ca51d90e4225a14fb99db171817b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: a0c622ea8e7a897a7aa233a35cd4784ebf5e866d
https://github.com/Perl/perl5/commit/a0c622ea8e7a897a7aa233a35cd4784ebf5e866d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 08bcf204c9e81afffdf17fe966208b50b524ca7c
https://github.com/Perl/perl5/commit/08bcf204c9e81afffdf17fe966208b50b524ca7c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: dd84f36244e9e87d13fe02e5ab9d16fd20d2760d
https://github.com/Perl/perl5/commit/dd84f36244e9e87d13fe02e5ab9d16fd20d2760d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: 585cc43995fd7eca8517cdc31584ceedc944f0eb
https://github.com/Perl/perl5/commit/585cc43995fd7eca8517cdc31584ceedc944f0eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 6db212a81254c71c26d388c40c9c61c3d6db0b9e
https://github.com/Perl/perl5/commit/6db212a81254c71c26d388c40c9c61c3d6db0b9e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 824321d0f6d90e1fa3af69a9da912238536e5e25
https://github.com/Perl/perl5/commit/824321d0f6d90e1fa3af69a9da912238536e5e25
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 1cfd12a3220673f8e6d6538c976c8dde895abe6c
https://github.com/Perl/perl5/commit/1cfd12a3220673f8e6d6538c976c8dde895abe6c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 4c25b59da8faaccf8d24b4aa020b7adec8496e70
https://github.com/Perl/perl5/commit/4c25b59da8faaccf8d24b4aa020b7adec8496e70
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 9daaa05c552bbbd13438db0c76fb575cd597a063
https://github.com/Perl/perl5/commit/9daaa05c552bbbd13438db0c76fb575cd597a063
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 2e2f743cfac386e39b499ee3da33859d25b5a193
https://github.com/Perl/perl5/commit/2e2f743cfac386e39b499ee3da33859d25b5a193
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: d167cbf3ff41940771fb075b215d421b96761d03
https://github.com/Perl/perl5/commit/d167cbf3ff41940771fb075b215d421b96761d03
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 89f81c70b3eb991a1fc322abfb2653e4d94000a8
https://github.com/Perl/perl5/commit/89f81c70b3eb991a1fc322abfb2653e4d94000a8
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 5fab06b9edbbba2aff4ed2959947369739565c75
https://github.com/Perl/perl5/commit/5fab06b9edbbba2aff4ed2959947369739565c75
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 00c7ab98f0ad94b547990bb60ff54240780ecd59
https://github.com/Perl/perl5/commit/00c7ab98f0ad94b547990bb60ff54240780ecd59
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: c41339cad9d7f1d00d0cdb38ccc4f93571e88df1
https://github.com/Perl/perl5/commit/c41339cad9d7f1d00d0cdb38ccc4f93571e88df1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 9476194aff98cdeb8ce5698e3916696e90ef77b6
https://github.com/Perl/perl5/commit/9476194aff98cdeb8ce5698e3916696e90ef77b6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: b7a16b7a663ee80e06dc1819d512ea7898dc2f21
https://github.com/Perl/perl5/commit/b7a16b7a663ee80e06dc1819d512ea7898dc2f21
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 055014609328040708a22d84648bf759c417b788
https://github.com/Perl/perl5/commit/055014609328040708a22d84648bf759c417b788
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: c726307d477f619a0e2c2d68c6425ac159abdc5f
https://github.com/Perl/perl5/commit/c726307d477f619a0e2c2d68c6425ac159abdc5f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 6e05253581c3d2cabe12c430d84b3bdf8a75972d
https://github.com/Perl/perl5/commit/6e05253581c3d2cabe12c430d84b3bdf8a75972d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: f32a1d5552cf3e85d8c312eaec9902bbd436ac8c
https://github.com/Perl/perl5/commit/f32a1d5552cf3e85d8c312eaec9902bbd436ac8c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: b0fc739cf6d1ff7225b32db57d00513623be908d
https://github.com/Perl/perl5/commit/b0fc739cf6d1ff7225b32db57d00513623be908d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: 878a70ce99d7c067404180279b101e6218c662bc
https://github.com/Perl/perl5/commit/878a70ce99d7c067404180279b101e6218c662bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Fix up a comment
Commit: 0913629a528ecc564aa38c29aca4d2738d26cac9
https://github.com/Perl/perl5/commit/0913629a528ecc564aa38c29aca4d2738d26cac9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M embed.fnc
M embed.h
M embedvar.h
M ext/XS-APItest/t/locale.t
M handy.h
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M makedef.pl
M perl.c
M perl.h
M pod/perldiag.pod
M proto.h
M sv.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
27
Compare: https://github.com/Perl/perl5/compare/d72d3e1e0a52...0913629a528e
