Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 969f28ecd923d5f9bf4a5126e1049300ced7a35d
https://github.com/Perl/perl5/commit/969f28ecd923d5f9bf4a5126e1049300ced7a35d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: b135e024ebe10cae88fce4185d67da39ff05e17b
https://github.com/Perl/perl5/commit/b135e024ebe10cae88fce4185d67da39ff05e17b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 824de3b0f117966bf43ff75bbda3a3457699967e
https://github.com/Perl/perl5/commit/824de3b0f117966bf43ff75bbda3a3457699967e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 3f2d0b8ff87773454a9f213e162a42801a9a5bbe
https://github.com/Perl/perl5/commit/3f2d0b8ff87773454a9f213e162a42801a9a5bbe
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 6db00c350a82fc2369422f6ae89c022daafcf2bc
https://github.com/Perl/perl5/commit/6db00c350a82fc2369422f6ae89c022daafcf2bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 149eb74c64942a25ae71194f2e6637fea43daae0
https://github.com/Perl/perl5/commit/149eb74c64942a25ae71194f2e6637fea43daae0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 9ea2ea10121b81d21dac4e6ef4da70c51c436915
https://github.com/Perl/perl5/commit/9ea2ea10121b81d21dac4e6ef4da70c51c436915
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 1fb46c119aa39ff96d2735d869b06e90b5938d72
https://github.com/Perl/perl5/commit/1fb46c119aa39ff96d2735d869b06e90b5938d72
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 6634bd6c5279bcb632bdab02c14045a5ad146d1d
https://github.com/Perl/perl5/commit/6634bd6c5279bcb632bdab02c14045a5ad146d1d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 9bd3ffed7bb595b305fb5a7c72a549893768f55b
https://github.com/Perl/perl5/commit/9bd3ffed7bb595b305fb5a7c72a549893768f55b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: e86de3a9356eaa6dce5c6a4e56c1444ef29433ae
https://github.com/Perl/perl5/commit/e86de3a9356eaa6dce5c6a4e56c1444ef29433ae
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 501206b86e716445c5f0ee18548a95c1a70c032e
https://github.com/Perl/perl5/commit/501206b86e716445c5f0ee18548a95c1a70c032e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: f1b73aa76e9a404e1410b7a9e2e46f4e2f80c847
https://github.com/Perl/perl5/commit/f1b73aa76e9a404e1410b7a9e2e46f4e2f80c847
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 5e9a101ee0b3b8a6738ab289afb570053f5ff710
https://github.com/Perl/perl5/commit/5e9a101ee0b3b8a6738ab289afb570053f5ff710
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: bbb2c196e3e44b3b13ec7006b802e9257cc9588f
https://github.com/Perl/perl5/commit/bbb2c196e3e44b3b13ec7006b802e9257cc9588f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 3181e2272a4b3bf9c9509a84a674ebfbf2bb5af4
https://github.com/Perl/perl5/commit/3181e2272a4b3bf9c9509a84a674ebfbf2bb5af4
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: ac1e134c7b8e2d931f4f39d27006a8de649c034b
https://github.com/Perl/perl5/commit/ac1e134c7b8e2d931f4f39d27006a8de649c034b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 50e43b5e118b9e72d883c737d468acf4d7844dfd
https://github.com/Perl/perl5/commit/50e43b5e118b9e72d883c737d468acf4d7844dfd
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 7873a046bea0b51b7c1ebb7894e62771907e144e
https://github.com/Perl/perl5/commit/7873a046bea0b51b7c1ebb7894e62771907e144e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 6563e234bef9320a8793a8af3ac1f58e0e38ad6b
https://github.com/Perl/perl5/commit/6563e234bef9320a8793a8af3ac1f58e0e38ad6b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 5919c864767c0e6b1aee13002c98f2e76ce04cf5
https://github.com/Perl/perl5/commit/5919c864767c0e6b1aee13002c98f2e76ce04cf5
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 991fd3d9e8028245167e9fb276b15e4d4452f84e
https://github.com/Perl/perl5/commit/991fd3d9e8028245167e9fb276b15e4d4452f84e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 841cb40541ad7819ca32773b8800ac20dc7263ce
https://github.com/Perl/perl5/commit/841cb40541ad7819ca32773b8800ac20dc7263ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 6784de464c820efb99fdef1bdb6bd7a2bdf425ab
https://github.com/Perl/perl5/commit/6784de464c820efb99fdef1bdb6bd7a2bdf425ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 50014468be053a6a2a8c1a1d3c090ffb247f1cfd
https://github.com/Perl/perl5/commit/50014468be053a6a2a8c1a1d3c090ffb247f1cfd
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: fda7737c320f619204193864625c8767cb1cbe48
https://github.com/Perl/perl5/commit/fda7737c320f619204193864625c8767cb1cbe48
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: f2df8c85da559f19dcc3cb50115ef26a02877650
https://github.com/Perl/perl5/commit/f2df8c85da559f19dcc3cb50115ef26a02877650
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: be9025c7d64d3a8521804a14aa00fc02752925f4
https://github.com/Perl/perl5/commit/be9025c7d64d3a8521804a14aa00fc02752925f4
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: a9ce046047d767373f43263a009608cd1abb0f96
https://github.com/Perl/perl5/commit/a9ce046047d767373f43263a009608cd1abb0f96
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 326f27904633efd0719df520f94ba019cb180831
https://github.com/Perl/perl5/commit/326f27904633efd0719df520f94ba019cb180831
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 661bf505bdc8b3545b6191fec23e67234d8f344d
https://github.com/Perl/perl5/commit/661bf505bdc8b3545b6191fec23e67234d8f344d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 41e86f23d3e514ccab6253d198befd7567c0e40b
https://github.com/Perl/perl5/commit/41e86f23d3e514ccab6253d198befd7567c0e40b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 9b848d2f42a9ed6d6658f3183312ea37b46f9e30
https://github.com/Perl/perl5/commit/9b848d2f42a9ed6d6658f3183312ea37b46f9e30
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 4a2b47f207c1ce66cfb62eeacaffd785318950f1
https://github.com/Perl/perl5/commit/4a2b47f207c1ce66cfb62eeacaffd785318950f1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 10d1379d635cd467fcedfe639a70e698745cfc8a
https://github.com/Perl/perl5/commit/10d1379d635cd467fcedfe639a70e698745cfc8a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: d1b370198ac2987fa42e33fddc1523c1ea424ec0
https://github.com/Perl/perl5/commit/d1b370198ac2987fa42e33fddc1523c1ea424ec0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: f32e99e92d409a3bc239d2e2bdced4dcd619dff7
https://github.com/Perl/perl5/commit/f32e99e92d409a3bc239d2e2bdced4dcd619dff7
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: e44c239cefe08daa051ab0b681e773eddd168ad2
https://github.com/Perl/perl5/commit/e44c239cefe08daa051ab0b681e773eddd168ad2
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: dc49f52c8774ed7d8bff219c00dbcccc938cf24a
https://github.com/Perl/perl5/commit/dc49f52c8774ed7d8bff219c00dbcccc938cf24a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 1c361b04f423bca0f48b69e6117a400872040bda
https://github.com/Perl/perl5/commit/1c361b04f423bca0f48b69e6117a400872040bda
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 6d13a87fc8c04957afa799d68da49a5aae8215f5
https://github.com/Perl/perl5/commit/6d13a87fc8c04957afa799d68da49a5aae8215f5
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 19685573d6812db6f4ad8a47f6ecf967f5f509c9
https://github.com/Perl/perl5/commit/19685573d6812db6f4ad8a47f6ecf967f5f509c9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 04506d33c527c58847ccafc909a9f7fa3acc4bc7
https://github.com/Perl/perl5/commit/04506d33c527c58847ccafc909a9f7fa3acc4bc7
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: c5fc7cea9bce33a2c19c1c808bc476a81f85cd08
https://github.com/Perl/perl5/commit/c5fc7cea9bce33a2c19c1c808bc476a81f85cd08
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 5c53b01080b95838f399945a9bf9f060c2a7921c
https://github.com/Perl/perl5/commit/5c53b01080b95838f399945a9bf9f060c2a7921c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 4891e9b3b5892b34a0edef618eb5f522b2220c5f
https://github.com/Perl/perl5/commit/4891e9b3b5892b34a0edef618eb5f522b2220c5f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 414c62df16f0f96489c30eb55aafba79a1f7d12d
https://github.com/Perl/perl5/commit/414c62df16f0f96489c30eb55aafba79a1f7d12d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 51eb715528622556440a8762be9b3b2ba9130632
https://github.com/Perl/perl5/commit/51eb715528622556440a8762be9b3b2ba9130632
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: ab39f8508929b4353350cfdaec60af762b1083db
https://github.com/Perl/perl5/commit/ab39f8508929b4353350cfdaec60af762b1083db
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 358d513b0b744c81efde50c3657bf7f4febe13f1
https://github.com/Perl/perl5/commit/358d513b0b744c81efde50c3657bf7f4febe13f1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: acea7f48a98d6fd0b6ea02ab7bdf6307ee9a100a
https://github.com/Perl/perl5/commit/acea7f48a98d6fd0b6ea02ab7bdf6307ee9a100a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: dd47ffc48dbb5a014af64824cc1bce666a86e98f
https://github.com/Perl/perl5/commit/dd47ffc48dbb5a014af64824cc1bce666a86e98f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 08ce9379068219bceb2def367b3ce4d8c220f07e
https://github.com/Perl/perl5/commit/08ce9379068219bceb2def367b3ce4d8c220f07e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 30493f66dccbb95ad9350ea55350fb36d3cc9441
https://github.com/Perl/perl5/commit/30493f66dccbb95ad9350ea55350fb36d3cc9441
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: cc06b73fdf811153fa838aa98371fa290ad04d6e
https://github.com/Perl/perl5/commit/cc06b73fdf811153fa838aa98371fa290ad04d6e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 2ae8a3003745c2077ae95cf4ca3fd42976962f05
https://github.com/Perl/perl5/commit/2ae8a3003745c2077ae95cf4ca3fd42976962f05
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 18c86f8f034b4f9176f15df2634a7003f0fe6c19
https://github.com/Perl/perl5/commit/18c86f8f034b4f9176f15df2634a7003f0fe6c19
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 9bf05c7e380eebe820cd3ed5df690efc2d7212f6
https://github.com/Perl/perl5/commit/9bf05c7e380eebe820cd3ed5df690efc2d7212f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: a0b186d74092ada596ee4fd166bf893cd1626ff1
https://github.com/Perl/perl5/commit/a0b186d74092ada596ee4fd166bf893cd1626ff1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 4508abe49f23749ed22959a209fcf64543b45c88
https://github.com/Perl/perl5/commit/4508abe49f23749ed22959a209fcf64543b45c88
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: 8b9b3bf15718b8561c4555942b418e040b20e9b0
https://github.com/Perl/perl5/commit/8b9b3bf15718b8561c4555942b418e040b20e9b0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 599be7cc8dddc93fbd8e7b2ace446ce7bb8df4ad
https://github.com/Perl/perl5/commit/599be7cc8dddc93fbd8e7b2ace446ce7bb8df4ad
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 1404dbb1721b25acae154593e8a6012266b8fa2f
https://github.com/Perl/perl5/commit/1404dbb1721b25acae154593e8a6012266b8fa2f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 42abf5987e3dfd41db1aa367b05d3009d06a66bb
https://github.com/Perl/perl5/commit/42abf5987e3dfd41db1aa367b05d3009d06a66bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: f5e848ac99c7c44d22286ad0330518d245d30850
https://github.com/Perl/perl5/commit/f5e848ac99c7c44d22286ad0330518d245d30850
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: f88206032aac8d4ea1cee5689572b0e7e2d4b034
https://github.com/Perl/perl5/commit/f88206032aac8d4ea1cee5689572b0e7e2d4b034
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 3c073eb3e3755b5da187d195ec8ff62a3319647e
https://github.com/Perl/perl5/commit/3c073eb3e3755b5da187d195ec8ff62a3319647e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 38cd20b47d4257e2eb5d65ca5a1ca00d60cd16a3
https://github.com/Perl/perl5/commit/38cd20b47d4257e2eb5d65ca5a1ca00d60cd16a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: df8d4cfa83a65836389fee6766dc086ac0ee95b5
https://github.com/Perl/perl5/commit/df8d4cfa83a65836389fee6766dc086ac0ee95b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: e159c8ebd5f739d45887e6a24dd4f811d695f4ca
https://github.com/Perl/perl5/commit/e159c8ebd5f739d45887e6a24dd4f811d695f4ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: fc2b82bafa450621d93a5d022da0349e7ae3a639
https://github.com/Perl/perl5/commit/fc2b82bafa450621d93a5d022da0349e7ae3a639
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 7f73b14a21849553c42973e886bc265b47db7820
https://github.com/Perl/perl5/commit/7f73b14a21849553c42973e886bc265b47db7820
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 8e789a4220f475ea3cb388d31fd3b87ba9820111
https://github.com/Perl/perl5/commit/8e789a4220f475ea3cb388d31fd3b87ba9820111
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: b9b6055c97ba97d0281406a72c645ac5a8c6a853
https://github.com/Perl/perl5/commit/b9b6055c97ba97d0281406a72c645ac5a8c6a853
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 1639046903a9b712f8292cfa65c3bd2c22c1c8d7
https://github.com/Perl/perl5/commit/1639046903a9b712f8292cfa65c3bd2c22c1c8d7
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: c14d3095eb67ea426187373e534cf084387d2424
https://github.com/Perl/perl5/commit/c14d3095eb67ea426187373e534cf084387d2424
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: a3bc10fc7df3b20f6c2bff7b2fb3686d3602f500
https://github.com/Perl/perl5/commit/a3bc10fc7df3b20f6c2bff7b2fb3686d3602f500
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: fd2806566fc749955696953c7382d6b55423dd2d
https://github.com/Perl/perl5/commit/fd2806566fc749955696953c7382d6b55423dd2d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 026e8882140c40dd84253704ebf57e2eee4c506a
https://github.com/Perl/perl5/commit/026e8882140c40dd84253704ebf57e2eee4c506a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: fc0498c79696e543a6cdef18c081d14da8f4d63d
https://github.com/Perl/perl5/commit/fc0498c79696e543a6cdef18c081d14da8f4d63d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: dfc3d78192e6d1857eb4256ea899b7aa60d40c0a
https://github.com/Perl/perl5/commit/dfc3d78192e6d1857eb4256ea899b7aa60d40c0a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: fae4a392f3e4aa698da4a67451c41c628002302b
https://github.com/Perl/perl5/commit/fae4a392f3e4aa698da4a67451c41c628002302b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: aaa9444380ace07aa93441eeb56da0bd29662db2
https://github.com/Perl/perl5/commit/aaa9444380ace07aa93441eeb56da0bd29662db2
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: 8043411c098f7a3412b8f16abe494da45487dfd7
https://github.com/Perl/perl5/commit/8043411c098f7a3412b8f16abe494da45487dfd7
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: e12252bbe4e72a6bec3bc5b148c5bbce5d9353ab
https://github.com/Perl/perl5/commit/e12252bbe4e72a6bec3bc5b148c5bbce5d9353ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: b6b09155aa587d0938a1c4d51497d65a5f706cae
https://github.com/Perl/perl5/commit/b6b09155aa587d0938a1c4d51497d65a5f706cae
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 9bad4323e41a3523a5c0471549d6fed2b270d06f
https://github.com/Perl/perl5/commit/9bad4323e41a3523a5c0471549d6fed2b270d06f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: fe15a0288b87e53bf77eaec2a38f2ab6eb430b7b
https://github.com/Perl/perl5/commit/fe15a0288b87e53bf77eaec2a38f2ab6eb430b7b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: ac672dfc091280a1398ab6c24826da8757295eff
https://github.com/Perl/perl5/commit/ac672dfc091280a1398ab6c24826da8757295eff
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 666fd41f57d905a35cfc1a9067e49a71ad70c215
https://github.com/Perl/perl5/commit/666fd41f57d905a35cfc1a9067e49a71ad70c215
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 28536d3cab38749ee797dc048b66c63ecf120330
https://github.com/Perl/perl5/commit/28536d3cab38749ee797dc048b66c63ecf120330
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 578a8b5e77e2dac7972d50b751d27d6b91d50f98
https://github.com/Perl/perl5/commit/578a8b5e77e2dac7972d50b751d27d6b91d50f98
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 008b3d3519e75e0a0106237344cc51d872d5e150
https://github.com/Perl/perl5/commit/008b3d3519e75e0a0106237344cc51d872d5e150
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: a8556532caa5ddb64764ffc04dd1ba1017607e3b
https://github.com/Perl/perl5/commit/a8556532caa5ddb64764ffc04dd1ba1017607e3b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 8b920e880b1f5a269652a0d4b5ad047f7fe27730
https://github.com/Perl/perl5/commit/8b920e880b1f5a269652a0d4b5ad047f7fe27730
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: ebfde8c4b95ccfa7f349a9db717008455ef712a2
https://github.com/Perl/perl5/commit/ebfde8c4b95ccfa7f349a9db717008455ef712a2
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 123c7eea9f92397368139ed5230471929cd951d1
https://github.com/Perl/perl5/commit/123c7eea9f92397368139ed5230471929cd951d1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 8d17d90eba352ab046db6267981fbe6995d50bd6
https://github.com/Perl/perl5/commit/8d17d90eba352ab046db6267981fbe6995d50bd6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 0e5f9408139c579a41dc1cc18954e028eb5dd5bd
https://github.com/Perl/perl5/commit/0e5f9408139c579a41dc1cc18954e028eb5dd5bd
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 4aa4fd6539d91476c5d17b4894774e04ef199127
https://github.com/Perl/perl5/commit/4aa4fd6539d91476c5d17b4894774e04ef199127
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 8c8280fa8276fc7f77bf8d75d404f3638de84654
https://github.com/Perl/perl5/commit/8c8280fa8276fc7f77bf8d75d404f3638de84654
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: fd39a52c74effc1eb81640b5f4671294c30c28b0
https://github.com/Perl/perl5/commit/fd39a52c74effc1eb81640b5f4671294c30c28b0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 4264e4bda0a94f8c80a2a0b13135161dfd7c83dc
https://github.com/Perl/perl5/commit/4264e4bda0a94f8c80a2a0b13135161dfd7c83dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: ebee880cda7fb82c3b1892da4dbe1537329278c6
https://github.com/Perl/perl5/commit/ebee880cda7fb82c3b1892da4dbe1537329278c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 75dc372ede20a736f3a541e28f335a2a6046b3ad
https://github.com/Perl/perl5/commit/75dc372ede20a736f3a541e28f335a2a6046b3ad
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 9cb850313af74796e49755ec5724d971a7566d97
https://github.com/Perl/perl5/commit/9cb850313af74796e49755ec5724d971a7566d97
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 4b97252b9efd8114d621cb70fa7fed22f141ffe2
https://github.com/Perl/perl5/commit/4b97252b9efd8114d621cb70fa7fed22f141ffe2
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: b947f2797f06947badb54295b67203c6dc3ffc41
https://github.com/Perl/perl5/commit/b947f2797f06947badb54295b67203c6dc3ffc41
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 1a9aa73587b42aa2812c1f34b88ba81e4932d6b4
https://github.com/Perl/perl5/commit/1a9aa73587b42aa2812c1f34b88ba81e4932d6b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: c08a723ee2637f92baec55f9cfe877bb37fb9e26
https://github.com/Perl/perl5/commit/c08a723ee2637f92baec55f9cfe877bb37fb9e26
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 122efb7ec9ce4ac441c9451627a0ba763b500d0b
https://github.com/Perl/perl5/commit/122efb7ec9ce4ac441c9451627a0ba763b500d0b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 9e9ced426181656f9b2678ceeb671d1d3b5ddce6
https://github.com/Perl/perl5/commit/9e9ced426181656f9b2678ceeb671d1d3b5ddce6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 919039e9f92d0af9f434d7331baf60baa0527b50
https://github.com/Perl/perl5/commit/919039e9f92d0af9f434d7331baf60baa0527b50
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: 3c1415fbff05fe1fb4c9fd6abaf70d624543eb39
https://github.com/Perl/perl5/commit/3c1415fbff05fe1fb4c9fd6abaf70d624543eb39
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: c9c9c300b061c95db5b7590f213e267a08c8f4bf
https://github.com/Perl/perl5/commit/c9c9c300b061c95db5b7590f213e267a08c8f4bf
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: b4bb7d8fbae4c15b20065dd38c6d6a1331c868e7
https://github.com/Perl/perl5/commit/b4bb7d8fbae4c15b20065dd38c6d6a1331c868e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 01541b74e958c69e8a07ca2c2e5a32b93039ccb5
https://github.com/Perl/perl5/commit/01541b74e958c69e8a07ca2c2e5a32b93039ccb5
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: 945032e6f5405af25885b14716a62001b4942db8
https://github.com/Perl/perl5/commit/945032e6f5405af25885b14716a62001b4942db8
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 68e776685511df5de6aa9d71492f2803631b48e3
https://github.com/Perl/perl5/commit/68e776685511df5de6aa9d71492f2803631b48e3
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 5e88f4bc481d0e8406e1a4a10aebb39f20c1906a
https://github.com/Perl/perl5/commit/5e88f4bc481d0e8406e1a4a10aebb39f20c1906a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: c091ead21f10fd896375276f2ff2d2a82c094bac
https://github.com/Perl/perl5/commit/c091ead21f10fd896375276f2ff2d2a82c094bac
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: ae62a524b2d589ac743edddddfde36b22b3664ce
https://github.com/Perl/perl5/commit/ae62a524b2d589ac743edddddfde36b22b3664ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 7e761c29c1b4a912103f99068d36af6151bc9b93
https://github.com/Perl/perl5/commit/7e761c29c1b4a912103f99068d36af6151bc9b93
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 894a4e47d9fd72eddcc37355a3a553724d7ff213
https://github.com/Perl/perl5/commit/894a4e47d9fd72eddcc37355a3a553724d7ff213
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 25ef5f43d04c2ec196aa21f30e1791c27a41811a
https://github.com/Perl/perl5/commit/25ef5f43d04c2ec196aa21f30e1791c27a41811a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 5277297e99b86adb18191cf04464e7b0a9e335d0
https://github.com/Perl/perl5/commit/5277297e99b86adb18191cf04464e7b0a9e335d0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 55bfaf05073c96c746cf0e6b1b611de5fa678465
https://github.com/Perl/perl5/commit/55bfaf05073c96c746cf0e6b1b611de5fa678465
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 7fd96121c0a220c1989aefed11c971f8c3dc5a90
https://github.com/Perl/perl5/commit/7fd96121c0a220c1989aefed11c971f8c3dc5a90
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: f06fd5fc4aac30c8ea42056ce0c77e0fef546a28
https://github.com/Perl/perl5/commit/f06fd5fc4aac30c8ea42056ce0c77e0fef546a28
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 5c33dd976bb60189a02ef50bece98796d2253cc6
https://github.com/Perl/perl5/commit/5c33dd976bb60189a02ef50bece98796d2253cc6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 1532319b08b1764eb34e5b2155f4dcac09906a0f
https://github.com/Perl/perl5/commit/1532319b08b1764eb34e5b2155f4dcac09906a0f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 989e5765f97d432f739b8f4682823abe7daf8bd0
https://github.com/Perl/perl5/commit/989e5765f97d432f739b8f4682823abe7daf8bd0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 225c37b0ffb35aa36a02e2c148d426d40cb42da1
https://github.com/Perl/perl5/commit/225c37b0ffb35aa36a02e2c148d426d40cb42da1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 157966376d047545c0103b4c28143c43d1a063d1
https://github.com/Perl/perl5/commit/157966376d047545c0103b4c28143c43d1a063d1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: d16237a7c1322bab5ff5180667346bbf5f81adba
https://github.com/Perl/perl5/commit/d16237a7c1322bab5ff5180667346bbf5f81adba
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: f8338001b7756ff9ce7d0be60333920494d303d7
https://github.com/Perl/perl5/commit/f8338001b7756ff9ce7d0be60333920494d303d7
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 22ac0fc6ebf317d08e4a5a0565b9f02dcc3d880f
https://github.com/Perl/perl5/commit/22ac0fc6ebf317d08e4a5a0565b9f02dcc3d880f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: e37c5558863f74e36420374fa2139f5204d8a50e
https://github.com/Perl/perl5/commit/e37c5558863f74e36420374fa2139f5204d8a50e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 401c4c9c48c1797aa89f4aa83c65c7da264e0edd
https://github.com/Perl/perl5/commit/401c4c9c48c1797aa89f4aa83c65c7da264e0edd
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 29fd8050f9fa5575ad9a45a23bb073ef0dc4ea5d
https://github.com/Perl/perl5/commit/29fd8050f9fa5575ad9a45a23bb073ef0dc4ea5d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 7c1a69a7440c34224b9c5ba43729fb4ccbabaa9c
https://github.com/Perl/perl5/commit/7c1a69a7440c34224b9c5ba43729fb4ccbabaa9c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: c3133965f7fc48df67b4182e5d51ca7b64dc3d12
https://github.com/Perl/perl5/commit/c3133965f7fc48df67b4182e5d51ca7b64dc3d12
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 508a4c8875169fd0e27c15a802ddfbd81c744f3d
https://github.com/Perl/perl5/commit/508a4c8875169fd0e27c15a802ddfbd81c744f3d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 1571e9d435f347d477d7227395b2743ba66dc4a0
https://github.com/Perl/perl5/commit/1571e9d435f347d477d7227395b2743ba66dc4a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: e1885da7397e18bf83f5363d18e5f77423eb6c3c
https://github.com/Perl/perl5/commit/e1885da7397e18bf83f5363d18e5f77423eb6c3c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 80fdb7d6db36bec03ffc5518b885f2c6d9efac2d
https://github.com/Perl/perl5/commit/80fdb7d6db36bec03ffc5518b885f2c6d9efac2d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: c5d1a18f5f2dddc25b559fe262ae66b03e4bd04c
https://github.com/Perl/perl5/commit/c5d1a18f5f2dddc25b559fe262ae66b03e4bd04c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: c75797b3fdce49b9e780b69eb3c84c2c5ac8f8f2
https://github.com/Perl/perl5/commit/c75797b3fdce49b9e780b69eb3c84c2c5ac8f8f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: e9d8cc3bc35b245f49166046538f7d50cfe2837d
https://github.com/Perl/perl5/commit/e9d8cc3bc35b245f49166046538f7d50cfe2837d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 6211d0d4afc511de8ef286ce7981f145e1a3b3dc
https://github.com/Perl/perl5/commit/6211d0d4afc511de8ef286ce7981f145e1a3b3dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 5993bce7e54da823e1798f662cef3c66b6647f69
https://github.com/Perl/perl5/commit/5993bce7e54da823e1798f662cef3c66b6647f69
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: fdc5c84cf0c86a0da2ad1965eff61b047da2a0e3
https://github.com/Perl/perl5/commit/fdc5c84cf0c86a0da2ad1965eff61b047da2a0e3
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: c9393b1a1348f9d31ca0fd16ee4e90cca821e3a3
https://github.com/Perl/perl5/commit/c9393b1a1348f9d31ca0fd16ee4e90cca821e3a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 29dca8731d2d5f5910d943a11d917ce8c13d0042
https://github.com/Perl/perl5/commit/29dca8731d2d5f5910d943a11d917ce8c13d0042
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 148d43e2682703f2c80fd848704904ac9cd59b88
https://github.com/Perl/perl5/commit/148d43e2682703f2c80fd848704904ac9cd59b88
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: cd59b0bec4fa400eeb5dde191a1ae9529009e975
https://github.com/Perl/perl5/commit/cd59b0bec4fa400eeb5dde191a1ae9529009e975
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: c4af656a449589e5e2ca631598dbee3414d16bb6
https://github.com/Perl/perl5/commit/c4af656a449589e5e2ca631598dbee3414d16bb6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: c2da74c97ac856fe9783ac7139a42f615dfa6c54
https://github.com/Perl/perl5/commit/c2da74c97ac856fe9783ac7139a42f615dfa6c54
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 2374f82fb8c1439203e01d75e8dde4e06ad61620
https://github.com/Perl/perl5/commit/2374f82fb8c1439203e01d75e8dde4e06ad61620
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 3f2ea588ad3ac9287bc01157ad783d5fe4de9604
https://github.com/Perl/perl5/commit/3f2ea588ad3ac9287bc01157ad783d5fe4de9604
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: be0318d8f127cff58895bf7ff89844718b5d2391
https://github.com/Perl/perl5/commit/be0318d8f127cff58895bf7ff89844718b5d2391
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: a4992d1dfad7cd471f7604088a6ee7521850275f
https://github.com/Perl/perl5/commit/a4992d1dfad7cd471f7604088a6ee7521850275f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: f3d83d540e80f75796074a2f2a93a4533e7881e1
https://github.com/Perl/perl5/commit/f3d83d540e80f75796074a2f2a93a4533e7881e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 19bb34ef47c53d7069f4aaa7c5c7b19945c69a8f
https://github.com/Perl/perl5/commit/19bb34ef47c53d7069f4aaa7c5c7b19945c69a8f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 2b125206964b10e1b0ff71808176d7608c0f400a
https://github.com/Perl/perl5/commit/2b125206964b10e1b0ff71808176d7608c0f400a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 6d584e2b5c478fe3d1047339b95ff4bca97d5ba0
https://github.com/Perl/perl5/commit/6d584e2b5c478fe3d1047339b95ff4bca97d5ba0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 7f4b386df0c2bbbb540b597be024cc180503407d
https://github.com/Perl/perl5/commit/7f4b386df0c2bbbb540b597be024cc180503407d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 91546a9446bbd3b9cc76697a1683b3759b42b8bc
https://github.com/Perl/perl5/commit/91546a9446bbd3b9cc76697a1683b3759b42b8bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: b6de6c060de796caefb0b2da93def2018f9b4a80
https://github.com/Perl/perl5/commit/b6de6c060de796caefb0b2da93def2018f9b4a80
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 5206f2cae796da220af6aaeffc9dd81334701395
https://github.com/Perl/perl5/commit/5206f2cae796da220af6aaeffc9dd81334701395
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: ea36a8dcf08496b51fc70009442423f3541ba65c
https://github.com/Perl/perl5/commit/ea36a8dcf08496b51fc70009442423f3541ba65c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: c7c3525699761af603c792a222ff35ba76a22a57
https://github.com/Perl/perl5/commit/c7c3525699761af603c792a222ff35ba76a22a57
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: f4a0cd525ba0bc23e67dd87fd35ee635b32131ac
https://github.com/Perl/perl5/commit/f4a0cd525ba0bc23e67dd87fd35ee635b32131ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 213bd072b984fbbb47ac5b8721a1f284bf0971a6
https://github.com/Perl/perl5/commit/213bd072b984fbbb47ac5b8721a1f284bf0971a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 3f40f49cb41c2817ac68cce94ac2feef35f9aa6b
https://github.com/Perl/perl5/commit/3f40f49cb41c2817ac68cce94ac2feef35f9aa6b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 3ab56cbbeb49288bf7dd5b8acc855e00a880df2d
https://github.com/Perl/perl5/commit/3ab56cbbeb49288bf7dd5b8acc855e00a880df2d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 74505999301767f0412e82a24ce4e964a8fafe71
https://github.com/Perl/perl5/commit/74505999301767f0412e82a24ce4e964a8fafe71
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 93735cbf3a5c5367f37a9dcf24f61441a7341cdf
https://github.com/Perl/perl5/commit/93735cbf3a5c5367f37a9dcf24f61441a7341cdf
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 8c90fa93ec03e0d443c086de45d84781e2e0cc7b
https://github.com/Perl/perl5/commit/8c90fa93ec03e0d443c086de45d84781e2e0cc7b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 2e6513a2a06e210741f3f85895d7a4d22a1565b1
https://github.com/Perl/perl5/commit/2e6513a2a06e210741f3f85895d7a4d22a1565b1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: af813ba83abe6325c482f3f4f779f4af36c8de24
https://github.com/Perl/perl5/commit/af813ba83abe6325c482f3f4f779f4af36c8de24
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 02be836c7e7c8ddaf53dc5769e62473d4f9430a6
https://github.com/Perl/perl5/commit/02be836c7e7c8ddaf53dc5769e62473d4f9430a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 0791e229444f94816a49de1b412e733603de0584
https://github.com/Perl/perl5/commit/0791e229444f94816a49de1b412e733603de0584
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: 378e8bc873b74be5e6b2b45171ece39a7b6ee1f3
https://github.com/Perl/perl5/commit/378e8bc873b74be5e6b2b45171ece39a7b6ee1f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 141bbbc15cc82ff3c38b0cdc0123a1e24faa1984
https://github.com/Perl/perl5/commit/141bbbc15cc82ff3c38b0cdc0123a1e24faa1984
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: bd3c0fb9f97d1e3f3a5d72db3b63457a82cb83ed
https://github.com/Perl/perl5/commit/bd3c0fb9f97d1e3f3a5d72db3b63457a82cb83ed
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: dffa70e127c9e7c50f47d58c1c647021df48791a
https://github.com/Perl/perl5/commit/dffa70e127c9e7c50f47d58c1c647021df48791a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: e5d5ef797612927efa12610a309379eeb4d9984a
https://github.com/Perl/perl5/commit/e5d5ef797612927efa12610a309379eeb4d9984a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 71e2019e56a0c6b4d7b11f7a4323e155cee23211
https://github.com/Perl/perl5/commit/71e2019e56a0c6b4d7b11f7a4323e155cee23211
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 585e5311a151027717cd608232f75ec7646ae965
https://github.com/Perl/perl5/commit/585e5311a151027717cd608232f75ec7646ae965
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 46098b7969dcdea4a7360a516b293a27afbee438
https://github.com/Perl/perl5/commit/46098b7969dcdea4a7360a516b293a27afbee438
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 1f38d4d836340f31e2f7e6c68f19b6ba2c375fc3
https://github.com/Perl/perl5/commit/1f38d4d836340f31e2f7e6c68f19b6ba2c375fc3
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: a393826c67c0a92f5a13cd9808680d60df2985dc
https://github.com/Perl/perl5/commit/a393826c67c0a92f5a13cd9808680d60df2985dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: cab1a4ad652af6cd09aafab6506b7b2afb74358f
https://github.com/Perl/perl5/commit/cab1a4ad652af6cd09aafab6506b7b2afb74358f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: ad422fbebac25bb05603c12730a09e758342d3d1
https://github.com/Perl/perl5/commit/ad422fbebac25bb05603c12730a09e758342d3d1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 797994bd09320003ec731e10f006fe9de7e52a0c
https://github.com/Perl/perl5/commit/797994bd09320003ec731e10f006fe9de7e52a0c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 103823b4fd4f192abf3f8a5b8c51301ced2922d3
https://github.com/Perl/perl5/commit/103823b4fd4f192abf3f8a5b8c51301ced2922d3
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: ae8b3f914505f33e57f4e48ce60d4f79f7b21180
https://github.com/Perl/perl5/commit/ae8b3f914505f33e57f4e48ce60d4f79f7b21180
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 72ca31f515f96affcbe18b28310bf05eda0cf9d5
https://github.com/Perl/perl5/commit/72ca31f515f96affcbe18b28310bf05eda0cf9d5
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: bcc2eb90063ad03d28af54e851ab0802e30f32f6
https://github.com/Perl/perl5/commit/bcc2eb90063ad03d28af54e851ab0802e30f32f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 58f202f43ceaaf2256590ac8889c3801f52e9571
https://github.com/Perl/perl5/commit/58f202f43ceaaf2256590ac8889c3801f52e9571
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 49e408c3a828e354ecaa704bb13aad8ef5b7bb02
https://github.com/Perl/perl5/commit/49e408c3a828e354ecaa704bb13aad8ef5b7bb02
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 0c90a4496681b50de90692d42ba35c1d4a978ae9
https://github.com/Perl/perl5/commit/0c90a4496681b50de90692d42ba35c1d4a978ae9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 4e0b3ae8b10dcd87f567e9c8a77ea85ffd2cfd22
https://github.com/Perl/perl5/commit/4e0b3ae8b10dcd87f567e9c8a77ea85ffd2cfd22
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: fc0ab3e38ee50f461d00490142e19e1df7a2786f
https://github.com/Perl/perl5/commit/fc0ab3e38ee50f461d00490142e19e1df7a2786f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 97b93a93604460620a5da6b61d71392a91738296
https://github.com/Perl/perl5/commit/97b93a93604460620a5da6b61d71392a91738296
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: e7962d5a3e18d616491c84323834c4c645ef5765
https://github.com/Perl/perl5/commit/e7962d5a3e18d616491c84323834c4c645ef5765
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: aa9ceb2c57e2ced40f4e178a6e31e3104f4ef949
https://github.com/Perl/perl5/commit/aa9ceb2c57e2ced40f4e178a6e31e3104f4ef949
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 70528fa4f32def53d5a8f5d616bcbc89405e27bd
https://github.com/Perl/perl5/commit/70528fa4f32def53d5a8f5d616bcbc89405e27bd
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 74fc3537f9a0d0f7d506c3d4234520ccb93fe3c0
https://github.com/Perl/perl5/commit/74fc3537f9a0d0f7d506c3d4234520ccb93fe3c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: adb8734347a550f1b9a8562f4c6ec906beef8c77
https://github.com/Perl/perl5/commit/adb8734347a550f1b9a8562f4c6ec906beef8c77
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: 18d09e94b270dbf32a14b03682a2b468a00dd99a
https://github.com/Perl/perl5/commit/18d09e94b270dbf32a14b03682a2b468a00dd99a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: ad4d8d538697f39dc5d1e96284580cb3d4c49081
https://github.com/Perl/perl5/commit/ad4d8d538697f39dc5d1e96284580cb3d4c49081
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Fix up a comment
Commit: f201d83b9267f2734ad5c362644ef9fae682ec5c
https://github.com/Perl/perl5/commit/f201d83b9267f2734ad5c362644ef9fae682ec5c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M embed.fnc
M embed.h
M embedvar.h
M ext/XS-APItest/t/locale.t
M handy.h
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M makedef.pl
M perl.c
M perl.h
M pod/perldiag.pod
M proto.h
M sv.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
26
Compare: https://github.com/Perl/perl5/compare/55188c2d6efe...f201d83b9267
