Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: d244a1cc1802d0e9ef68f9cac4621b6bacdf66dd
https://github.com/Perl/perl5/commit/d244a1cc1802d0e9ef68f9cac4621b6bacdf66dd
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: dc1072e0ac287669990d0109d3fc24309006dee0
https://github.com/Perl/perl5/commit/dc1072e0ac287669990d0109d3fc24309006dee0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 39b35cf0bd0f796864046467c82f467a756a221c
https://github.com/Perl/perl5/commit/39b35cf0bd0f796864046467c82f467a756a221c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 1f12e069b21286b7906fbd8be97791af0cd41142
https://github.com/Perl/perl5/commit/1f12e069b21286b7906fbd8be97791af0cd41142
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 0eadd4f98b5196f2e2e04baad3f907b6ad20e528
https://github.com/Perl/perl5/commit/0eadd4f98b5196f2e2e04baad3f907b6ad20e528
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 9b88e2a532f7172bad503367be4f0b4cee386b7d
https://github.com/Perl/perl5/commit/9b88e2a532f7172bad503367be4f0b4cee386b7d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 148d96625c7648f0e4a7b16cfa00559a29c745af
https://github.com/Perl/perl5/commit/148d96625c7648f0e4a7b16cfa00559a29c745af
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 245f4292c94a583c389ad24cbfa50b4ea98e15b8
https://github.com/Perl/perl5/commit/245f4292c94a583c389ad24cbfa50b4ea98e15b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 006d19b164b16527706e414f5a0b4f8f57a15092
https://github.com/Perl/perl5/commit/006d19b164b16527706e414f5a0b4f8f57a15092
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 9c53e2faa7474b5de6f46b63869679c4406b8e65
https://github.com/Perl/perl5/commit/9c53e2faa7474b5de6f46b63869679c4406b8e65
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 2bec82bb18333071f21db324c69e5b3793d6d5de
https://github.com/Perl/perl5/commit/2bec82bb18333071f21db324c69e5b3793d6d5de
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 8abb028c8612dfec7a5998abc6c9c77f6afbae75
https://github.com/Perl/perl5/commit/8abb028c8612dfec7a5998abc6c9c77f6afbae75
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 795c6498e9d1919656e2906bb1f14f16cd68bbb2
https://github.com/Perl/perl5/commit/795c6498e9d1919656e2906bb1f14f16cd68bbb2
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: adc062712038baf0280f65bc14fba608b788acbc
https://github.com/Perl/perl5/commit/adc062712038baf0280f65bc14fba608b788acbc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 7be3526262dd90d00449de8c7bf09aa92fe83b89
https://github.com/Perl/perl5/commit/7be3526262dd90d00449de8c7bf09aa92fe83b89
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 7945e400c37a02cfdaaf1c37bdf52bb58ee20353
https://github.com/Perl/perl5/commit/7945e400c37a02cfdaaf1c37bdf52bb58ee20353
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 25ea663521edc56588bbb354ef6cb5538aeeb8df
https://github.com/Perl/perl5/commit/25ea663521edc56588bbb354ef6cb5538aeeb8df
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: b4a574925913cb7685e3db388c73a0051d802c44
https://github.com/Perl/perl5/commit/b4a574925913cb7685e3db388c73a0051d802c44
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: efce940bd0669fab1fe247e993d3c4b99a713e26
https://github.com/Perl/perl5/commit/efce940bd0669fab1fe247e993d3c4b99a713e26
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 505390528a3d83eed412ca8046b6e43da80aadec
https://github.com/Perl/perl5/commit/505390528a3d83eed412ca8046b6e43da80aadec
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: d0d6a84c53a5075a40de8ad43b09dc8ddcd1d385
https://github.com/Perl/perl5/commit/d0d6a84c53a5075a40de8ad43b09dc8ddcd1d385
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: e78e8ca7d1a8b23055a2ed85fccac48612861138
https://github.com/Perl/perl5/commit/e78e8ca7d1a8b23055a2ed85fccac48612861138
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 26ce668e2a0eef99b93999df23188aec11f95766
https://github.com/Perl/perl5/commit/26ce668e2a0eef99b93999df23188aec11f95766
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 22421e344c45b60ad6028451358df19e34723dc2
https://github.com/Perl/perl5/commit/22421e344c45b60ad6028451358df19e34723dc2
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: c553ea7848d3cfcc425355a5e96a7c53aafb11c4
https://github.com/Perl/perl5/commit/c553ea7848d3cfcc425355a5e96a7c53aafb11c4
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: d1bc95cfbadfddf5c4941e835dd0d74abaf7e7fc
https://github.com/Perl/perl5/commit/d1bc95cfbadfddf5c4941e835dd0d74abaf7e7fc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 0e2c077963bce406e17425dccd4fa33cd14b5678
https://github.com/Perl/perl5/commit/0e2c077963bce406e17425dccd4fa33cd14b5678
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 31160d7819b636737a67bfa2498e3a885ec90172
https://github.com/Perl/perl5/commit/31160d7819b636737a67bfa2498e3a885ec90172
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 4e6e313c8caf31f9dd65912dc3a908cd412f1d63
https://github.com/Perl/perl5/commit/4e6e313c8caf31f9dd65912dc3a908cd412f1d63
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 1cb67db3b73cc5d3bb6a79de83de809c83435fb1
https://github.com/Perl/perl5/commit/1cb67db3b73cc5d3bb6a79de83de809c83435fb1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 9bc3db141e5c782ace9e63db261fc2320cc3bd8b
https://github.com/Perl/perl5/commit/9bc3db141e5c782ace9e63db261fc2320cc3bd8b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 0b58c6742d95c92ffd28a531949a49345f7b5233
https://github.com/Perl/perl5/commit/0b58c6742d95c92ffd28a531949a49345f7b5233
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: e9d619d27009120505dfc86a6597a635a98d355b
https://github.com/Perl/perl5/commit/e9d619d27009120505dfc86a6597a635a98d355b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 241db5a20fe99953889242b2a8707b37aaa07445
https://github.com/Perl/perl5/commit/241db5a20fe99953889242b2a8707b37aaa07445
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 36a8ebea8c4404f3d7d352f2955fa2adfb1344e9
https://github.com/Perl/perl5/commit/36a8ebea8c4404f3d7d352f2955fa2adfb1344e9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 995fcf17645cde833ee790475b23be924ff6e5ae
https://github.com/Perl/perl5/commit/995fcf17645cde833ee790475b23be924ff6e5ae
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: b70598117eafeeffe8e2fd9ca8860b276db5f464
https://github.com/Perl/perl5/commit/b70598117eafeeffe8e2fd9ca8860b276db5f464
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: a34022cb5e2ed262f5f068dc8e109de764a2685e
https://github.com/Perl/perl5/commit/a34022cb5e2ed262f5f068dc8e109de764a2685e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 641ec164a90b1557f438a27609abeae2ffb2f380
https://github.com/Perl/perl5/commit/641ec164a90b1557f438a27609abeae2ffb2f380
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 2bbb9c42239b26473d635abeeb5d63f42fa178f0
https://github.com/Perl/perl5/commit/2bbb9c42239b26473d635abeeb5d63f42fa178f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: c3dcae8305051a388a18142658b57b95f31f43b8
https://github.com/Perl/perl5/commit/c3dcae8305051a388a18142658b57b95f31f43b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 327d88a1bd76d6553c23e0c4459c1e38492fa5b4
https://github.com/Perl/perl5/commit/327d88a1bd76d6553c23e0c4459c1e38492fa5b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 1e1ad4cb4788fea3ae990c038a01ecd1a58d8233
https://github.com/Perl/perl5/commit/1e1ad4cb4788fea3ae990c038a01ecd1a58d8233
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 91c9c38e978365cb054553ef4701a3415a9bd2b3
https://github.com/Perl/perl5/commit/91c9c38e978365cb054553ef4701a3415a9bd2b3
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 6622332bb7b98e60ae7055c99d6032464a4c9028
https://github.com/Perl/perl5/commit/6622332bb7b98e60ae7055c99d6032464a4c9028
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: d49607ff5162f60a2695f5e16a5b92f370b20f87
https://github.com/Perl/perl5/commit/d49607ff5162f60a2695f5e16a5b92f370b20f87
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: bbea277e135dfd80539768a58b58188f955d7987
https://github.com/Perl/perl5/commit/bbea277e135dfd80539768a58b58188f955d7987
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 2e97a5faa2e3fd756e476098bfe4198609c6765a
https://github.com/Perl/perl5/commit/2e97a5faa2e3fd756e476098bfe4198609c6765a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: fa71dc6c75fd05da97e368daaf0b2f94f8bd4218
https://github.com/Perl/perl5/commit/fa71dc6c75fd05da97e368daaf0b2f94f8bd4218
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 407ce5449811b83515a27cfcb117cd09e282d258
https://github.com/Perl/perl5/commit/407ce5449811b83515a27cfcb117cd09e282d258
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 32b6b73aa9b8426eea11799a57cb6b997b767267
https://github.com/Perl/perl5/commit/32b6b73aa9b8426eea11799a57cb6b997b767267
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 8f2a3c5bef1d565ff293a38cfa999adc8c80fb65
https://github.com/Perl/perl5/commit/8f2a3c5bef1d565ff293a38cfa999adc8c80fb65
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 031793cca22d4083a8989fe08d0a06e6584c79d0
https://github.com/Perl/perl5/commit/031793cca22d4083a8989fe08d0a06e6584c79d0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 496159467c7cee217ae38ce1c4d91942f2916b09
https://github.com/Perl/perl5/commit/496159467c7cee217ae38ce1c4d91942f2916b09
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 233e5200b129b16d7e34bdc1c0e87385fba25fd0
https://github.com/Perl/perl5/commit/233e5200b129b16d7e34bdc1c0e87385fba25fd0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 7acdeceb8491e4e71e61fdb66f34553352e18f9a
https://github.com/Perl/perl5/commit/7acdeceb8491e4e71e61fdb66f34553352e18f9a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: a037d341d3767e04ee1d1d1645dd189471b38a66
https://github.com/Perl/perl5/commit/a037d341d3767e04ee1d1d1645dd189471b38a66
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: c9a68f2b7984ed2b66fc59b9a57d8908be9d8d80
https://github.com/Perl/perl5/commit/c9a68f2b7984ed2b66fc59b9a57d8908be9d8d80
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: 0b616fb65a6c00513c6e629f99978a66515c4cf9
https://github.com/Perl/perl5/commit/0b616fb65a6c00513c6e629f99978a66515c4cf9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 32c78752d9491848bb4d5c84a2101b4cb79accc9
https://github.com/Perl/perl5/commit/32c78752d9491848bb4d5c84a2101b4cb79accc9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: a3deb535ffcb4a542b34e2e69b6b325796170bc0
https://github.com/Perl/perl5/commit/a3deb535ffcb4a542b34e2e69b6b325796170bc0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 563b43a289156aa86d0dcc024e0d7cae3e54329e
https://github.com/Perl/perl5/commit/563b43a289156aa86d0dcc024e0d7cae3e54329e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 8f63f81ab78325f03ffdae3ff4290245ff8bceb8
https://github.com/Perl/perl5/commit/8f63f81ab78325f03ffdae3ff4290245ff8bceb8
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 8ac4109490265ddb8a915bcad094d51749eb81b4
https://github.com/Perl/perl5/commit/8ac4109490265ddb8a915bcad094d51749eb81b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 1744abe4fb9aa1fe57b2f189741035ce7cac8368
https://github.com/Perl/perl5/commit/1744abe4fb9aa1fe57b2f189741035ce7cac8368
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: bda676ed6c29b32bb89e79faa9ea58ca48eda419
https://github.com/Perl/perl5/commit/bda676ed6c29b32bb89e79faa9ea58ca48eda419
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 448288641e49f7cd7d0cd548da44722da7950f02
https://github.com/Perl/perl5/commit/448288641e49f7cd7d0cd548da44722da7950f02
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: e47ccc18a0e29fe2fa2f7ed379b7fd25f4de313b
https://github.com/Perl/perl5/commit/e47ccc18a0e29fe2fa2f7ed379b7fd25f4de313b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 26cdb4d4037641fba392909e6b5b958a1e9e8e6c
https://github.com/Perl/perl5/commit/26cdb4d4037641fba392909e6b5b958a1e9e8e6c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 857de097454ecad9b877aa3e6d5848c321f23375
https://github.com/Perl/perl5/commit/857de097454ecad9b877aa3e6d5848c321f23375
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 8f4a535fc1b807e3e19f4fbed5babc8c93aeb8bb
https://github.com/Perl/perl5/commit/8f4a535fc1b807e3e19f4fbed5babc8c93aeb8bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: e45d4a5fa9bc00788cb1981b905e476a5de4ca20
https://github.com/Perl/perl5/commit/e45d4a5fa9bc00788cb1981b905e476a5de4ca20
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: f24b13568f99cf0e19f21e084001968f32e4b4f7
https://github.com/Perl/perl5/commit/f24b13568f99cf0e19f21e084001968f32e4b4f7
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: da21ce42d5f34a7e6180acce43c1333c3fe1b286
https://github.com/Perl/perl5/commit/da21ce42d5f34a7e6180acce43c1333c3fe1b286
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 00caadc5ae947031360c06d9b8de73372ca8eca4
https://github.com/Perl/perl5/commit/00caadc5ae947031360c06d9b8de73372ca8eca4
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 0d6a7150bb3e84b831bcb9dd8bd28267a790a4d3
https://github.com/Perl/perl5/commit/0d6a7150bb3e84b831bcb9dd8bd28267a790a4d3
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 4dd3a9e7d10a300b8355d5f3f6f165431e3477a6
https://github.com/Perl/perl5/commit/4dd3a9e7d10a300b8355d5f3f6f165431e3477a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 12e7bf6bba17f0e9fb10a43b23b2fedb45d89c45
https://github.com/Perl/perl5/commit/12e7bf6bba17f0e9fb10a43b23b2fedb45d89c45
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 4e8974bca5f379fa6a70af389a7864c00554b829
https://github.com/Perl/perl5/commit/4e8974bca5f379fa6a70af389a7864c00554b829
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: cf44423272d298c642e04e76d6f3f407ebaee6c8
https://github.com/Perl/perl5/commit/cf44423272d298c642e04e76d6f3f407ebaee6c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 3baf54af9fd8f837a0652d7a5d299aaa05ec41e7
https://github.com/Perl/perl5/commit/3baf54af9fd8f837a0652d7a5d299aaa05ec41e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: f76a8e14f2b1d7abcbbde77e77557a62f21518b0
https://github.com/Perl/perl5/commit/f76a8e14f2b1d7abcbbde77e77557a62f21518b0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: e12a9ddee3d828192945f257eb48d694507e46a1
https://github.com/Perl/perl5/commit/e12a9ddee3d828192945f257eb48d694507e46a1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: c9968a360da3f561507d0353abe3a4bb697c707f
https://github.com/Perl/perl5/commit/c9968a360da3f561507d0353abe3a4bb697c707f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 5ded7258a4e3dbb50073770dda9b6ee0d9c5e492
https://github.com/Perl/perl5/commit/5ded7258a4e3dbb50073770dda9b6ee0d9c5e492
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: de0566a128705f647b9dd0e240ff412a326ba0f9
https://github.com/Perl/perl5/commit/de0566a128705f647b9dd0e240ff412a326ba0f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 78e2375a4713789ca03b1b16388402feaa414057
https://github.com/Perl/perl5/commit/78e2375a4713789ca03b1b16388402feaa414057
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: cb9613809d05626a63f25fec6c14e06ca8309601
https://github.com/Perl/perl5/commit/cb9613809d05626a63f25fec6c14e06ca8309601
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 016ed424968a3c5978cbfc2f6361070e03140c3a
https://github.com/Perl/perl5/commit/016ed424968a3c5978cbfc2f6361070e03140c3a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: e06c4fe24d00f09242130712969eb3af96e607db
https://github.com/Perl/perl5/commit/e06c4fe24d00f09242130712969eb3af96e607db
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 02351b807e0c75f434c78d98d3173fb2dde8008e
https://github.com/Perl/perl5/commit/02351b807e0c75f434c78d98d3173fb2dde8008e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 333ff338bdf0b6365f877aa1eff82dcb8fadef79
https://github.com/Perl/perl5/commit/333ff338bdf0b6365f877aa1eff82dcb8fadef79
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 0c9e3d6b8c35c1335f3f51fa9fd6c649714bad70
https://github.com/Perl/perl5/commit/0c9e3d6b8c35c1335f3f51fa9fd6c649714bad70
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 75450a6a402a8f021b2fc4b2abb2a692c8864aef
https://github.com/Perl/perl5/commit/75450a6a402a8f021b2fc4b2abb2a692c8864aef
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: a0938fc88e133e18e27af9669c146c01a4b275d8
https://github.com/Perl/perl5/commit/a0938fc88e133e18e27af9669c146c01a4b275d8
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 7999bf2fca5d3c61dcaa9976d2940f9545bd98e1
https://github.com/Perl/perl5/commit/7999bf2fca5d3c61dcaa9976d2940f9545bd98e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: d9baa3be8ac9f89d04e16f7e8948b131930b7e08
https://github.com/Perl/perl5/commit/d9baa3be8ac9f89d04e16f7e8948b131930b7e08
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 76e84106328b6ad1b1038a25a50f5a2469a52948
https://github.com/Perl/perl5/commit/76e84106328b6ad1b1038a25a50f5a2469a52948
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 68c9cd4553d863418c3d15d84f70d8ace9b712cc
https://github.com/Perl/perl5/commit/68c9cd4553d863418c3d15d84f70d8ace9b712cc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 7363e847a9d3ec56a7753c0fce31375f6f95ff8e
https://github.com/Perl/perl5/commit/7363e847a9d3ec56a7753c0fce31375f6f95ff8e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 7285dfa8860777d7b71690a354decac2c3d11e48
https://github.com/Perl/perl5/commit/7285dfa8860777d7b71690a354decac2c3d11e48
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 59a926e6b31d07ca80a2d6dde1fde797577a9100
https://github.com/Perl/perl5/commit/59a926e6b31d07ca80a2d6dde1fde797577a9100
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 2a67f26b1c0bcc0adbea58a9619dcec27b360b4a
https://github.com/Perl/perl5/commit/2a67f26b1c0bcc0adbea58a9619dcec27b360b4a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: ddc7c91f50bf65b61ca0b4bfcaab785a2701f65f
https://github.com/Perl/perl5/commit/ddc7c91f50bf65b61ca0b4bfcaab785a2701f65f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 1212a857933f6a2cdfb3eeb987fc9f3cc40e9e7d
https://github.com/Perl/perl5/commit/1212a857933f6a2cdfb3eeb987fc9f3cc40e9e7d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 2e45ba6ce11aa5113fd7d44fc854ac0e341eb9cb
https://github.com/Perl/perl5/commit/2e45ba6ce11aa5113fd7d44fc854ac0e341eb9cb
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 66e83f4358ef305577e3aa9c27b2e5e739dc8903
https://github.com/Perl/perl5/commit/66e83f4358ef305577e3aa9c27b2e5e739dc8903
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: c9e8f3d1e76968007008e8e1240a0e96d5c03562
https://github.com/Perl/perl5/commit/c9e8f3d1e76968007008e8e1240a0e96d5c03562
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 5e06b55d48b2ae5c024655c5313319c9b28b7af1
https://github.com/Perl/perl5/commit/5e06b55d48b2ae5c024655c5313319c9b28b7af1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 701f1a38c1ddac85ee010f94896171b9ead9bb6c
https://github.com/Perl/perl5/commit/701f1a38c1ddac85ee010f94896171b9ead9bb6c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: df5cd3fac7262744b4455a8113b0a91514501169
https://github.com/Perl/perl5/commit/df5cd3fac7262744b4455a8113b0a91514501169
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 6857c06ec5fe15f294367bfaa8e8bce574e0e1aa
https://github.com/Perl/perl5/commit/6857c06ec5fe15f294367bfaa8e8bce574e0e1aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 7d37f05dfa36f0f5568c6c54a33c23dbb8dc59ec
https://github.com/Perl/perl5/commit/7d37f05dfa36f0f5568c6c54a33c23dbb8dc59ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: c3bef749bfe6070a47b307eb6053142732215711
https://github.com/Perl/perl5/commit/c3bef749bfe6070a47b307eb6053142732215711
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 5e3d85fdcc8bab920e05b85289f408ecf2c5a14b
https://github.com/Perl/perl5/commit/5e3d85fdcc8bab920e05b85289f408ecf2c5a14b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: 8daa20c85addda82bd1a429e667de8258f309674
https://github.com/Perl/perl5/commit/8daa20c85addda82bd1a429e667de8258f309674
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: bb1dcbb61704d3f22618c452b68748608c51a152
https://github.com/Perl/perl5/commit/bb1dcbb61704d3f22618c452b68748608c51a152
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: 57db8cb70be8484f524ce3dc394b0a1977428eb3
https://github.com/Perl/perl5/commit/57db8cb70be8484f524ce3dc394b0a1977428eb3
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: db1ced41564f20d9fe2c7d349a9bfa4ec14c2805
https://github.com/Perl/perl5/commit/db1ced41564f20d9fe2c7d349a9bfa4ec14c2805
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 894c8f33512f3db45a3550b2223a9a7e0989f2ce
https://github.com/Perl/perl5/commit/894c8f33512f3db45a3550b2223a9a7e0989f2ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 7fa81c23bcd3cafe98cf8223b508b0157ab316aa
https://github.com/Perl/perl5/commit/7fa81c23bcd3cafe98cf8223b508b0157ab316aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: e3b197bbc896e6d48d16b085b7b608eac6e2a006
https://github.com/Perl/perl5/commit/e3b197bbc896e6d48d16b085b7b608eac6e2a006
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 6fe72edaad2cfbbcca70f3a9c11a41b8d156cb63
https://github.com/Perl/perl5/commit/6fe72edaad2cfbbcca70f3a9c11a41b8d156cb63
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: ad4edaaa91521813d84ca96842400968d2f94ccc
https://github.com/Perl/perl5/commit/ad4edaaa91521813d84ca96842400968d2f94ccc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 2487de2ef8c065231588570fce25791196b2e255
https://github.com/Perl/perl5/commit/2487de2ef8c065231588570fce25791196b2e255
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 0ff03f2aa277830104b3ecca0734dc3fb4db23d9
https://github.com/Perl/perl5/commit/0ff03f2aa277830104b3ecca0734dc3fb4db23d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 92e9383041545f715a69b5aa33708f959711c668
https://github.com/Perl/perl5/commit/92e9383041545f715a69b5aa33708f959711c668
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: e164d5ac1407d1d809ed58d2d9ddfbef9fcec1e3
https://github.com/Perl/perl5/commit/e164d5ac1407d1d809ed58d2d9ddfbef9fcec1e3
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 6623c32e775f3a722db6b8be3dcd01eab70f003f
https://github.com/Perl/perl5/commit/6623c32e775f3a722db6b8be3dcd01eab70f003f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: dd6145dfd941b8ba09240109afb5e27eaf8f9013
https://github.com/Perl/perl5/commit/dd6145dfd941b8ba09240109afb5e27eaf8f9013
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 729cf0311193ee152afa4da57aa64128cbb8f678
https://github.com/Perl/perl5/commit/729cf0311193ee152afa4da57aa64128cbb8f678
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 337f524dde8bcfc4cf8fa2a8f79f6a064cea9428
https://github.com/Perl/perl5/commit/337f524dde8bcfc4cf8fa2a8f79f6a064cea9428
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 6c1d83dbe08596387f9412c56d58898ffaf7d51e
https://github.com/Perl/perl5/commit/6c1d83dbe08596387f9412c56d58898ffaf7d51e
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: aba3c1ba6ee8207d5ee16590f1dd3f25d68ea51a
https://github.com/Perl/perl5/commit/aba3c1ba6ee8207d5ee16590f1dd3f25d68ea51a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: d47f41090e7dafef47c888eb4bb870e6cac96329
https://github.com/Perl/perl5/commit/d47f41090e7dafef47c888eb4bb870e6cac96329
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 84e5f825b696214ad2df6f4211077a1340b39ff9
https://github.com/Perl/perl5/commit/84e5f825b696214ad2df6f4211077a1340b39ff9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: e5ae52d5e54c3fb73bb1b742a27293b828494eb2
https://github.com/Perl/perl5/commit/e5ae52d5e54c3fb73bb1b742a27293b828494eb2
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 58fd7145c07313ed2660b4be1d3b48f35e461841
https://github.com/Perl/perl5/commit/58fd7145c07313ed2660b4be1d3b48f35e461841
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 73bca67796f2b47f110f692b7198a580a85732b6
https://github.com/Perl/perl5/commit/73bca67796f2b47f110f692b7198a580a85732b6
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: c6a0cb0aa95689d6577fa6b93dacdbf6068c0661
https://github.com/Perl/perl5/commit/c6a0cb0aa95689d6577fa6b93dacdbf6068c0661
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 3810ee8c084d9a003d9795f0687d32a6bafc428a
https://github.com/Perl/perl5/commit/3810ee8c084d9a003d9795f0687d32a6bafc428a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 9f5e7b235d1211cccef839de9bbcf26384780020
https://github.com/Perl/perl5/commit/9f5e7b235d1211cccef839de9bbcf26384780020
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: a36f7e98e4070c3995cddb145f2d27600f8831c8
https://github.com/Perl/perl5/commit/a36f7e98e4070c3995cddb145f2d27600f8831c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 947a5ea4e7282cf0d68bcb2204ada69dda7a256d
https://github.com/Perl/perl5/commit/947a5ea4e7282cf0d68bcb2204ada69dda7a256d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 8b7d5d47e1809309ccb228b9ecfb0858f4dbb4a4
https://github.com/Perl/perl5/commit/8b7d5d47e1809309ccb228b9ecfb0858f4dbb4a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: a79ed29b40b8a9c3a9ef1dc32b2a25af02ae3626
https://github.com/Perl/perl5/commit/a79ed29b40b8a9c3a9ef1dc32b2a25af02ae3626
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 9f641c792815236401a53afc5fe6a0ed5a1c3184
https://github.com/Perl/perl5/commit/9f641c792815236401a53afc5fe6a0ed5a1c3184
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 6c383f7584c6b8ccaf3eaa41a35473e6bb5d42eb
https://github.com/Perl/perl5/commit/6c383f7584c6b8ccaf3eaa41a35473e6bb5d42eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 45d94d6fcfa7d2b8093c61b1bb2dc877c66b4ad1
https://github.com/Perl/perl5/commit/45d94d6fcfa7d2b8093c61b1bb2dc877c66b4ad1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: d19e7b7d23a23373d18a730a0843892dbcfe8b45
https://github.com/Perl/perl5/commit/d19e7b7d23a23373d18a730a0843892dbcfe8b45
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 28b0deef355782a1ba48e46b17ca2ac06c327792
https://github.com/Perl/perl5/commit/28b0deef355782a1ba48e46b17ca2ac06c327792
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: ca95516e57f691f0909f256f6ea2a196e6e89cc5
https://github.com/Perl/perl5/commit/ca95516e57f691f0909f256f6ea2a196e6e89cc5
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: ab71df256b872c0e7d52e49314b4ea6da2f5fa77
https://github.com/Perl/perl5/commit/ab71df256b872c0e7d52e49314b4ea6da2f5fa77
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 33d36bbf62d9315235dbe8f335fbabccdb474b25
https://github.com/Perl/perl5/commit/33d36bbf62d9315235dbe8f335fbabccdb474b25
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 770c39f63d148b80ebe0172277b62f36ae8791fc
https://github.com/Perl/perl5/commit/770c39f63d148b80ebe0172277b62f36ae8791fc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: da9ac22b52ce64d9112b1defa4fe83b80d3167a8
https://github.com/Perl/perl5/commit/da9ac22b52ce64d9112b1defa4fe83b80d3167a8
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: 053d8c62afa9e0621c684aca7a56d83efbd73116
https://github.com/Perl/perl5/commit/053d8c62afa9e0621c684aca7a56d83efbd73116
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: acbecf86027697b4953867c372533547ab164c1a
https://github.com/Perl/perl5/commit/acbecf86027697b4953867c372533547ab164c1a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: a4fb52e86671cca5c1ec3dd8c177d7b5c62020b2
https://github.com/Perl/perl5/commit/a4fb52e86671cca5c1ec3dd8c177d7b5c62020b2
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 602762c9c3036eae4482a7ac618b90f8019a8734
https://github.com/Perl/perl5/commit/602762c9c3036eae4482a7ac618b90f8019a8734
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 70b4328acae9a49440d5ce09887c23fb929eab39
https://github.com/Perl/perl5/commit/70b4328acae9a49440d5ce09887c23fb929eab39
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: b370b2753ad57c63ac33dd2b9954f1f708a72449
https://github.com/Perl/perl5/commit/b370b2753ad57c63ac33dd2b9954f1f708a72449
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 2015b76da7ae4843b67c759ab0e216878afcd4fc
https://github.com/Perl/perl5/commit/2015b76da7ae4843b67c759ab0e216878afcd4fc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: af81409a6a5d0f3cb4fa7810198a82ea84cceec0
https://github.com/Perl/perl5/commit/af81409a6a5d0f3cb4fa7810198a82ea84cceec0
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 75898695896835769c9860b466042240c9d3c7c5
https://github.com/Perl/perl5/commit/75898695896835769c9860b466042240c9d3c7c5
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 6f999301b875cfc9ee3676d73b6d28447d9c9a71
https://github.com/Perl/perl5/commit/6f999301b875cfc9ee3676d73b6d28447d9c9a71
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 167141e60b1c8d81bb1d109c0bbbf468db48fe4b
https://github.com/Perl/perl5/commit/167141e60b1c8d81bb1d109c0bbbf468db48fe4b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 47b3e1800e0bcf7d97dc68fc1967b744ea6e703c
https://github.com/Perl/perl5/commit/47b3e1800e0bcf7d97dc68fc1967b744ea6e703c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: ddbe4d8803e3af890375e59658a393ae3f916238
https://github.com/Perl/perl5/commit/ddbe4d8803e3af890375e59658a393ae3f916238
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 21bd3ba3eb17702f16f1e09716203551a0ffa073
https://github.com/Perl/perl5/commit/21bd3ba3eb17702f16f1e09716203551a0ffa073
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: b7af0b72bd3e5f102071bcc10c4195a5b651dc79
https://github.com/Perl/perl5/commit/b7af0b72bd3e5f102071bcc10c4195a5b651dc79
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: e0a5857222f70d7789b9f7ce7f6ed1a6107c1906
https://github.com/Perl/perl5/commit/e0a5857222f70d7789b9f7ce7f6ed1a6107c1906
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 9d4374230797235255a21bae58a020182f3ab1dc
https://github.com/Perl/perl5/commit/9d4374230797235255a21bae58a020182f3ab1dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 044d6f8d5c3c7a707aafed2b94fae24aa066ae85
https://github.com/Perl/perl5/commit/044d6f8d5c3c7a707aafed2b94fae24aa066ae85
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 57727a899568d15f232780f07dd676791142a1b9
https://github.com/Perl/perl5/commit/57727a899568d15f232780f07dd676791142a1b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: a483f0d2e32fc21847682382368c74b39ca83443
https://github.com/Perl/perl5/commit/a483f0d2e32fc21847682382368c74b39ca83443
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: c5a44f2d2bceb63fde6a4f7d3d6388cbd2b5068a
https://github.com/Perl/perl5/commit/c5a44f2d2bceb63fde6a4f7d3d6388cbd2b5068a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: aeb2380fa4b83f6f8450f286f63ca990b525835f
https://github.com/Perl/perl5/commit/aeb2380fa4b83f6f8450f286f63ca990b525835f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: d230e557b21238d908996ccfeb0717821a759987
https://github.com/Perl/perl5/commit/d230e557b21238d908996ccfeb0717821a759987
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 10c43f246f2daf8d3a402313064c92fa6175ab48
https://github.com/Perl/perl5/commit/10c43f246f2daf8d3a402313064c92fa6175ab48
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: ed37aa21d4c0622e025404fe0454bf42fd667308
https://github.com/Perl/perl5/commit/ed37aa21d4c0622e025404fe0454bf42fd667308
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: ec4d526aea2410cad8b3d6ea189da2c6eed28ce2
https://github.com/Perl/perl5/commit/ec4d526aea2410cad8b3d6ea189da2c6eed28ce2
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 1e984d79d053a7e65eacf783b2e0bbc768190910
https://github.com/Perl/perl5/commit/1e984d79d053a7e65eacf783b2e0bbc768190910
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: 0dc167eb55d3f4cb2509ba82548632a35062505f
https://github.com/Perl/perl5/commit/0dc167eb55d3f4cb2509ba82548632a35062505f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: aab081c5051ace4d970148c2acd02be13d1dc768
https://github.com/Perl/perl5/commit/aab081c5051ace4d970148c2acd02be13d1dc768
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 1057e1b92a28e564645807370e736e33b3e20e9a
https://github.com/Perl/perl5/commit/1057e1b92a28e564645807370e736e33b3e20e9a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: a37931fd4630882fb948dd462084f29882b09b51
https://github.com/Perl/perl5/commit/a37931fd4630882fb948dd462084f29882b09b51
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: 20a533abedf506233783e365df081c35e4f44167
https://github.com/Perl/perl5/commit/20a533abedf506233783e365df081c35e4f44167
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: d83466ed81083d859a9f2a69feb3db91fab4e303
https://github.com/Perl/perl5/commit/d83466ed81083d859a9f2a69feb3db91fab4e303
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 2206e16201a41fe6271266ce4325e0fb81fc3494
https://github.com/Perl/perl5/commit/2206e16201a41fe6271266ce4325e0fb81fc3494
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: a43a48a052e52583ba7f5fc3cd111d534b6b7140
https://github.com/Perl/perl5/commit/a43a48a052e52583ba7f5fc3cd111d534b6b7140
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: c442d8e5bec89b6ff5e06fafba02cccfb4adc186
https://github.com/Perl/perl5/commit/c442d8e5bec89b6ff5e06fafba02cccfb4adc186
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: d909e05ebf9ff80320b3beca80546cd501fb0173
https://github.com/Perl/perl5/commit/d909e05ebf9ff80320b3beca80546cd501fb0173
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: 20141458e79d00f3bad25b0e83c4774a592d5dd2
https://github.com/Perl/perl5/commit/20141458e79d00f3bad25b0e83c4774a592d5dd2
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 70345cfa6ed34731f68dded17475eacf4ea31498
https://github.com/Perl/perl5/commit/70345cfa6ed34731f68dded17475eacf4ea31498
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: dcc475dcd0e11ac0c47db0320ab471d53af6f6a1
https://github.com/Perl/perl5/commit/dcc475dcd0e11ac0c47db0320ab471d53af6f6a1
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 57f512f6977e4c401b3814ca6d059102417c55fc
https://github.com/Perl/perl5/commit/57f512f6977e4c401b3814ca6d059102417c55fc
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 52c40d0db31b14f2957f58c25308cd49d51d6b0a
https://github.com/Perl/perl5/commit/52c40d0db31b14f2957f58c25308cd49d51d6b0a
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 53207cf596c5a23edd588d3cf27b73a4e6317493
https://github.com/Perl/perl5/commit/53207cf596c5a23edd588d3cf27b73a4e6317493
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 3ade90a5a2e504eb02791bbed31c7fbe060f8a41
https://github.com/Perl/perl5/commit/3ade90a5a2e504eb02791bbed31c7fbe060f8a41
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: edabc383e54bc6d549595a3aa77b55b3d3c20492
https://github.com/Perl/perl5/commit/edabc383e54bc6d549595a3aa77b55b3d3c20492
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 31d07a207853aad44eeefc132df1725c90ab6531
https://github.com/Perl/perl5/commit/31d07a207853aad44eeefc132df1725c90ab6531
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: ec03a72fb30f0c53eaf521f9e2c8ad59dff5f0f7
https://github.com/Perl/perl5/commit/ec03a72fb30f0c53eaf521f9e2c8ad59dff5f0f7
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 4e48407de5f06d91fd2eae7ebc6800847b29a0fd
https://github.com/Perl/perl5/commit/4e48407de5f06d91fd2eae7ebc6800847b29a0fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: e9c704646c5932472bff1f74335b6becc045e47c
https://github.com/Perl/perl5/commit/e9c704646c5932472bff1f74335b6becc045e47c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 91ac903b19553782d500c564c7aff677c6d78e22
https://github.com/Perl/perl5/commit/91ac903b19553782d500c564c7aff677c6d78e22
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: ca183b30f948a520935d0568da2a0ccde3b99819
https://github.com/Perl/perl5/commit/ca183b30f948a520935d0568da2a0ccde3b99819
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 15acc0e060a7f723b53913db9b8882db5d030505
https://github.com/Perl/perl5/commit/15acc0e060a7f723b53913db9b8882db5d030505
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 5bc17dd6f97499cd8bdb1afc14f30042300f9330
https://github.com/Perl/perl5/commit/5bc17dd6f97499cd8bdb1afc14f30042300f9330
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 419c6bd2fa3a95f5143b46b50819655d8ae05a0c
https://github.com/Perl/perl5/commit/419c6bd2fa3a95f5143b46b50819655d8ae05a0c
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: 81302fd7c68f88cdab8c980d5213050b3d6f327d
https://github.com/Perl/perl5/commit/81302fd7c68f88cdab8c980d5213050b3d6f327d
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: c5ec955eb4082234a3145a47c7794b86c738234b
https://github.com/Perl/perl5/commit/c5ec955eb4082234a3145a47c7794b86c738234b
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: 36cd3f440f4aac9c229fef60daa999d2ba98aa2f
https://github.com/Perl/perl5/commit/36cd3f440f4aac9c229fef60daa999d2ba98aa2f
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Fix up a comment
Commit: 55188c2d6efe8e0e54958068a2bf1fd931749638
https://github.com/Perl/perl5/commit/55188c2d6efe8e0e54958068a2bf1fd931749638
Author: Karl Williamson <[email protected]>
Date: 2021-04-09 (Fri, 09 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M embed.fnc
M embed.h
M embedvar.h
M ext/XS-APItest/t/locale.t
M handy.h
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.c
M perl.h
M pod/perldiag.pod
M proto.h
M sv.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
25
Compare: https://github.com/Perl/perl5/compare/c83ab25d338d...55188c2d6efe
