Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: aa662c810169f35c94655e6b729ab4f79fec27de
https://github.com/Perl/perl5/commit/aa662c810169f35c94655e6b729ab4f79fec27de
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: e6a5f2548dce7591755df5bb9600f365dc320499
https://github.com/Perl/perl5/commit/e6a5f2548dce7591755df5bb9600f365dc320499
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 93a26bfb1d662ca26b0a4030d2f4a6ededd3c5a1
https://github.com/Perl/perl5/commit/93a26bfb1d662ca26b0a4030d2f4a6ededd3c5a1
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 4b001f94cc4897d078d6ad2153109a98b08f0ca8
https://github.com/Perl/perl5/commit/4b001f94cc4897d078d6ad2153109a98b08f0ca8
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: fe0cdcedadcac81cee73b62b31809248ec338134
https://github.com/Perl/perl5/commit/fe0cdcedadcac81cee73b62b31809248ec338134
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 4b6f3cb10a3220b8ce3ee90aec56ca326d33cbc8
https://github.com/Perl/perl5/commit/4b6f3cb10a3220b8ce3ee90aec56ca326d33cbc8
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 0ad9f38e40e8e6c3d8868a07b4793a31d0a604da
https://github.com/Perl/perl5/commit/0ad9f38e40e8e6c3d8868a07b4793a31d0a604da
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 92f3a8008bf19575188cf79b691fe85d30e9a5c1
https://github.com/Perl/perl5/commit/92f3a8008bf19575188cf79b691fe85d30e9a5c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 0d4d1c292ef786a3b903e122586befce82575929
https://github.com/Perl/perl5/commit/0d4d1c292ef786a3b903e122586befce82575929
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 6ad6142b10c7e51298a75ef5287e30cbf6a4bdb4
https://github.com/Perl/perl5/commit/6ad6142b10c7e51298a75ef5287e30cbf6a4bdb4
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: cf072d9095a660ea83699158d49ced7283b6709f
https://github.com/Perl/perl5/commit/cf072d9095a660ea83699158d49ced7283b6709f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 37b05a53f04379b7e869b7bf1bd7fb62d69f4218
https://github.com/Perl/perl5/commit/37b05a53f04379b7e869b7bf1bd7fb62d69f4218
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: f47cd768d9f1e4c24a755b1354c9fa0e381b5449
https://github.com/Perl/perl5/commit/f47cd768d9f1e4c24a755b1354c9fa0e381b5449
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 4f3fcb3be043eb652726cfe97c2f90e001a62c28
https://github.com/Perl/perl5/commit/4f3fcb3be043eb652726cfe97c2f90e001a62c28
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: f6cfc7a441113d80e905ff50e42060f560966fda
https://github.com/Perl/perl5/commit/f6cfc7a441113d80e905ff50e42060f560966fda
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 74d1337f399c70048601ff5bb87bfd01caf9cc86
https://github.com/Perl/perl5/commit/74d1337f399c70048601ff5bb87bfd01caf9cc86
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: fa7c83ffc92724bb30e1f58936b93c568d229699
https://github.com/Perl/perl5/commit/fa7c83ffc92724bb30e1f58936b93c568d229699
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 3b37db2f7e5b5404b872dd44809cfcfcad4085d2
https://github.com/Perl/perl5/commit/3b37db2f7e5b5404b872dd44809cfcfcad4085d2
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 9d2c883651514d63cb2a28fe6770415d7cc85320
https://github.com/Perl/perl5/commit/9d2c883651514d63cb2a28fe6770415d7cc85320
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: c0639d57426e7515f854cf46871488e6e9ce1099
https://github.com/Perl/perl5/commit/c0639d57426e7515f854cf46871488e6e9ce1099
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 5978d01c5786d7dd568268bdd9a6ac274ffed1f5
https://github.com/Perl/perl5/commit/5978d01c5786d7dd568268bdd9a6ac274ffed1f5
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 608eb658481181d52a974effd7a4b985d0ec8f50
https://github.com/Perl/perl5/commit/608eb658481181d52a974effd7a4b985d0ec8f50
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 2685b3c808ac1ccc340baa126d76364564fe7b4c
https://github.com/Perl/perl5/commit/2685b3c808ac1ccc340baa126d76364564fe7b4c
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: adef53c0ddd34d7aecd29b8a975c1571ee7498ca
https://github.com/Perl/perl5/commit/adef53c0ddd34d7aecd29b8a975c1571ee7498ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 46b2d9d116a1265e9ef4ee8ff8b62a752af81ce6
https://github.com/Perl/perl5/commit/46b2d9d116a1265e9ef4ee8ff8b62a752af81ce6
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 1d25efab44bf65ec4308343912613d0656827fff
https://github.com/Perl/perl5/commit/1d25efab44bf65ec4308343912613d0656827fff
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 63699d05f5b8d345a493386a9d48a38c18829010
https://github.com/Perl/perl5/commit/63699d05f5b8d345a493386a9d48a38c18829010
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 0c292bbb3d4a29be4a408dfa0c5e4c70f3e37342
https://github.com/Perl/perl5/commit/0c292bbb3d4a29be4a408dfa0c5e4c70f3e37342
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 39dfde46bbbc3727008fba86369df4518a43f4bd
https://github.com/Perl/perl5/commit/39dfde46bbbc3727008fba86369df4518a43f4bd
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 223fc00c97cbc469ccbf016dee0b217157f8e72c
https://github.com/Perl/perl5/commit/223fc00c97cbc469ccbf016dee0b217157f8e72c
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: b5db398c36ec331e7ac11ddac98c49313c68fa19
https://github.com/Perl/perl5/commit/b5db398c36ec331e7ac11ddac98c49313c68fa19
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: cf643fb51e9b581cd9efb1112f15bfb8ca02fdb2
https://github.com/Perl/perl5/commit/cf643fb51e9b581cd9efb1112f15bfb8ca02fdb2
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: fe40999036a7bbb3aa729c691fbe18e71db9f8a7
https://github.com/Perl/perl5/commit/fe40999036a7bbb3aa729c691fbe18e71db9f8a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 5de00b9485d1edf5b5f6bcecc65ec67d8e0a4f40
https://github.com/Perl/perl5/commit/5de00b9485d1edf5b5f6bcecc65ec67d8e0a4f40
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 9198b311b2f676a000b2f04ab027a1b2f3b7be74
https://github.com/Perl/perl5/commit/9198b311b2f676a000b2f04ab027a1b2f3b7be74
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: a9e3ccd2a34616e8afc66a3a040361355934b3b9
https://github.com/Perl/perl5/commit/a9e3ccd2a34616e8afc66a3a040361355934b3b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 9d3a8e8e0f7cc127292aa5f41685128afb95cd95
https://github.com/Perl/perl5/commit/9d3a8e8e0f7cc127292aa5f41685128afb95cd95
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 19c438489098c8d8a83ace79f3e51d9ddc6fbc40
https://github.com/Perl/perl5/commit/19c438489098c8d8a83ace79f3e51d9ddc6fbc40
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 23319da93ab81a2d497074366a3e533c9000e401
https://github.com/Perl/perl5/commit/23319da93ab81a2d497074366a3e533c9000e401
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: b0ab0fbf987056cb1a025987a1dd524431b12936
https://github.com/Perl/perl5/commit/b0ab0fbf987056cb1a025987a1dd524431b12936
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: a891fb05c882a9cafc399317169c8d6ce9e8d98e
https://github.com/Perl/perl5/commit/a891fb05c882a9cafc399317169c8d6ce9e8d98e
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 6ad1f230e07e2995b29e85f40ec8d86a32d92314
https://github.com/Perl/perl5/commit/6ad1f230e07e2995b29e85f40ec8d86a32d92314
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 7226bf3595030e5030007563bddc7ce9c43fb0e1
https://github.com/Perl/perl5/commit/7226bf3595030e5030007563bddc7ce9c43fb0e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 8937ea76cddcd4bbcab16989b46bb8df08083d4e
https://github.com/Perl/perl5/commit/8937ea76cddcd4bbcab16989b46bb8df08083d4e
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 2fd8309ff02526d26b49cc3f0714afadaa92feca
https://github.com/Perl/perl5/commit/2fd8309ff02526d26b49cc3f0714afadaa92feca
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 21cbec9310b986e357f152c46eb86bad5f6907dc
https://github.com/Perl/perl5/commit/21cbec9310b986e357f152c46eb86bad5f6907dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 05fa330e7f9ef3316a240133d961ed991e9b015f
https://github.com/Perl/perl5/commit/05fa330e7f9ef3316a240133d961ed991e9b015f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: afda74d071d82053aa56d48c84ec49fef14f876d
https://github.com/Perl/perl5/commit/afda74d071d82053aa56d48c84ec49fef14f876d
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 06df09d3d14de7e5fa255cc9ed6ca7ba28994167
https://github.com/Perl/perl5/commit/06df09d3d14de7e5fa255cc9ed6ca7ba28994167
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 57492152cd6bc98ee44e62083023e5002f2d389e
https://github.com/Perl/perl5/commit/57492152cd6bc98ee44e62083023e5002f2d389e
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 837b16a3d28cd55d3b16f1e084943ec118022d47
https://github.com/Perl/perl5/commit/837b16a3d28cd55d3b16f1e084943ec118022d47
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 61162cec72edd470ce31733fe1b5525aa67d57eb
https://github.com/Perl/perl5/commit/61162cec72edd470ce31733fe1b5525aa67d57eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 061718098a7724679d7d8eddd857d1ca0a896f1a
https://github.com/Perl/perl5/commit/061718098a7724679d7d8eddd857d1ca0a896f1a
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: cc3629a99377d5630a6b53617ce39d8733af08dc
https://github.com/Perl/perl5/commit/cc3629a99377d5630a6b53617ce39d8733af08dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 095676dd109ad126a67861425dea42e72ca86f17
https://github.com/Perl/perl5/commit/095676dd109ad126a67861425dea42e72ca86f17
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 501fffc5fae20004ad63d1eeb8ab8a252ed54d72
https://github.com/Perl/perl5/commit/501fffc5fae20004ad63d1eeb8ab8a252ed54d72
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 1509209464e76ff7b0cdaf5131b983e65e8c533e
https://github.com/Perl/perl5/commit/1509209464e76ff7b0cdaf5131b983e65e8c533e
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: cd2a9dea36232c0f0a9755a8554e7f13035ce3c0
https://github.com/Perl/perl5/commit/cd2a9dea36232c0f0a9755a8554e7f13035ce3c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: 01d17d69e860109980fd569d97a8fa1fc6e87c49
https://github.com/Perl/perl5/commit/01d17d69e860109980fd569d97a8fa1fc6e87c49
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 617bdca7e891d8e2ca355dd186d953e478659ab4
https://github.com/Perl/perl5/commit/617bdca7e891d8e2ca355dd186d953e478659ab4
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: bb1989e5fe22cbf94dce8e07f41afb5969936d9d
https://github.com/Perl/perl5/commit/bb1989e5fe22cbf94dce8e07f41afb5969936d9d
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: c6ce56813eb88436295bc6a27bc6f81a5bb2ef84
https://github.com/Perl/perl5/commit/c6ce56813eb88436295bc6a27bc6f81a5bb2ef84
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 6e7e69a40c1f29af3d3d982706203f98a8b2dd06
https://github.com/Perl/perl5/commit/6e7e69a40c1f29af3d3d982706203f98a8b2dd06
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 00e484f5422b3be50fc1a07bc7ccc04ed24f6e75
https://github.com/Perl/perl5/commit/00e484f5422b3be50fc1a07bc7ccc04ed24f6e75
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 0080722ebf13f2b9434afae1c71a3eca65f39394
https://github.com/Perl/perl5/commit/0080722ebf13f2b9434afae1c71a3eca65f39394
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: e3048faca519ef164110c9e3a3b85950d75b0cf4
https://github.com/Perl/perl5/commit/e3048faca519ef164110c9e3a3b85950d75b0cf4
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: c0579ae750aaa5caf4e8d9a4bf584e5f70aa9bb6
https://github.com/Perl/perl5/commit/c0579ae750aaa5caf4e8d9a4bf584e5f70aa9bb6
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: c81b5d23ec5b37fc8f5474054ef51fbb98f75667
https://github.com/Perl/perl5/commit/c81b5d23ec5b37fc8f5474054ef51fbb98f75667
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 31c4996929164e6b7fd7df8da3215ce14983275c
https://github.com/Perl/perl5/commit/31c4996929164e6b7fd7df8da3215ce14983275c
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: d226efbb5155bdeba4b7fdb171cb987f95e1b2c3
https://github.com/Perl/perl5/commit/d226efbb5155bdeba4b7fdb171cb987f95e1b2c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 658188e4b2fce0b9f1490bc792cc5916439f4e35
https://github.com/Perl/perl5/commit/658188e4b2fce0b9f1490bc792cc5916439f4e35
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: c9346f462ed1c4b27d74f0b626e36afa92d4d22b
https://github.com/Perl/perl5/commit/c9346f462ed1c4b27d74f0b626e36afa92d4d22b
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 952d49375d2f2377d44be618840d341bc91aa510
https://github.com/Perl/perl5/commit/952d49375d2f2377d44be618840d341bc91aa510
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: da93dc0e368773ee417c77db7c3223528f8f591f
https://github.com/Perl/perl5/commit/da93dc0e368773ee417c77db7c3223528f8f591f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 6a3acd0df5292b4eaea7ccb7b2b26aaa3d8dd6ed
https://github.com/Perl/perl5/commit/6a3acd0df5292b4eaea7ccb7b2b26aaa3d8dd6ed
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 395919f6ff65ebac3dd8e8090170ddab5061d9b0
https://github.com/Perl/perl5/commit/395919f6ff65ebac3dd8e8090170ddab5061d9b0
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 340a8c7e663d5ad4b346eeec5d7e298d7a68a8e8
https://github.com/Perl/perl5/commit/340a8c7e663d5ad4b346eeec5d7e298d7a68a8e8
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 036be99eb44e5b5a99089a3e74711d6468a74ddc
https://github.com/Perl/perl5/commit/036be99eb44e5b5a99089a3e74711d6468a74ddc
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: aed0b5fac38190806e1b359830ca9fce1177ebf4
https://github.com/Perl/perl5/commit/aed0b5fac38190806e1b359830ca9fce1177ebf4
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 7041869c040314023dbc520283ebb30dc16b1b1c
https://github.com/Perl/perl5/commit/7041869c040314023dbc520283ebb30dc16b1b1c
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 715c2e36c9f1f10144eea2d913573909ce733970
https://github.com/Perl/perl5/commit/715c2e36c9f1f10144eea2d913573909ce733970
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: e65a56ed49bcf46bd51ad95961e6dedde0dbb9fe
https://github.com/Perl/perl5/commit/e65a56ed49bcf46bd51ad95961e6dedde0dbb9fe
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: a1cfb52804c3ccbd6ed417d65130685480e43561
https://github.com/Perl/perl5/commit/a1cfb52804c3ccbd6ed417d65130685480e43561
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: 6e971998dbebe9362360c2c0f84f90ebf0c2c673
https://github.com/Perl/perl5/commit/6e971998dbebe9362360c2c0f84f90ebf0c2c673
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: b1389e7111fee1e6a44f9ce97b531c3638830fe2
https://github.com/Perl/perl5/commit/b1389e7111fee1e6a44f9ce97b531c3638830fe2
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: aa685c0c9bc81b2e7aed7bac264bac70c6d95cb1
https://github.com/Perl/perl5/commit/aa685c0c9bc81b2e7aed7bac264bac70c6d95cb1
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: db8364b2d71f7bd7ccf2efda7f03d4dba3d08070
https://github.com/Perl/perl5/commit/db8364b2d71f7bd7ccf2efda7f03d4dba3d08070
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: ec0e7e15c9bf7b60e2fef7d59a60151e1517279f
https://github.com/Perl/perl5/commit/ec0e7e15c9bf7b60e2fef7d59a60151e1517279f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 7270731ac77d4beaffcdf09a09e69dde8e4d5fc8
https://github.com/Perl/perl5/commit/7270731ac77d4beaffcdf09a09e69dde8e4d5fc8
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: adbc5d7dbd2dbf59d00d56b3a3ab09a7a2d34a1d
https://github.com/Perl/perl5/commit/adbc5d7dbd2dbf59d00d56b3a3ab09a7a2d34a1d
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 00f1b088ffebeca9fc5f87c195065119a87e4815
https://github.com/Perl/perl5/commit/00f1b088ffebeca9fc5f87c195065119a87e4815
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 6029344b82a7c3bd57030f1a7525a00497cd05c4
https://github.com/Perl/perl5/commit/6029344b82a7c3bd57030f1a7525a00497cd05c4
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 06b784b98154acdb0931ed8b67b8c7dec65e5a84
https://github.com/Perl/perl5/commit/06b784b98154acdb0931ed8b67b8c7dec65e5a84
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 7c706f5802a10395d4d68e23163c38a544dd7c57
https://github.com/Perl/perl5/commit/7c706f5802a10395d4d68e23163c38a544dd7c57
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: aa341bcd748b6a5bd75011831f35eee029228d0b
https://github.com/Perl/perl5/commit/aa341bcd748b6a5bd75011831f35eee029228d0b
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: b83776dd0f4a9881ca247f32abf189217a6cf89d
https://github.com/Perl/perl5/commit/b83776dd0f4a9881ca247f32abf189217a6cf89d
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: d52b4475db946d0e883f1c8466313ca604eb8d79
https://github.com/Perl/perl5/commit/d52b4475db946d0e883f1c8466313ca604eb8d79
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: a209f126725c59c0478da0fdef53dea2eae71795
https://github.com/Perl/perl5/commit/a209f126725c59c0478da0fdef53dea2eae71795
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 89d13833c8c4f93eb06f53ad6fc7d93480ab2a66
https://github.com/Perl/perl5/commit/89d13833c8c4f93eb06f53ad6fc7d93480ab2a66
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 20556b69d96e7f66274f8cdcae2a8bcd9363d9e8
https://github.com/Perl/perl5/commit/20556b69d96e7f66274f8cdcae2a8bcd9363d9e8
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: ff89b897d2e3719f9f830900b65c8186e6bf12a6
https://github.com/Perl/perl5/commit/ff89b897d2e3719f9f830900b65c8186e6bf12a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 069171c2d9ed43b2fc2caf889db01fbfb711fc37
https://github.com/Perl/perl5/commit/069171c2d9ed43b2fc2caf889db01fbfb711fc37
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 5bf2fc31512408f7b332d76cdd1bda562024f5de
https://github.com/Perl/perl5/commit/5bf2fc31512408f7b332d76cdd1bda562024f5de
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: ada60bcc30498d75a75e019569c19366de3f5964
https://github.com/Perl/perl5/commit/ada60bcc30498d75a75e019569c19366de3f5964
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: d9564e5af7faf19ff3960ab3bc3c690f3d1471a6
https://github.com/Perl/perl5/commit/d9564e5af7faf19ff3960ab3bc3c690f3d1471a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 05d47e7ec64e09f23076d6645860ab54042889bb
https://github.com/Perl/perl5/commit/05d47e7ec64e09f23076d6645860ab54042889bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 0e004738bad57f439431b43cf45f614143102196
https://github.com/Perl/perl5/commit/0e004738bad57f439431b43cf45f614143102196
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 4653088ff9eb3290c59404b45a16a54083d0b945
https://github.com/Perl/perl5/commit/4653088ff9eb3290c59404b45a16a54083d0b945
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 7e49d322c1756d216ea7f1c0315d486e94c7a2a2
https://github.com/Perl/perl5/commit/7e49d322c1756d216ea7f1c0315d486e94c7a2a2
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 0a4f5c2398986946903e36da449ac6ac7b091424
https://github.com/Perl/perl5/commit/0a4f5c2398986946903e36da449ac6ac7b091424
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 6110edaac5fbf80fcf044b52f3334de735d8e8b1
https://github.com/Perl/perl5/commit/6110edaac5fbf80fcf044b52f3334de735d8e8b1
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: d759d000f99f0cb830b20ef881b553a1061f01ab
https://github.com/Perl/perl5/commit/d759d000f99f0cb830b20ef881b553a1061f01ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 7047ecc37cfbcf6460ca993e6c9a3d1b48ae1ed1
https://github.com/Perl/perl5/commit/7047ecc37cfbcf6460ca993e6c9a3d1b48ae1ed1
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: bfe8a43e2156536d3474b0f0fa9ff901907ee7d2
https://github.com/Perl/perl5/commit/bfe8a43e2156536d3474b0f0fa9ff901907ee7d2
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 6ccd022372a1db12d4059dacd80da4b781801ebc
https://github.com/Perl/perl5/commit/6ccd022372a1db12d4059dacd80da4b781801ebc
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: 33d173b0e42051b4143b8c3cbf158c91ccb82249
https://github.com/Perl/perl5/commit/33d173b0e42051b4143b8c3cbf158c91ccb82249
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: afa14e9e804078813ef1de84a9012952e0242ba9
https://github.com/Perl/perl5/commit/afa14e9e804078813ef1de84a9012952e0242ba9
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: bca1b3b238e2a471d4ddfbf63fff6a54ec1609d9
https://github.com/Perl/perl5/commit/bca1b3b238e2a471d4ddfbf63fff6a54ec1609d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: e56fe87075faeeb0d93ede9466f82c762f712957
https://github.com/Perl/perl5/commit/e56fe87075faeeb0d93ede9466f82c762f712957
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 2d5135289791983189f1d2f528a93d4856f6866f
https://github.com/Perl/perl5/commit/2d5135289791983189f1d2f528a93d4856f6866f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: a6ff0c52ae567031f04697af75287ae1df594b61
https://github.com/Perl/perl5/commit/a6ff0c52ae567031f04697af75287ae1df594b61
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 37f36c00fd3a839672fbf0301eff888cff4a6d2f
https://github.com/Perl/perl5/commit/37f36c00fd3a839672fbf0301eff888cff4a6d2f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 6291b1c21c4ee912fd84971f83f45f37aef85e93
https://github.com/Perl/perl5/commit/6291b1c21c4ee912fd84971f83f45f37aef85e93
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 46da0381af5cbbc82d6f617d08e871e223895bae
https://github.com/Perl/perl5/commit/46da0381af5cbbc82d6f617d08e871e223895bae
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: f3cded32058880edb1c70009f087c56764404b18
https://github.com/Perl/perl5/commit/f3cded32058880edb1c70009f087c56764404b18
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: effdfbfe9a8d5077382dc7a7fd792742ee23bf34
https://github.com/Perl/perl5/commit/effdfbfe9a8d5077382dc7a7fd792742ee23bf34
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: e62c0cd0d01aa613e3c2864cef5fe975f83e40ef
https://github.com/Perl/perl5/commit/e62c0cd0d01aa613e3c2864cef5fe975f83e40ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 027df3a1c8229a0a8bb9495816f8e060a71ac212
https://github.com/Perl/perl5/commit/027df3a1c8229a0a8bb9495816f8e060a71ac212
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 3a30ea7e7fcfe1e34e5436ddf05db6fdd1970de9
https://github.com/Perl/perl5/commit/3a30ea7e7fcfe1e34e5436ddf05db6fdd1970de9
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 38691eb503e82b41a10c6f029a8cce5fd5266040
https://github.com/Perl/perl5/commit/38691eb503e82b41a10c6f029a8cce5fd5266040
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 542a7378b6217b57f2efef60eaf50c3661ed0643
https://github.com/Perl/perl5/commit/542a7378b6217b57f2efef60eaf50c3661ed0643
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 69005ae5d57a454e4f7317303ee1d08719f43004
https://github.com/Perl/perl5/commit/69005ae5d57a454e4f7317303ee1d08719f43004
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 1f4c25b3636fe61af34953a21afe9ed28b266d66
https://github.com/Perl/perl5/commit/1f4c25b3636fe61af34953a21afe9ed28b266d66
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: cb00acb83ae846edf86892f4dc4e20398594ddfb
https://github.com/Perl/perl5/commit/cb00acb83ae846edf86892f4dc4e20398594ddfb
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 15efd41bab1b676257d78293beeb364659f0a87b
https://github.com/Perl/perl5/commit/15efd41bab1b676257d78293beeb364659f0a87b
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 32d80513c0baa7f52c2d65cfca94f8a61a369986
https://github.com/Perl/perl5/commit/32d80513c0baa7f52c2d65cfca94f8a61a369986
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: b966198cf3e2327aba9723d7ac25ec1f6485764b
https://github.com/Perl/perl5/commit/b966198cf3e2327aba9723d7ac25ec1f6485764b
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 5f763a18e3336788e82e5c8ca4f621f76259ece2
https://github.com/Perl/perl5/commit/5f763a18e3336788e82e5c8ca4f621f76259ece2
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 304c92112a3a1e7744d5b8b39c0ffb3ae68e4a20
https://github.com/Perl/perl5/commit/304c92112a3a1e7744d5b8b39c0ffb3ae68e4a20
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: c9e679cbdfa59a3885e04ce7a90373ae56fe398a
https://github.com/Perl/perl5/commit/c9e679cbdfa59a3885e04ce7a90373ae56fe398a
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: f8869b6f67e5b02f51224477a68024332012f300
https://github.com/Perl/perl5/commit/f8869b6f67e5b02f51224477a68024332012f300
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 4e5814db4b9d145e44094250f88d0d3fe301ada7
https://github.com/Perl/perl5/commit/4e5814db4b9d145e44094250f88d0d3fe301ada7
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 64923af0c7abcd73635c432ff5cb103a4071fe21
https://github.com/Perl/perl5/commit/64923af0c7abcd73635c432ff5cb103a4071fe21
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 2e8819955d7e115eb7d4db3ab8a5c371344dfc91
https://github.com/Perl/perl5/commit/2e8819955d7e115eb7d4db3ab8a5c371344dfc91
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 1f48a0f021bd7f27b6fa992318cb60ba117966f5
https://github.com/Perl/perl5/commit/1f48a0f021bd7f27b6fa992318cb60ba117966f5
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 46b8acf592ee032adb800308ced73135bb2d8156
https://github.com/Perl/perl5/commit/46b8acf592ee032adb800308ced73135bb2d8156
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: ebc8f77978dfcd0e4b12d7e0741e65446fa2cc92
https://github.com/Perl/perl5/commit/ebc8f77978dfcd0e4b12d7e0741e65446fa2cc92
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 2224b9797b8f8ab0e1d8d8bdbf9855cbf83e91e1
https://github.com/Perl/perl5/commit/2224b9797b8f8ab0e1d8d8bdbf9855cbf83e91e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 97e86e97a72a2b356030ab36fa04ff6a0e5a7353
https://github.com/Perl/perl5/commit/97e86e97a72a2b356030ab36fa04ff6a0e5a7353
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: fa03a047b6529692f49d6441b038faed4b454902
https://github.com/Perl/perl5/commit/fa03a047b6529692f49d6441b038faed4b454902
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 70de551f3f76773723288953a0e89dfeaee3b216
https://github.com/Perl/perl5/commit/70de551f3f76773723288953a0e89dfeaee3b216
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 6a4fd1ddb961447a77afd7439e00340db3b72852
https://github.com/Perl/perl5/commit/6a4fd1ddb961447a77afd7439e00340db3b72852
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: b6a4a286ae6d80e6eccea9038f44aed1a59d3a1e
https://github.com/Perl/perl5/commit/b6a4a286ae6d80e6eccea9038f44aed1a59d3a1e
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 308d539619a976deb130ea67a8d93893c4129c81
https://github.com/Perl/perl5/commit/308d539619a976deb130ea67a8d93893c4129c81
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 1ab4a4f6fba9fef38f0334119b588f442248d4b0
https://github.com/Perl/perl5/commit/1ab4a4f6fba9fef38f0334119b588f442248d4b0
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 77025d900545d71c6d98dcfca6af1e0b4d823871
https://github.com/Perl/perl5/commit/77025d900545d71c6d98dcfca6af1e0b4d823871
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: 1295fdfa63215a43f3002be420114e3b22bac350
https://github.com/Perl/perl5/commit/1295fdfa63215a43f3002be420114e3b22bac350
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: f8c5a06a8f4294b51462631f0c63337e781261ce
https://github.com/Perl/perl5/commit/f8c5a06a8f4294b51462631f0c63337e781261ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 7c7ecde2e61d5be645fe8a6b5f761fc07655aa88
https://github.com/Perl/perl5/commit/7c7ecde2e61d5be645fe8a6b5f761fc07655aa88
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 108901b50f23fd3f233798948652ce74a2aa547c
https://github.com/Perl/perl5/commit/108901b50f23fd3f233798948652ce74a2aa547c
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 569ed67cb7436becfb991b8212dc92441488d8ac
https://github.com/Perl/perl5/commit/569ed67cb7436becfb991b8212dc92441488d8ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 134d80d8a5d08cdc8e84787be78b8fd23c6dc238
https://github.com/Perl/perl5/commit/134d80d8a5d08cdc8e84787be78b8fd23c6dc238
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: f44c356c6aa158fc7403674104417fedf57574da
https://github.com/Perl/perl5/commit/f44c356c6aa158fc7403674104417fedf57574da
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 6fe673730acc253df1bb1a408fd7c441deb444cc
https://github.com/Perl/perl5/commit/6fe673730acc253df1bb1a408fd7c441deb444cc
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 2d3a95a13611ce3b40ea56547b78499a549f1205
https://github.com/Perl/perl5/commit/2d3a95a13611ce3b40ea56547b78499a549f1205
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 4af25a42e49739f0105184c472710f2003b2635f
https://github.com/Perl/perl5/commit/4af25a42e49739f0105184c472710f2003b2635f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 5033c3fe5830c8513732e36bda0d2584249318b8
https://github.com/Perl/perl5/commit/5033c3fe5830c8513732e36bda0d2584249318b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: f131d13b8f0a5e4818a307735b586480ad2b7a6b
https://github.com/Perl/perl5/commit/f131d13b8f0a5e4818a307735b586480ad2b7a6b
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 3b1122dd7140720913fb50e66464befef8eba361
https://github.com/Perl/perl5/commit/3b1122dd7140720913fb50e66464befef8eba361
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: ce3a4d0b7f452aac9ffc251f8c406e31123cfac0
https://github.com/Perl/perl5/commit/ce3a4d0b7f452aac9ffc251f8c406e31123cfac0
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 8bb77921a4bb577903b2dd9531950fd2a768e1a4
https://github.com/Perl/perl5/commit/8bb77921a4bb577903b2dd9531950fd2a768e1a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: 1f20f211d5faa47021aadb888bbdfb756356797e
https://github.com/Perl/perl5/commit/1f20f211d5faa47021aadb888bbdfb756356797e
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 15d9f74c23d4ec0f44f6c6d52b1a3ab469f13c1a
https://github.com/Perl/perl5/commit/15d9f74c23d4ec0f44f6c6d52b1a3ab469f13c1a
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 5b44d4af78d0df8bfdde5401f7d6d5528baf948d
https://github.com/Perl/perl5/commit/5b44d4af78d0df8bfdde5401f7d6d5528baf948d
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 1557fbb230edb83f17bef215e738cd2d34058036
https://github.com/Perl/perl5/commit/1557fbb230edb83f17bef215e738cd2d34058036
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: a5f5b99e8a28c614e6976f5cd59b51115236edb7
https://github.com/Perl/perl5/commit/a5f5b99e8a28c614e6976f5cd59b51115236edb7
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: d342c13d905e1d9325dbc450fa034dff797f749d
https://github.com/Perl/perl5/commit/d342c13d905e1d9325dbc450fa034dff797f749d
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: e03b63049d29b86097a571fbf1f9d921e8d31e7b
https://github.com/Perl/perl5/commit/e03b63049d29b86097a571fbf1f9d921e8d31e7b
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: cedfbd0d0f9043e75d448a61adce8673f3867819
https://github.com/Perl/perl5/commit/cedfbd0d0f9043e75d448a61adce8673f3867819
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: adaaf4772eb237b95683fe3bec2988b413f22420
https://github.com/Perl/perl5/commit/adaaf4772eb237b95683fe3bec2988b413f22420
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 50239bb7e30978b0e0e5f1b3c047eba7cb8457c5
https://github.com/Perl/perl5/commit/50239bb7e30978b0e0e5f1b3c047eba7cb8457c5
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 2c1b54ff08e04f5e86c510077144eab5d5fc6bba
https://github.com/Perl/perl5/commit/2c1b54ff08e04f5e86c510077144eab5d5fc6bba
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 0a3aba8f8ea4b2ee674caedcf1749cfec6b9cfd2
https://github.com/Perl/perl5/commit/0a3aba8f8ea4b2ee674caedcf1749cfec6b9cfd2
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: 1ebb487d303b5a852de5dc72c2724f42fe0dd594
https://github.com/Perl/perl5/commit/1ebb487d303b5a852de5dc72c2724f42fe0dd594
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 331cb220645791e014a0ddd43e3140dbc5c60649
https://github.com/Perl/perl5/commit/331cb220645791e014a0ddd43e3140dbc5c60649
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 6f0a719f788aabc7ce6259756102a8d9d10954ac
https://github.com/Perl/perl5/commit/6f0a719f788aabc7ce6259756102a8d9d10954ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 6261dfce120b3f68fcb93b9f30c832be92b5d792
https://github.com/Perl/perl5/commit/6261dfce120b3f68fcb93b9f30c832be92b5d792
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: 52c253fde10e432ceca7ea2697da8d1d656dce1a
https://github.com/Perl/perl5/commit/52c253fde10e432ceca7ea2697da8d1d656dce1a
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: d56f4cc2fe5a7d125834c6f5f71f941c4af784e8
https://github.com/Perl/perl5/commit/d56f4cc2fe5a7d125834c6f5f71f941c4af784e8
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 8e0a3c39a9dc578bb152e9fd0325c1068d316fb6
https://github.com/Perl/perl5/commit/8e0a3c39a9dc578bb152e9fd0325c1068d316fb6
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 6412fb99e41e2cef7b8ca2b1231754d0f10a76e6
https://github.com/Perl/perl5/commit/6412fb99e41e2cef7b8ca2b1231754d0f10a76e6
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 355a720d2f1c8da1532e70aeddb386b4eae1f342
https://github.com/Perl/perl5/commit/355a720d2f1c8da1532e70aeddb386b4eae1f342
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: f33de7ca51e97ca10b208fae4259d57cabe8ccf9
https://github.com/Perl/perl5/commit/f33de7ca51e97ca10b208fae4259d57cabe8ccf9
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: 99e41984f75069326cbdbf39aa7b0b54ab0d298c
https://github.com/Perl/perl5/commit/99e41984f75069326cbdbf39aa7b0b54ab0d298c
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 77cf882a66e90fb7aef4ef9c9fde7c7188168882
https://github.com/Perl/perl5/commit/77cf882a66e90fb7aef4ef9c9fde7c7188168882
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: f9a9eb3d76ba315321668ce71ac8861b3d63a174
https://github.com/Perl/perl5/commit/f9a9eb3d76ba315321668ce71ac8861b3d63a174
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 2c39f75bc6700105d61b47a1394c570ae9049deb
https://github.com/Perl/perl5/commit/2c39f75bc6700105d61b47a1394c570ae9049deb
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 9448effa9bc01b68a97e675a7eac124cbea1b14e
https://github.com/Perl/perl5/commit/9448effa9bc01b68a97e675a7eac124cbea1b14e
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: d54416cadad3cd3c4b509c9138b6be1b249c04e5
https://github.com/Perl/perl5/commit/d54416cadad3cd3c4b509c9138b6be1b249c04e5
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 7afc00f904500f7c4d70dcaf43e69370f828ddcf
https://github.com/Perl/perl5/commit/7afc00f904500f7c4d70dcaf43e69370f828ddcf
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 21a648ad6f7089d435fb83e1c51a24245e1d0b84
https://github.com/Perl/perl5/commit/21a648ad6f7089d435fb83e1c51a24245e1d0b84
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: a45a68aabdaea67166358522f41b91684fde4f94
https://github.com/Perl/perl5/commit/a45a68aabdaea67166358522f41b91684fde4f94
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 173bd5677ad0c86ba63ad953933169869b8eb056
https://github.com/Perl/perl5/commit/173bd5677ad0c86ba63ad953933169869b8eb056
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: fd2da7eb8ee9a1bf036d8e7ab69c393fb8e6a822
https://github.com/Perl/perl5/commit/fd2da7eb8ee9a1bf036d8e7ab69c393fb8e6a822
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 39410c9edd1a7c9ece6d93458520ceac5ab2a74f
https://github.com/Perl/perl5/commit/39410c9edd1a7c9ece6d93458520ceac5ab2a74f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 684eb9d007e53c931cba1e1bebdbc1ceaf3c7f66
https://github.com/Perl/perl5/commit/684eb9d007e53c931cba1e1bebdbc1ceaf3c7f66
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: a62be02340423ed4c67038cb9cdba24540c5bc6a
https://github.com/Perl/perl5/commit/a62be02340423ed4c67038cb9cdba24540c5bc6a
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 74cccf534c037a62c2f8f72106db10c8521f8439
https://github.com/Perl/perl5/commit/74cccf534c037a62c2f8f72106db10c8521f8439
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 5f5df1d0f6a41f97bb748612f6ee5efd2813710f
https://github.com/Perl/perl5/commit/5f5df1d0f6a41f97bb748612f6ee5efd2813710f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 81271d425c84da8ced19495501929bfd40b9a602
https://github.com/Perl/perl5/commit/81271d425c84da8ced19495501929bfd40b9a602
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: ac9eae6160889609a985fcc376e658eba1c74411
https://github.com/Perl/perl5/commit/ac9eae6160889609a985fcc376e658eba1c74411
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: 7a4fd33e3d61803f69456e2b20da5262af04c71c
https://github.com/Perl/perl5/commit/7a4fd33e3d61803f69456e2b20da5262af04c71c
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: 1a23b257e716983c170f6a22115f01e040c65362
https://github.com/Perl/perl5/commit/1a23b257e716983c170f6a22115f01e040c65362
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Fix up a comment
Commit: c83ab25d338d19750f63bc4600a485bbaa511c76
https://github.com/Perl/perl5/commit/c83ab25d338d19750f63bc4600a485bbaa511c76
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M embed.fnc
M embed.h
M embedvar.h
M ext/XS-APItest/t/locale.t
M handy.h
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.c
M perl.h
M pod/perldiag.pod
M proto.h
M sv.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
24
Compare: https://github.com/Perl/perl5/compare/32cd19abbbc3...c83ab25d338d
