https://bugzilla.redhat.com/show_bug.cgi?id=2431593



--- Comment #18 from Sergio Arroutbi <[email protected]> ---
(In reply to Yaakov Selkowitz from comment #17)
> Again, the %cargo_license call needs to be in %build, not %install.  This is
> clearly stated in the guidelines:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_rpm_macros_2

Fixed. Let me update latest diff:

--- clevis-pin-trustee.spec.202601292103        2026-01-29 21:03:46.896607219
+0100
+++ clevis-pin-trustee.spec     2026-01-29 21:04:16.569237640 +0100
@@ -49,17 +49,15 @@
 %cargo_generate_buildrequires

 %build
-
 # Build using cargo macros
 %cargo_build

 # Generate license information for statically-linked dependencies
 %cargo_license_summary
-
-%install
 # Generate license file for bundled dependencies
 %{cargo_license} > LICENSE.dependencies

+%install
 # Install main binary
 install -D -m 0755 target/release/%{name} %{buildroot}%{_bindir}/%{name}

> 
> While you have been updating the spec file, the SRPM has not been
> regenerated.  Please update both in order for the review to be completed. 
> Once you have done so, use the instructions in the previous comment to
> retrigger the CI to generate a review template so that this can be completed.

Please, find updated .srpm file, aligned with latest .spec file:
https://sarroutb.fedorapeople.org/clevis-pin-trustee-0.0.1-1.fc44.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2431593

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202431593%23c18

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to