https://bugzilla.redhat.com/show_bug.cgi?id=2431593
--- Comment #11 from Yaakov Selkowitz <[email protected]> --- The output of %cargo_license_summary should be copy-and-pasted VERBATIM in the comment above the License tag. Where did you get CC0-1.0 as a license? The OR rule is a supplement/exception to the No Effective License Analysis rule. That means (Apache-2.0 OR MIT) need NOT be listed separately because both Apache-2.0 and MIT are already listed standalone, per the OR rule. Also, (Apache-2.0 OR MIT) and (MIT OR Apache-2.0) are the same thing, so even if the former didn't apply, there would be no need for both. (Perhaps this can be better spelled out in the OR rule.) The -n %{name}-%{version} arguments to %autosetup are unnecessary, as that is the default value. %cargo_summary doesn't belong in %install, and there is no need for two calls. The existing call in %build should be CHANGED per my previous comments. Also, both %cargo_license_summary and %cargo_license should FOLLOW %cargo_build, not precede it. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2431593 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202431593%23c11 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
