https://bugzilla.redhat.com/show_bug.cgi?id=2414840
Bug ID: 2414840
Summary: Review Request: giza - A 2D scientific plotting
library built on cairo
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
CC: [email protected]
Target Milestone: ---
Classification: Fedora
Spec URL:
https://kathenas.fedorapeople.org/development/fedora/rawhide/for_review/giza.spec
SRPM URL:
https://kathenas.fedorapeople.org/development/fedora/rawhide/for_review/giza-1.5.0-1.el9.src.rpm
Description:
A 2D scientific plotting library built on cairo. Provides uniform output to
PDF, PS, PNG and X-Windows. Written in C with no dependencies (other than
cairo) as a direct replacement for PGPLOT.
Fedora Account System Username: kathenas
Review build on copr:
https://copr.fedorainfracloud.org/coprs/kathenas/giza/build/9795251/
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU Lesser General Public License,
Version 3", "FSF Unlimited License (with License Retention) and/or GNU
General Public License v2.0 or later [generated file]", "FSF Unlimited
License [generated file]", "GNU General Public License v2.0 or later
[generated file]", "GNU General Public License v3.0 or later", "X11
License [generated file]", "GNU General Public License v2.0 or later",
"FSF Unlimited License (with License Retention) and/or GNU General
Public License, Version 2", "FSF Unlimited License (with License
Retention)", "GNU General Public License". 82 files have unknown
license. Detailed output of licensecheck in /var/lib/copr-
rpmbuild/results/giza/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[ ]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib64/gfortran
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib64/gfortran/modules,
/usr/lib64/gfortran
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 462040 bytes in 8 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: Static libraries in -static or -devel subpackage, providing -devel if
present.
Note: Package has .a files: giza-static.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[!]: Reviewer should test that the package builds in mock.
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in giza-
static
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[ ]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
Rpmlint
-------
Checking: giza-1.5.0-1.fc44.x86_64.rpm
giza-static-1.5.0-1.fc44.x86_64.rpm
giza-devel-1.5.0-1.fc44.x86_64.rpm
giza-1.5.0-1.fc44.src.rpm
============================ rpmlint session starts
============================
rpmlint: 2.8.0
configuration:
/usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpyafs4ehp')]
checks: 32, packages: 4
giza.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change
locale (en_US.UTF-8): No such file or directory
giza-devel.x86_64: W: no-documentation
giza.spec: W: no-%check-section
4 packages and 0 specfiles checked; 0 errors, 3 warnings, 38 filtered, 0
badness; has taken 0.5 s
Rpmlint (debuginfo)
-------------------
Checking: giza-debuginfo-1.5.0-1.fc44.x86_64.rpm
============================ rpmlint session starts
============================
rpmlint: 2.8.0
configuration:
/usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpl07nv9n0')]
checks: 32, packages: 1
1 packages and 0 specfiles checked; 0 errors, 0 warnings, 14 filtered, 0
badness; has taken 0.2 s
Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "giza-debuginfo".
(none): E: there is no installed rpm "giza-static".
(none): E: there is no installed rpm "giza".
============================ rpmlint session starts
============================
rpmlint: 2.8.0
configuration:
/usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 4
0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0
badness; has taken 0.0 s
(none): E: there is no installed rpm "giza-devel".
There are no files to process nor additional arguments.
Nothing to do, aborting.
Source checksums
----------------
https://github.com/danieljprice/giza/archive/refs/tags/v1.5.0.tar.gz#/giza-1.5.0.tar.gz
:
CHECKSUM(SHA256) this package :
d45f1f930b4e4a3c77e0b110b97b732c290d169bf9ae0c3fc7dcd2895c1b3afe
CHECKSUM(SHA256) upstream package :
d45f1f930b4e4a3c77e0b110b97b732c290d169bf9ae0c3fc7dcd2895c1b3afe
Requires
--------
giza (rpmlib, GLIBC filtered):
libX11.so.6()(64bit)
libc.so.6()(64bit)
libcairo.so.2()(64bit)
libfontconfig.so.1()(64bit)
libfreetype.so.6()(64bit)
libgcc_s.so.1()(64bit)
libgfortran.so.5()(64bit)
libgfortran.so.5(GFORTRAN_10)(64bit)
libgfortran.so.5(GFORTRAN_8)(64bit)
libgiza.so.2()(64bit)
libm.so.6()(64bit)
rtld(GNU_HASH)
giza-static (rpmlib, GLIBC filtered):
giza-devel(x86-64)
giza-devel (rpmlib, GLIBC filtered):
/usr/bin/pkg-config
giza(x86-64)
libcpgplot.so.2()(64bit)
libgiza.so.2()(64bit)
libpgplot.so.2()(64bit)
Provides
--------
giza:
giza
giza(x86-64)
libcpgplot.so.2()(64bit)
libgiza.so.2()(64bit)
libpgplot.so.2()(64bit)
giza-static:
giza-static
giza-static(x86-64)
giza-devel:
giza-devel
giza-devel(x86-64)
pkgconfig(cpgplot)
pkgconfig(giza)
pkgconfig(pgplot)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name giza
--mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Generic, Shell-api
Disabled plugins: Java, SugarActivity, Python, Perl, fonts, PHP, Haskell,
Ocaml, R
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2414840
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202414840%23c0
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
