> On Tue, 2021-10-05 at 22:40 +0300, Paul Fertser wrote: > > I only have D-Link DGS-1210-10P R1 for testing but other devices should be > > very > > similar judging by the photos. Would be nice to share support for all the > > features available rather than get just R1 fully working. > > > > Paul Fertser (5): > > realtek: split DGS-1210-10P DTS > > realtek: add all LEDs, buttons and SFP signals to DGS-1210-10 > > realtek: add non-PoE version of DGS-1210-10 F1 > > realtek: support D-Link DGS-1210-10P H/W:R1 > > realtek: support Trendnet TPE-082WS V1 > > Recently you two have provided some patches for the DGS-1210 switches, and you > apear to have a nice collection of different devices. I would like to draw > your > attention to these (old) patches, with some improvments Paul suggested. Sadly > nobody showed up to test them at the time. I was wondering if these changes > are > still relevant and if you could have a look at them.
I didn't have any DGS-1210 switches back then. Now I have hundreds. It looks like an interesting submission, still relevant but it requires a v2 rebasing and with the suggested changes. It uses SOC := rtl8380 while all existing dgs-1210 F1 variants use rtl8382 (except for the pending -52 variant). The commit didn't mention why that happened. I'm not sure which one is correct here. However, if it is really a different SoC and with what we currently know, we could create a generic rtl83xx_d-link_dgs-1210.dtsi as the -52 variant uses even a more different SoC (rtl8393). They share a lot of stuff like flash layout and gpios (and the vendor firmware even uses the same image). I could do some generic and family review but I only have -28 and -52 variants. > The different patches can be found at, and downloaded from: > https://patchwork.ozlabs.org/project/openwrt/list/?series=265587&state=* > > In case you weren't subscribed to the mailing list at the time and you would > like to reply to one of the patches, they can be downloaded from patchwork in > mbox format and imported into a mail client. > > Best, > Sander Regards, Luiz _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel