Or we could drop support for it and let the user do it by themselves. At least for the release of OpenWrt 21.02.
The warning pop-up when the user heads to Network -> Interfaces after upgrade, could let the user know that, if they have set up packet mirroring with swconfig, they will have to do it themselves for DSA. Arınç On Wed, Jul 21, 2021 at 9:44 AM Arınç ÜNAL <arinc.u...@gmail.com> wrote: > > If the user enabled packet mirroring on swconfig, we need to migrate that too. > > I don't think UCI supports packet mirroring via the DSA framework, > yet. Anyone with UCI knowledge want to help out? > tc-full package is needed. > > Refer to: > https://biot.com/switches/testing/mirroring > > > On Wed, Jul 21, 2021 at 8:31 AM Arınç ÜNAL <arinc.u...@gmail.com> wrote: > > > > Hi Rich > > > > On Wed, Jul 21, 2021 at 2:06 AM Rich Brown <richb.hano...@gmail.com> wrote: > > > > > > Hi Arınç > > > > > > On Jul 20, 2021, at 3:09 PM, Arınç ÜNAL <arinc.u...@gmail.com> wrote: > > > > > > Let's say we wrote a script that takes 19.07 network config and > > > outputs one with DSA configuration instead, how do we implement it in > > > the image that, after upgrade, it will ask the user to convert the > > > swconfig configuration to DSA? > > > > > > > > > I'm at the edge of my knowledge here - scripting ash/bash is not a strong > > > suit. But one random neuron fires: I do wonder whether it's worth > > > including a comment at the head of /etc/config/network something like > > > this: > > > > > > # Converted with swconfig2dsa on 22Jul2021 > > > > > > That could serve to indicate that you shouldn't run the script again. > > That's an idea. Although, I was thinking the script would only run > > once, i.e. after the upgrade, when the user heads to Network -> > > Interfaces, a warning pops up and forces the user to migrate to DSA. > > We wouldn't have to put any comment on the configuration file, keep > > things clean. > > > > Cheers. > > Arınç _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
