Hi,

just a taste nitpick:

> --- a/package/boot/uboot-envtools/files/realtek
> +++ b/package/boot/uboot-envtools/files/realtek
> @@ -15,15 +15,21 @@ zyxel,gs1900-10hp)
>       idx="$(find_mtd_index u-boot-env)"
>       [ -n "$idx" ] && \
>               ubootenv_add_uci_config "/dev/mtd$idx" "0x0" "0x400"
> "0x10000"
> +     idx="$(find_mtd_index u-boot-env2)"
> +     [ -n "$idx" ] && \
> +             ubootenv_add_uci_sys_config "/dev/mtd$idx" "0x0"

I'd personally use a different variable name here, e.g. idx2, so it's clearly 
separated.

BTW, if you only need the variable once, you can directly use logic on the 
assignment:

+       idx2="$(find_mtd_index u-boot-env2)" &&
+               ubootenv_add_uci_sys_config "/dev/mtd$idx2" "0x0"

Best

Adrian 

Attachment: openpgp-digital-signature.asc
Description: PGP signature

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to