Hi Rafal,
thanks for the review! On Thu, Jul 30, 2015 at 08:39:20AM +0200, Rafał Miłecki wrote: > On 30 July 2015 at 08:33, Daniel Golle <dan...@makrotopia.org> wrote: > > On Thu, Jul 30, 2015 at 05:55:02AM +0200, Rafał Miłecki wrote: > >> On 30 July 2015 at 03:52, Daniel Golle <dan...@makrotopia.org> wrote: > >> > Add new brcmfmac-firmware package. > >> > (Firmware blobs for BCM43362 were added upstream recently) > >> > PKG_MIRROR_MD5SUM should be re-added once the newer file is available > >> > on OpenWrt's mirror. > >> > >> You need to describe it better. What's the point of this if we already have > >> KernelPackage/brcmfmac > >> ? > > > > KernelPackage/brcmfmac contains the cfg80211 driver which needs > > binary firmware blobs to be present in /lib/firmware/brcm/ > > And this is why we already have it handled in > KernelPackage/brcmfmac/install Ok, I didn't know that. Sent an updated patch adding brcmfmac-sdio firmware files there. > > > > The blobs needed for BCM43362 were only recently added to > > linux-firmware, thus the version bump is needed as well. > > Why not bump PKG_LINUX_FIRMWARE_VERSION in > package/kernel/mac80211/Makefile > ? Did so in the updated patch, too. > You also shouldn't mix quite independent patches in one patchset. It > makes picking & pushing them more complex as various parts of OpenWrt > are usually handled by various developers. The reason why I made this a series is that these patches do somehow loosely depend on each other and should be applied in that order. Cheers Daniel > > -- > Rafał _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
