On 3 August 2015 at 22:59, Hauke Mehrtens <ha...@hauke-m.de> wrote: > On 07/30/2015 06:34 PM, Rafał Miłecki wrote: >> On 30 July 2015 at 10:52, Daniel Golle <dan...@makrotopia.org> wrote: >>> @@ -2000,6 +2000,50 @@ endef >>> >>> define KernelPackage/brcmfmac/install >>> $(INSTALL_DIR) $(1)/lib/firmware/brcm >>> +ifneq ($(CONFIG_BRCMFMAC_SDIO),) >>> + $(INSTALL_DATA) \ >>> + >>> $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac43143-sdio.bin \ >>> + $(1)/lib/firmware/brcm/ >>> + $(INSTALL_DATA) \ >>> + >>> $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac43241b0-sdio.bin >>> \ >>> + $(1)/lib/firmware/brcm/ >>> + $(INSTALL_DATA) \ >>> + >>> $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac43241b4-sdio.bin >>> \ >>> + $(1)/lib/firmware/brcm/ >>> + $(INSTALL_DATA) \ >>> + >>> $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac43241b5-sdio.bin >>> \ >>> + $(1)/lib/firmware/brcm/ >>> + $(INSTALL_DATA) \ >>> + >>> $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac4329-sdio.bin \ >>> + $(1)/lib/firmware/brcm/ >>> + $(INSTALL_DATA) \ >>> + >>> $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac4330-sdio.bin \ >>> + $(1)/lib/firmware/brcm/ >>> + $(INSTALL_DATA) \ >>> + >>> $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac4334-sdio.bin \ >>> + $(1)/lib/firmware/brcm/ >>> + $(INSTALL_DATA) \ >>> + >>> $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac4334-sdio.bin \ >>> + $(1)/lib/firmware/brcm/ >>> + $(INSTALL_DATA) \ >>> + >>> $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac43340-sdio.bin \ >>> + $(1)/lib/firmware/brcm/ >>> + $(INSTALL_DATA) \ >>> + >>> $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac43362-sdio.bin \ >>> + $(1)/lib/firmware/brcm/ >>> + $(INSTALL_DATA) \ >>> + >>> $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac4339-sdio.bin \ >>> + $(1)/lib/firmware/brcm/ >>> + $(INSTALL_DATA) \ >>> + >>> $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac43430-sdio.bin \ >>> + $(1)/lib/firmware/brcm/ >>> + $(INSTALL_DATA) \ >>> + >>> $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac43435-sdio.bin \ >>> + $(1)/lib/firmware/brcm/ >>> + $(INSTALL_DATA) \ >>> + >>> $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac4354-sdio.bin \ >>> + $(1)/lib/firmware/brcm/ >>> +endef >> >> Looks much better, thanks. >> >> Two things: >> 1) Do we want to include firmware for all brcmfmac supported devices? >> I guess some of them are e.g. smartphones and I'm not sure if anyone >> wants to run OpenWrt on them. Or should we split it into more options >> maybe? > > I think we should only add the firmware files we found on devices > running OpenWrt, each firmware is 216 to 580 KBytes. > > You could do it similar to the iwlwifi firmware and only select the > firmware files by default which are found in routers and if some special > firmware could be needed from some target only select it by default for > that target.
Sounds sane for me. Daniel: can you rewrite your patch to include only "really required" firmware files by default? And if you have some time, you can also add an extra option for adding rest of firmwares. -- Rafał _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
