On Tue, Apr 23, 2013 at 4:05 PM, gianluca a <gianluc...@hotmail.it> wrote: > Hi, > >> Hi, >> >> On 3 April 2013 12:38, gianluca a <gianluc...@hotmail.it> wrote: >> > Subject: [PATCH] [brcm68xx] led support for board DWV-S0 >> >> This is brcm63xx, not 68xx ;-) >> > > I got 68xx from page http://wiki.openwrt.org/doc/devel/add.new.device, I > didn't understand that it's a typo.
There is actually is a bcm68xx platform, but it isn't supported in OpenWrt (they are GPON devices). The wiki page is still wrong though. >> > Signed-off-by: Gianluca A. <gianluc...@hotmail.it> >> > >> > Index: a/arch/mips/bcm63xx/boards/board_bcm963xx.c >> >> Please create this as a patch for OpenWrt, not for the kernel. So this >> should be a patch adding a patch or modifying a patch. >> > > I used the how-to in http://wiki.openwrt.org/doc/devel/patches, section > "Adding or Editing kernel patches". > > Have I to use the procedure in section "Adding a new patch"? Is it valid for > this board patch? All you have to do is take this patch, put it into target/linux/brcm63xx/patches-3.{7,8}, make sure it applies, and you are done. The appropriate number is 55x (just take the next one free). >> > + .name = "DWV-S0:green:fastweb", >> > + .gpio = 7, >> > + .active_low = 1, >> > + }, >> > + { >> > + .name = "DWV-S0:green:linea", >> >> I think it would be a good idea to give these leds english names - not >> everyone speaks italian :) >> > > Ok, but I used these names because they are written in this way on the > plastic box of the router. > > Do you think that is better using different/translated names? I think so to have "common" led names for common functions. This makes it easier to use for non italian speakers, and makes it easier to write code dealing with certain leds. > And for the led "fastweb"? Fastweb is an italian ISP, the router is > distributed by them, and the led was used to report the status of the > connection at the MAN network Fastweb. I think it can stay. This is mostly for the "common" led names, where you want them named the same everywhere (voice/voip, dsl, internet, wifi, etc). Jonas _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
