Hi, > Hi, > > On 3 April 2013 12:38, gianluca a <gianluc...@hotmail.it> wrote: > > Subject: [PATCH] [brcm68xx] led support for board DWV-S0 > > This is brcm63xx, not 68xx ;-) >
I got 68xx from page http://wiki.openwrt.org/doc/devel/add.new.device, I didn't understand that it's a typo. > > Patch based on Attitude Adjustement 12.09, svn 36141 > > Please base all patches on trunk, not any branches. Patches will be > backported as applicable. > Ok, I'll do it, but... > > Signed-off-by: Gianluca A. <gianluc...@hotmail.it> > > > > Index: a/arch/mips/bcm63xx/boards/board_bcm963xx.c > > Please create this as a patch for OpenWrt, not for the kernel. So this > should be a patch adding a patch or modifying a patch. > I used the how-to in http://wiki.openwrt.org/doc/devel/patches, section "Adding or Editing kernel patches". Have I to use the procedure in section "Adding a new patch"? Is it valid for this board patch? > > =================================================================== > > --- a/arch/mips/bcm63xx/boards/board_bcm963xx.c > > +++ b/arch/mips/bcm63xx/boards/board_bcm963xx.c > > @@ -1754,6 +1754,95 @@ static struct board_info __initdata boar > > > > .has_ohci0 = 1, > > .has_ehci0 = 1, > > + > > + .leds = { > > + { > > + .name = "DWV-S0:red:power", > > + .gpio = 5, > > + .active_low = 1, > > + }, > > + { > > + .name = "DWV-S0:green:power", > > + .gpio = 4, > > + .active_low = 1, > > + .default_trigger = "default-on", > > + }, > > + { > > + .name = "DWV-S0:red:fastweb", > > + .gpio = 6, > > + .active_low = 1, > > + }, > > + { > > + .name = "DWV-S0:green:fastweb", > > + .gpio = 7, > > + .active_low = 1, > > + }, > > + { > > + .name = "DWV-S0:green:linea", > > I think it would be a good idea to give these leds english names - not > everyone speaks italian :) > Ok, but I used these names because they are written in this way on the plastic box of the router. Do you think that is better using different/translated names? And for the led "fastweb"? Fastweb is an italian ISP, the router is distributed by them, and the led was used to report the status of the connection at the MAN network Fastweb. > > + .gpio = 2, > > + .active_low = 1, > > + }, > > + { > > + .name = "DWV-S0:red:linea", > > + .gpio = 12, > > + .active_low = 1, > > + }, > > + { > > + .name = "DWV-S0:red:wifi", > > + .gpio = 10, > > + .active_low = 1, > > + }, > > + { > > + .name = "DWV-S0:green:voce", > > Likewise. > > > + .gpio = 9, > > + .active_low = 1, > > + }, > > + { > > + .name = "DWV-S0:red:voce", > > + .gpio = 0, > > + .active_low = 1, > > + }, > > + { > > + .name = "DWV-S0:red:ethernet", > > + .gpio = 1, > > + .active_low = 1, > > + }, > > + { > > + .name = "DWV-S0:green:ethernet", > > + .gpio = 8, > > + .active_low = 1, > > + }, > > + { > > + .name = "DWV-S0:red:USB", > > + .gpio = 11, > > + .active_low = 1, > > + }, > > + { > > + .name = "DWV-S0:green:USB", > > + .gpio = 3, > > + .active_low = 1, > > + }, > > + }, > > + > > + .buttons = { > > + { > > + .desc = "reset", > > + .gpio = 37, > > + .active_low = 1, > > + .type = EV_KEY, > > + .code = KEY_RESTART, > > + .debounce_interval = BCM963XX_KEYS_DEBOUNCE_INTERVAL, > > + }, > > + { > > + .desc = "wps", > > + .gpio = 34, > > + .active_low = 1, > > + .type = EV_KEY, > > + .code = KEY_WPS_BUTTON, > > + .debounce_interval = BCM963XX_KEYS_DEBOUNCE_INTERVAL, > > + }, > > + }, > > + > > }; > > > > /* D-Link DSL-274xB revison C2/C3 */ > > ---------------------------------------------------------------------- > > > > Gianluca > > _______________________________________________ > > openwrt-devel mailing list > > openwrt-devel@lists.openwrt.org > > https://lists.openwrt.org/mailman/listinfo/openwrt-devel > > _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
