Hi Daniel, On Wed, May 30, 2012 at 06:56:45PM +0200, Gabor Juhos wrote: > 2012.05.30. 14:14 keltezéssel, Jonas Gorski írta: > > Hi, > > > > some small nit-picks > > > > On 30 May 2012 10:08, Daniel Golle <dgo...@allnet.de> wrote: > >> This adds support for the Allnet ALL6000 board to the Kernel. > >> See > >> http://www.allnet.de/entwicklungsplatformen.html?&L=0 > >> > >> Signed-off-by: Daniel Golle <dgo...@allnet.de> > >> > > <snip> > > >> ++static void __init all6000_init(void) > >> ++{ > >> ++ kirkwood_init(); > >> ++ kirkwood_mpp_conf(all6000_mpp_config); > >> ++ > >> ++ kirkwood_uart0_init(); > >> ++ kirkwood_nand_init(ARRAY_AND_SIZE(all6000_nand_parts), 25); > >> ++ kirkwood_sdio_init(&all6000_mvsdio_data); > >> ++ > >> ++ if (gpio_request(29, "USB Power Enable") != 0 || > >> ++ gpio_direction_output(29, 1) != 0) > > > > you can drop the != 0 checks. > > It would be even better to use gpio_request_one instead of the two calls.
Please resend your patches so they match the new target layout. Regards, Luka _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
