On 07/20/2011 10:35 AM, Imre Kaloz wrote: >>> You should remove everything that not related to your target. >> >> As that kernel is developed for the "SPEAr" family of products it's not >> easy (or maybe not even possible) to remove the features of a single >> SoC... At minimum it's a very tedious job. Besides, the same patch would >> allow OpenWRT to run on a multitude of chips, why limit it? > > Because files/patches added for your target should modify the generic stuff > only for the changes needed for that target. Anything touching other files in > the kernel tree should be removed from the patch.
I see, for some reason there is a patch backported from 2.6.38 (77f431561ef97dda1d6e9a96da8d342046fbdba0), I am not sure why. I will see if I can remove as it is cosmetic only, but let me ask: as this patch is specific for this board/SoC (won't interfere with other boards), and it comes directly from the manufacturer - it is public code at: http://git.stlinux.com/?p=spear/linux-2.6.git;a=summary it has been *validated* by a test team and so on; why OpenWRT requires to remove modifications to generic stuff? It would be almost impossible to maintain for me, everytime they have an update. Of course I modified this patch slightly to be able to apply OpenWRT generic patches - is that not enough? Eventually, the SPEAr support will go in the mainline kernel, removing the necessity for this patch at all, but although there is some support in the newest vanilla kernels, it is not quite ready yet. bye as _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
