On Mon, 2011-07-18 at 09:23 -0700, Alessio Sangalli wrote:
> On 07/16/2011 12:27 PM, Alessio Sangalli wrote:
> 
> >> To better answer that question, you should put the patch somewhere, 
> >> because of 
> >> the mailing-list attachment size limitation. Then we can comment on your 
> >> patch 
> >> and tell you whether it's acceptable or not.
> > 
> > I'm sorry I forgot to provide the URL I've uploaded it:
> > http://lnx.manoweb.com/openwrt.patch.xz
> 
> 
> ping
> 


I just opened it up and the first thing that met my eyes were :

 
 PKG_NAME:=Build dependency
 
-define Require/non-root
-       [ "$$(shell whoami)" != "root" ]
-endef
-$(eval $(call Require,non-root, \
-       Please do not compile as root. \
-))
-

 --  really?

I'm not qualified to speak for the rest of the patch, but some of the
contained patches I wonder about, ( Spelling changes and such  )  are
these submitted upstream?

Regards, 
   Spid

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to