Hi all, I like the readability of this patch, clear function names, good structure ! Lowers the entry threshold of reading the code for me.
The option of an additional sh-only-basefile package sounds like I good compromise. As I can see, Bastian opts as a maintainer already ;) H2o ps: form the discussions so far I can see the argumentations like: -the complexity and therefore the needed skill level to read/understand uncommented source code tends to grow with the amount of different languages in use vs. if there is a good purpose, choose the right language to fulfill your task -if someone is willing to enhance the readability he could change the code to be more self-readable or just add some comments within the code ... even if there is no functionality coming to the code with these patch, it increases the readability for me H2o -----Ursprüngliche Nachricht----- Von: openwrt-devel-boun...@lists.openwrt.org [mailto:openwrt-devel-boun...@lists.openwrt.org] Im Auftrag von Bastian Bittorf Gesendet: Mittwoch, 19. Januar 2011 15:54 An: mailinglist Betreff: [OpenWrt-Devel] [PATCH] base-files/hotplug: refactoring ifup/netstate V2 it is always a bad idea to mix up different languages in one environment. now we use ash-builtins to get uptime_in_seconds() instead of using cryptic sed-style. Signed-off-by: Bastian Bittorf <bittorf at bluebottle.com> _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
