> Did you test it with the other 'selectable' shells as well?

only with dash/bash and ash,
but these commands are very simple and are
working on every somehow organzied posix-shell.

> IMHO you should keep things as they are. I had to read your patch
> three times before I got the clue what you're trying

really? come'on: what does a function named uptime_in_seconds() ?

> to accomplish, while the original line simply read 'ah they use sed
> to filter something out of /proc/uptime'. I think

you named it: something.

> this use of sed is common sense.

yes, but this does'nt make it better if many
people do it wrong.

> If you think that sed regular expressions are cryptic (and I agree

i'am very familiar with sed and use it very
often - but thats not the point. the point is:
we don't must use another language, if it
doesnt make sense (e.g. for speed)

bye, Bastian. - (who want's to do a refactoring and reordering on the hole 
base-files stuff which is a real mess...)
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to