Hi Bastian, On 19/01/11 08:58, Bastian Bittorf wrote: > it is always a bad idea to mix up different languages > in one environment. But IMHO it's a good thing to use proven tools that are designed to do precisely that. > now we use ash-builtins to get > uptime_in_seconds() instead of using cryptic sed-style Did you test it with the other 'selectable' shells as well?
IMHO you should keep things as they are. I had to read your patch three times before I got the clue what you're trying to accomplish, while the original line simply read 'ah they use sed to filter something out of /proc/uptime'. I think this use of sed is common sense. If you think that sed regular expressions are cryptic (and I agree they sometimes tend to do) then please just spend some time and read a little bit about regular expressions. IMHO using sed is just as much a required skill for a Linux programmer than knowing your way around the shell. Best regards, Mark _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
