On Mon, 19 Jul 2010 13:49:19 -0300, Antonio Grassi <agras...@gmail.com>
wrote:
> It would be great if some OpenWRT developer could review it and send
some
> feedback about the inclusion of this patch; probably there are things to
be
> solved or improved before inclusion, so it would be great to hear about
> that
> too.
>
I'm not an OpenWRT developer. My feeling is that non-intrusive "libre"
patches might get accepted by OpenWRT. Then a seperate LibreWRT archive
isn't needed.
Regarding the kernel version, I think we need to have a "vanilla" linux
kernel version and a libre one, but not written like
ifneq ($(CONFIG_USE_LIBRE_KERNEL),)
LINUX_VERSION:=2.6.34.1-libre
else
LINUX_VERSION:=2.6.34.1
endif
in many makefiles as this makes them messy and grepping for the
LINUX_VERSION unclean. It does not scale well if you would like to add more
different kernel tastes.
A cleaner solution could be to have something like:
VANILLA_LINUX_VERSION:=2.6.34.1
LIBRE_LINUX_VERSION:=2.6.34.1-libre # or even
LIBRE_LINUX_VERSION:=$(VANILLA_LINUX_VERSION)-$(LIBRE)$(LIBRE_VERSION)
in the Makefiles where the VANILLA_LINUX_VERSION is maintained by OpenWRT
and LIBRE_LINUX_VERSION by LIBRE_POSTFIX LibreWRT.
In kernel.mk, we can simply assign the proper kernel to KERNEL_VERSION
with something like:
ifneq ($(CONFIG_USE_LIBRE_KERNEL),)
LINUX_VERSION:=LIBRE_LINUX_VERSION
else
LINUX_VERSION:=VANILLA_LINUX_VERSION
endif
# Fall back to vanilla
ifeq ($(LINUX_VERSION),)
LINUX_VERSION:=VANILLA_LINUX_VERSION
endif
> PS: I'm CC'ing the LibreWRT development list
>
I'm not a member of that list, so I cannot copy that list.
Regards,
--
Bas.
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
