Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change by flichtenheld. ( 
http://gerrit.openvpn.net/c/openvpn/+/1300?usp=email )

Change subject: ssl: Clean up type handling in write_string()
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

File src/openvpn/ssl.c:

http://gerrit.openvpn.net/c/openvpn/+/1300/comment/316cab45_6e3be2a4?usp=email :
PS5, Line 1787:     const size_t real_maxlen = (maxlen >= 0 && maxlen <= 
UINT16_MAX) ? (size_t)maxlen : UINT16_MAX;
```suggestion
    const size_t real_maxlen = (maxlen >= 0 && maxlen <= UINT16_MAX) ? 
(size_t)maxlen : UINT16_MAX;
```



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1300?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3309265edf8d6bea7bd73b21eef589a92ede6e0a
Gerrit-Change-Number: 1300
Gerrit-PatchSet: 5
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Tue, 11 Nov 2025 11:03:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to