Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1300?usp=email )
Change subject: ssl: Clean up type handling in write_string() ...................................................................... Patch Set 4: (1 comment) File src/openvpn/ssl.c: http://gerrit.openvpn.net/c/openvpn/+/1300/comment/24c81aca_9a5c48f2?usp=email : PS3, Line 1788: if (len < 2 || len > real_maxlen) > changing this from "< 1" to "< 2" is surprising, and I think, not correct - > we can and do write empt […] Right, removed the check completely. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1300?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3309265edf8d6bea7bd73b21eef589a92ede6e0a Gerrit-Change-Number: 1300 Gerrit-PatchSet: 4 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Comment-Date: Mon, 03 Nov 2025 12:04:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
