Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1300?usp=email )
Change subject: ssl: Clean up type handling in write_string() ...................................................................... Patch Set 4: Code-Review+2 (1 comment) File src/openvpn/ssl.c: http://gerrit.openvpn.net/c/openvpn/+/1300/comment/00f9633e_e49112f5?usp=email : PS3, Line 1788: if (len < 2 || len > real_maxlen) > Right, removed the check completely. Indeed. If `strlen(str)` is 0, `len == 1`, so `len < 1` can just not happen anymore. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1300?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3309265edf8d6bea7bd73b21eef589a92ede6e0a Gerrit-Change-Number: 1300 Gerrit-PatchSet: 4 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Tue, 04 Nov 2025 09:19:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: cron2 <[email protected]> Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
