Attention is currently required from: flichtenheld, mrbff, plaisthos. cron2 has posted comments on this change by mrbff. ( http://gerrit.openvpn.net/c/openvpn/+/1253?usp=email )
The change is no longer submittable: Code-Review is unsatisfied now. Change subject: PUSH_UPDATE server: remove old IP(s) from vhash after sending a message containing ifconfig(-ipv6) ...................................................................... Patch Set 4: Code-Review-1 (1 comment) Patchset: PS4: Aaaah, partly there. So, the *first* "PUSH_UPDATE,ifconfig..." works as expected - new IP address is pinging - old IP address is logged as "unlearn_addr()" - packets for new IP are sent to the client, packets for old IP are no longer sent (verified with tcpdump on the client tun) This works for both IPv4 and IPv6. Then, another "PUSH_UPDATE,ifconfig..." and it correctly learns the "new new" IP address, but does not unlearn the second address, and tcpdump shows packets for 2 IPs arrive (.99 is the "first PUSH_UPDATE", .146 is the "second PUSH_UPDATE") ``` 12:39:48.791099 IP 10.204.2.1 > 10.204.2.99: ICMP echo request, id 50521, seq 90, length 64 12:39:48.791109 IP 10.204.2.1 > 10.204.2.99: ICMP echo request, id 50521, seq 90, length 64 12:39:48.791122 IP 10.204.2.1 > 10.204.2.146: ICMP echo request, id 64784, seq 90, length 64 ``` packets are logged twice because the client has routing enabled and just sends the packet back (the server will then log `MULTI: bad source address from client [10.204.2.1], packet dropped`). -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1253?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I07a8ddd9026eef64b6f5abde98702a9801616a5f Gerrit-Change-Number: 1253 Gerrit-PatchSet: 4 Gerrit-Owner: mrbff <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: mrbff <[email protected]> Gerrit-Comment-Date: Mon, 13 Oct 2025 10:42:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
