Attention is currently required from: cron2, flichtenheld, plaisthos. mrbff has posted comments on this change by mrbff. ( http://gerrit.openvpn.net/c/openvpn/+/1253?usp=email )
Change subject: PUSH_UPDATE server: remove old IP(s) from vhash after sending a message containing ifconfig(-ipv6) ...................................................................... Patch Set 4: (6 comments) File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/1253/comment/669873c8_f711dc79?usp=email : PS3, Line 4296: msg(D_MULTI_LOW, "MULTI: Remove: %s -> %s", mroute_addr_print(&r->addr, &gc), multi_instance_string(mi, false, &gc)); > this is too much logging ;-) […] Done http://gerrit.openvpn.net/c/openvpn/+/1253/comment/94ace8fa_436f6223?usp=email : PS3, Line 4301: > we might have a memleak here. I looked at the code in "multi. […] Done http://gerrit.openvpn.net/c/openvpn/+/1253/comment/cf4e61f7_f768ee6d?usp=email : PS3, Line 4320: ASSERT(mroute_extract_openvpn_sockaddr(&addr, &remote_si, false)); > This works, but feels more clumsy than needed - looking through mroute.c, I > find […] mroute_get_in_addr_t() and mroute_get_in6_add6() are a static inline (and i suppose there is a reason for that, but even if not, why bother), anyway i got your point and i tried to make the helper less clumsy and more symmetric. http://gerrit.openvpn.net/c/openvpn/+/1253/comment/cec62582_b1eddb2e?usp=email : PS3, Line 4339: > `mroute_get_in6_addr(&addr, a6, 0)` does this for you Acknowledged http://gerrit.openvpn.net/c/openvpn/+/1253/comment/5bac7178_9e782090?usp=email : PS3, Line 4366: old_addr.s_addr = ntohl(mi->context.c2.push_ifconfig_local); > we could just do `in_addr_t old_addr = ... […] Done File src/openvpn/push_util.c: http://gerrit.openvpn.net/c/openvpn/+/1253/comment/79224a68_ad59ff25?usp=email : PS3, Line 158: memset(&o, 0, sizeof(struct options)); > please use `CLEAR(o);` for that. […] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1253?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I07a8ddd9026eef64b6f5abde98702a9801616a5f Gerrit-Change-Number: 1253 Gerrit-PatchSet: 4 Gerrit-Owner: mrbff <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Mon, 13 Oct 2025 08:59:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
