Attention is currently required from: flichtenheld, mrbff, plaisthos. cron2 has posted comments on this change by mrbff. ( http://gerrit.openvpn.net/c/openvpn/+/1253?usp=email )
Change subject: PUSH_UPDATE server: remove old IP(s) from vhash after sending a message containing ifconfig(-ipv6) ...................................................................... Patch Set 4: Code-Review+2 (1 comment) File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/1253/comment/08a5a1e5_12b1e3b5?usp=email : PS3, Line 4320: ASSERT(mroute_extract_openvpn_sockaddr(&addr, &remote_si, false)); > mroute_get_in_addr_t() and mroute_get_in6_add6() are a static inline (and i > suppose there is a reaso […] Ah, how annoying. Didn't notice the `static inline`. Yeah, it's only used inside mroute.c today - we could export it, or make it non-inline, but this would make the scope of the patch much larger. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1253?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I07a8ddd9026eef64b6f5abde98702a9801616a5f Gerrit-Change-Number: 1253 Gerrit-PatchSet: 4 Gerrit-Owner: mrbff <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: mrbff <[email protected]> Gerrit-Comment-Date: Mon, 13 Oct 2025 09:19:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: cron2 <[email protected]> Comment-In-Reply-To: mrbff <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
